From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: lirc@bartelmus.de (Christoph Bartelmus)
Cc: kosaki.motohiro@jp.fujitsu.com, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: [PATCH] export get_task_comm()
Date: Tue, 27 Jan 2009 14:09:05 +0900 (JST) [thread overview]
Message-ID: <20090128140615.D464.KOSAKI.MOTOHIRO@jp.fujitsu.com> (raw)
In-Reply-To: <AuEeLWHZjFB@christoph>
> Hi,
>
> on 19 Jan 09 at 07:36, KOSAKI Motohiro wrote:
> >> is there any reason why get_task_comm() is not exported in fs/exec.c?
>
> > In general, the only function of anybody necessarity explained is exported.
> > if you want to export get_task_comm(), you need to explain reasonable
> > reason.
>
> It's nothing that important: just want to print the executable name to the
> logs during error handling. get_task_comm() is the required accessor
> function.
>
> http://lirc.cvs.sourceforge.net/viewvc/lirc/lirc/drivers/lirc_dev/lirc_dev.c?revision=1.70&view=markup
To be honest, I don't use get_task_comm(). but I don't oppose your request.
==
Subject: [PATCH] export get_task_comm()
task::comm is good debugging information and driver developer want to
use this information easily.
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
---
fs/exec.c | 1 +
1 file changed, 1 insertion(+)
Index: b/fs/exec.c
===================================================================
--- a/fs/exec.c
+++ b/fs/exec.c
@@ -936,6 +936,7 @@ char *get_task_comm(char *buf, struct ta
task_unlock(tsk);
return buf;
}
+EXPORT_SYMBOL_GPL(get_task_comm);
void set_task_comm(struct task_struct *tsk, char *buf)
{
next prev parent reply other threads:[~2009-01-27 5:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-16 19:32 get_task_comm() not exported? Christoph Bartelmus
2009-01-18 22:36 ` KOSAKI Motohiro
2009-01-20 21:24 ` Christoph Bartelmus
2009-01-27 5:09 ` KOSAKI Motohiro [this message]
2009-01-27 5:16 ` [PATCH] export get_task_comm() Andrew Morton
2009-01-27 5:19 ` Kyle McMartin
2009-01-27 5:26 ` Andrew Morton
2009-01-27 5:29 ` Andrew Morton
2009-01-27 5:39 ` [PATCH] make checkpatch warn about access to current->comm Kyle McMartin
2009-01-27 5:50 ` KOSAKI Motohiro
2009-01-27 5:52 ` Kyle McMartin
2009-01-27 5:58 ` KOSAKI Motohiro
2009-01-27 6:09 ` Kyle McMartin
2009-01-27 15:45 ` Linus Torvalds
2009-01-27 15:57 ` Kyle McMartin
2009-01-27 18:15 ` Christoph Bartelmus
2009-01-27 8:49 ` [PATCH] export get_task_comm() Alexey Dobriyan
2009-01-27 9:00 ` Andrew Morton
2009-01-27 10:15 ` KOSAKI Motohiro
2009-01-27 15:41 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090128140615.D464.KOSAKI.MOTOHIRO@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lirc@bartelmus.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®