From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: kosaki.motohiro@jp.fujitsu.com,
Alexey Dobriyan <adobriyan@gmail.com>,
Kyle McMartin <kyle@infradead.org>,
Christoph Bartelmus <lirc@bartelmus.de>,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Andy Whitcroft <apw@shadowen.org>
Subject: Re: [PATCH] export get_task_comm()
Date: Tue, 27 Jan 2009 19:15:52 +0900 (JST) [thread overview]
Message-ID: <20090127191413.D488.KOSAKI.MOTOHIRO@jp.fujitsu.com> (raw)
In-Reply-To: <20090127010035.18521a3b.akpm@linux-foundation.org>
> > > It's worth a checkpatch rule, I guess: "direct access to
> > > task_struct.comm is racy - use get_task_comm()".
> >
> > And majority of usages is some debugging printk where nobody cares if ->comm
> > corrupted.
> >
> > Changelog says is useful for debugging. That's right, tsk->comm is useful
> > for debugging, not allocating temporary buffer + get_task_comm().
> >
> > Some ->comm usages are for kernel threads which never change it, for starters.
> >
> > current->comm is always safe, because, current is not executing prctl(2)!
>
> That's a good point.
>
> > I'd say nothing should be done and, heavens forbid, adding this to checkpatch.pl.
>
> hm, yeah, OK, I'll drop it.
Oh, I have to agree Alexey because he is always right ;)
next prev parent reply other threads:[~2009-01-27 10:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-16 19:32 get_task_comm() not exported? Christoph Bartelmus
2009-01-18 22:36 ` KOSAKI Motohiro
2009-01-20 21:24 ` Christoph Bartelmus
2009-01-27 5:09 ` [PATCH] export get_task_comm() KOSAKI Motohiro
2009-01-27 5:16 ` Andrew Morton
2009-01-27 5:19 ` Kyle McMartin
2009-01-27 5:26 ` Andrew Morton
2009-01-27 5:29 ` Andrew Morton
2009-01-27 5:39 ` [PATCH] make checkpatch warn about access to current->comm Kyle McMartin
2009-01-27 5:50 ` KOSAKI Motohiro
2009-01-27 5:52 ` Kyle McMartin
2009-01-27 5:58 ` KOSAKI Motohiro
2009-01-27 6:09 ` Kyle McMartin
2009-01-27 15:45 ` Linus Torvalds
2009-01-27 15:57 ` Kyle McMartin
2009-01-27 18:15 ` Christoph Bartelmus
2009-01-27 8:49 ` [PATCH] export get_task_comm() Alexey Dobriyan
2009-01-27 9:00 ` Andrew Morton
2009-01-27 10:15 ` KOSAKI Motohiro [this message]
2009-01-27 15:41 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090127191413.D488.KOSAKI.MOTOHIRO@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=kyle@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lirc@bartelmus.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®