Re: netrom: zero length frame filtering in NetRom

Re: netrom: zero length frame filtering in NetRom

[Alan Cox]

> +	/* NetRom empty data frame has no meaning : ignore it */
> +	if (copied == 0) {
> +		goto out;
> +	}
> +

Also broken - and doesn't follow the coding style either 8)

I'm not familiar enough with ROSE to tell if the ROSE one is wrong, but
rose is X.25 LL based (sadly without the X.29 layer) so it seems odd
there too (especially for datagram services)

Re: netrom: zero length frame filtering in NetRom

[David Miller]

From: Alan Cox <alan@lxorguk.ukuu.org.uk>
Date: Fri, 27 Mar 2009 10:28:23 +0000

> 
> > +	/* NetRom empty data frame has no meaning : ignore it */
> > +	if (copied == 0) {
> > +		goto out;
> > +	}
> > +
> 
> Also broken - and doesn't follow the coding style either 8)

Well, you send these turds to me and you're usually knowledgable
in the amateur radio protocol area :-)

I'll back them both out which is what I assume you want me to
do.

Re: netrom: zero length frame filtering in NetRom

[David Miller]

From: David Miller <davem@davemloft.net>
Date: Fri, 27 Mar 2009 14:34:06 -0700 (PDT)

> From: Alan Cox <alan@lxorguk.ukuu.org.uk>
> Date: Fri, 27 Mar 2009 10:28:23 +0000
> 
> > 
> > > +	/* NetRom empty data frame has no meaning : ignore it */
> > > +	if (copied == 0) {
> > > +		goto out;
> > > +	}
> > > +
> > 
> > Also broken - and doesn't follow the coding style either 8)
> 
> Well, you send these turds to me and you're usually knowledgable
> in the amateur radio protocol area :-)

Sorry Alan, I thought you were replying to the patches you
sent yesterday, my bad.

Re: netrom: zero length frame filtering in NetRom

[Alan Cox]

On Fri, 27 Mar 2009 14:34:06 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:

> From: Alan Cox <alan@lxorguk.ukuu.org.uk>
> Date: Fri, 27 Mar 2009 10:28:23 +0000
> 
> > 
> > > +	/* NetRom empty data frame has no meaning : ignore it */
> > > +	if (copied == 0) {
> > > +		goto out;
> > > +	}
> > > +
> > 
> > Also broken - and doesn't follow the coding style either 8)
> 
> Well, you send these turds to me and you're usually knowledgable
> in the amateur radio protocol area :-)
> 
> I'll back them both out which is what I assume you want me to
> do.

Yes. Handling zero length frames with socket API is nasty and ugly but
unfortunately its a valid use of these protocols. I need to go read the
AF_ROSE docs to double check the situation with ROSE but the other two
definitely want backing out.

Alan

Re: netrom: zero length frame filtering in NetRom

[David Miller]

From: Alan Cox <alan@lxorguk.ukuu.org.uk>
Date: Sat, 28 Mar 2009 00:21:37 +0000

> On Fri, 27 Mar 2009 14:34:06 -0700 (PDT)
> David Miller <davem@davemloft.net> wrote:
> 
> > I'll back them both out which is what I assume you want me to
> > do.
> 
> Yes. Handling zero length frames with socket API is nasty and ugly but
> unfortunately its a valid use of these protocols. I need to go read the
> AF_ROSE docs to double check the situation with ROSE but the other two
> definitely want backing out.

Ok, both reverted, thanks.