* Re: netrom: zero length frame filtering in NetRom
[not found] <200903270102.n2R12S2U021576@hera.kernel.org>
@ 2009-03-27 10:28 ` Alan Cox
2009-03-27 21:34 ` David Miller
0 siblings, 1 reply; 5+ messages in thread
From: Alan Cox @ 2009-03-27 10:28 UTC (permalink / raw)
To: Linux Kernel Mailing List; +Cc: davem
> + /* NetRom empty data frame has no meaning : ignore it */
> + if (copied == 0) {
> + goto out;
> + }
> +
Also broken - and doesn't follow the coding style either 8)
I'm not familiar enough with ROSE to tell if the ROSE one is wrong, but
rose is X.25 LL based (sadly without the X.29 layer) so it seems odd
there too (especially for datagram services)
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: netrom: zero length frame filtering in NetRom
2009-03-27 10:28 ` netrom: zero length frame filtering in NetRom Alan Cox
@ 2009-03-27 21:34 ` David Miller
2009-03-27 22:14 ` David Miller
2009-03-28 0:21 ` Alan Cox
0 siblings, 2 replies; 5+ messages in thread
From: David Miller @ 2009-03-27 21:34 UTC (permalink / raw)
To: alan; +Cc: linux-kernel
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
Date: Fri, 27 Mar 2009 10:28:23 +0000
>
> > + /* NetRom empty data frame has no meaning : ignore it */
> > + if (copied == 0) {
> > + goto out;
> > + }
> > +
>
> Also broken - and doesn't follow the coding style either 8)
Well, you send these turds to me and you're usually knowledgable
in the amateur radio protocol area :-)
I'll back them both out which is what I assume you want me to
do.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: netrom: zero length frame filtering in NetRom
2009-03-27 21:34 ` David Miller
@ 2009-03-27 22:14 ` David Miller
2009-03-28 0:21 ` Alan Cox
1 sibling, 0 replies; 5+ messages in thread
From: David Miller @ 2009-03-27 22:14 UTC (permalink / raw)
To: alan; +Cc: linux-kernel
From: David Miller <davem@davemloft.net>
Date: Fri, 27 Mar 2009 14:34:06 -0700 (PDT)
> From: Alan Cox <alan@lxorguk.ukuu.org.uk>
> Date: Fri, 27 Mar 2009 10:28:23 +0000
>
> >
> > > + /* NetRom empty data frame has no meaning : ignore it */
> > > + if (copied == 0) {
> > > + goto out;
> > > + }
> > > +
> >
> > Also broken - and doesn't follow the coding style either 8)
>
> Well, you send these turds to me and you're usually knowledgable
> in the amateur radio protocol area :-)
Sorry Alan, I thought you were replying to the patches you
sent yesterday, my bad.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: netrom: zero length frame filtering in NetRom
2009-03-27 21:34 ` David Miller
2009-03-27 22:14 ` David Miller
@ 2009-03-28 0:21 ` Alan Cox
2009-03-28 0:24 ` David Miller
1 sibling, 1 reply; 5+ messages in thread
From: Alan Cox @ 2009-03-28 0:21 UTC (permalink / raw)
To: David Miller; +Cc: linux-kernel
On Fri, 27 Mar 2009 14:34:06 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:
> From: Alan Cox <alan@lxorguk.ukuu.org.uk>
> Date: Fri, 27 Mar 2009 10:28:23 +0000
>
> >
> > > + /* NetRom empty data frame has no meaning : ignore it */
> > > + if (copied == 0) {
> > > + goto out;
> > > + }
> > > +
> >
> > Also broken - and doesn't follow the coding style either 8)
>
> Well, you send these turds to me and you're usually knowledgable
> in the amateur radio protocol area :-)
>
> I'll back them both out which is what I assume you want me to
> do.
Yes. Handling zero length frames with socket API is nasty and ugly but
unfortunately its a valid use of these protocols. I need to go read the
AF_ROSE docs to double check the situation with ROSE but the other two
definitely want backing out.
Alan
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: netrom: zero length frame filtering in NetRom
2009-03-28 0:21 ` Alan Cox
@ 2009-03-28 0:24 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2009-03-28 0:24 UTC (permalink / raw)
To: alan; +Cc: linux-kernel
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
Date: Sat, 28 Mar 2009 00:21:37 +0000
> On Fri, 27 Mar 2009 14:34:06 -0700 (PDT)
> David Miller <davem@davemloft.net> wrote:
>
> > I'll back them both out which is what I assume you want me to
> > do.
>
> Yes. Handling zero length frames with socket API is nasty and ugly but
> unfortunately its a valid use of these protocols. I need to go read the
> AF_ROSE docs to double check the situation with ROSE but the other two
> definitely want backing out.
Ok, both reverted, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-03-28 0:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <200903270102.n2R12S2U021576@hera.kernel.org>
2009-03-27 10:28 ` netrom: zero length frame filtering in NetRom Alan Cox
2009-03-27 21:34 ` David Miller
2009-03-27 22:14 ` David Miller
2009-03-28 0:21 ` Alan Cox
2009-03-28 0:24 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome