From: Ben Blum <bblum@google.com>
To: linux-kernel@vger.kernel.org,
containers@lists.linux-foundation.org, akpm@linux-foundation.org,
serue@us.ibm.com, lizf@cn.fujitsu.com, menage@google.com,
bblum@google.com
Subject: [PATCH 0/6] CGroups: cgroup memberlist enhancement+fix
Date: Thu, 23 Jul 2009 20:21:35 -0700 [thread overview]
Message-ID: <20090724032033.2463.79256.stgit@hastromil.mtv.corp.google.com> (raw)
(This patch series contains revisions of the patches from
http://lkml.org/lkml/2009/7/10/396 and a few more.)
The following series adds a "cgroup.procs" file to each cgroup that reports
unique tgids rather than pids, which can also be written to for moving all
threads in a threadgroup at once.
Patch #5 introduces a new rwsem that must be taken for reading in the fork()
path, and patch #6 reveals potential for a race when forking in certain
subsystems before the subsystem's attach() function is called, the naive
solution to which would be holding on to the fork rwsem until after the attach
loop. Suggestions for alternative approaches or tweaks to the current approach
are welcome; one potential fix is to make the fork rwsem per-threadgroup,
which will involve adding a field to task_struct, thereby drastically reducing
contention when a write to the procs file is in progress.
This patch series was written at the same time as Li Zefan's pid namespace
bugfix patch (from http://lkml.org/lkml/2009/7/1/559 ), and contains a similar
but finer-grained fix for the same bug. These patches can either be rewritten
to be applied on top of Li's patch, or be applied as they are with Li's patch
reversed.
---
Ben Blum (6):
Lets ss->can_attach and ss->attach do whole threadgroups at a time
Makes procs file writable to move all threads by tgid at once
Changes css_set freeing mechanism to be under RCU
Quick vmalloc vs kmalloc fix to the case where array size is too large
Ensures correct concurrent opening/reading of pidlists across pid namespaces
Adds a read-only "procs" file similar to "tasks" that shows only unique tgids
Documentation/cgroups/cgroups.txt | 12 -
include/linux/cgroup.h | 58 ++-
kernel/cgroup.c | 816 ++++++++++++++++++++++++++++++-------
kernel/cgroup_freezer.c | 15 +
kernel/cpuset.c | 65 ++-
kernel/fork.c | 2
kernel/ns_cgroup.c | 16 +
kernel/sched.c | 37 ++
mm/memcontrol.c | 3
security/device_cgroup.c | 3
10 files changed, 843 insertions(+), 184 deletions(-)
next reply other threads:[~2009-07-24 3:21 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-24 3:21 Ben Blum [this message]
2009-07-24 3:21 ` [PATCH 1/6] Adds a read-only "procs" file similar to "tasks" that shows only unique tgids Ben Blum
2009-07-24 3:21 ` [PATCH 2/6] Ensures correct concurrent opening/reading of pidlists across pid namespaces Ben Blum
2009-07-24 3:21 ` [PATCH 3/6] Quick vmalloc vs kmalloc fix to the case where array size is too large Ben Blum
2009-07-27 5:14 ` Li Zefan
2009-07-27 15:49 ` Benjamin Blum
2009-07-24 3:21 ` [PATCH 4/6] Changes css_set freeing mechanism to be under RCU Ben Blum
2009-07-24 3:22 ` [PATCH 5/6] Makes procs file writable to move all threads by tgid at once Ben Blum
2009-07-24 10:02 ` Louis Rilling
2009-07-24 10:08 ` Louis Rilling
2009-07-24 19:05 ` Benjamin Blum
2009-07-24 21:52 ` Benjamin Blum
2009-07-24 21:57 ` Paul Menage
2009-08-03 10:52 ` Louis Rilling
2009-07-29 0:23 ` Benjamin Blum
2009-08-03 11:00 ` Louis Rilling
2009-07-24 15:50 ` Matt Helsley
2009-07-24 16:01 ` Paul Menage
2009-07-24 17:23 ` Matt Helsley
2009-07-24 17:47 ` Paul Menage
2009-07-24 20:53 ` Benjamin Blum
2009-07-24 21:06 ` Matt Helsley
2009-07-24 21:36 ` Paul Menage
2009-11-09 17:07 ` Daniel Lezcano
2009-11-10 1:29 ` Li Zefan
2009-11-10 10:26 ` Daniel Lezcano
2009-11-11 2:07 ` Li Zefan
2009-11-11 20:06 ` Daniel Lezcano
2009-07-24 3:22 ` [PATCH 6/6] Lets ss->can_attach and ss->attach do whole threadgroups at a time Ben Blum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090724032033.2463.79256.stgit@hastromil.mtv.corp.google.com \
--to=bblum@google.com \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=menage@google.com \
--cc=serue@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®