From: Paul Menage <menage@google.com>
To: Matt Helsley <matthltc@us.ibm.com>
Cc: Benjamin Blum <bblum@google.com>,
linux-kernel@vger.kernel.org,
containers@lists.linux-foundation.org, akpm@linux-foundation.org,
serue@us.ibm.com, lizf@cn.fujitsu.com
Subject: Re: [PATCH 5/6] Makes procs file writable to move all threads by tgid at once
Date: Fri, 24 Jul 2009 14:36:18 -0700 [thread overview]
Message-ID: <6599ad830907241436n7c004e01j349a473554236f65@mail.gmail.com> (raw)
In-Reply-To: <20090724210657.GL5878@count0.beaverton.ibm.com>
On Fri, Jul 24, 2009 at 2:06 PM, Matt Helsley<matthltc@us.ibm.com> wrote:
>>
>> Global rwsem: only needs one lock, but prevents all forking when a
>> write is in progress. It should be quick enough, if it's just "iterate
>> down the threadgroup list in O(n)". In the good case, fork() slows
>> down by a cache miss when taking the lock in read mode.
>
> I noticed your point about only one process contending for write on
> the new semaphore since cgroup_mutex is also held on the write side.
> However won't there be cacheline bouncing as lots of readers contend not
> for the read side of the lock itself but the cacheline needed to take it?
Yes, that's the "cache miss when taking the lock in read mode"
referred to by Ben in the paragraph above yours.
Paul
next prev parent reply other threads:[~2009-07-24 21:36 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-24 3:21 [PATCH 0/6] CGroups: cgroup memberlist enhancement+fix Ben Blum
2009-07-24 3:21 ` [PATCH 1/6] Adds a read-only "procs" file similar to "tasks" that shows only unique tgids Ben Blum
2009-07-24 3:21 ` [PATCH 2/6] Ensures correct concurrent opening/reading of pidlists across pid namespaces Ben Blum
2009-07-24 3:21 ` [PATCH 3/6] Quick vmalloc vs kmalloc fix to the case where array size is too large Ben Blum
2009-07-27 5:14 ` Li Zefan
2009-07-27 15:49 ` Benjamin Blum
2009-07-24 3:21 ` [PATCH 4/6] Changes css_set freeing mechanism to be under RCU Ben Blum
2009-07-24 3:22 ` [PATCH 5/6] Makes procs file writable to move all threads by tgid at once Ben Blum
2009-07-24 10:02 ` Louis Rilling
2009-07-24 10:08 ` Louis Rilling
2009-07-24 19:05 ` Benjamin Blum
2009-07-24 21:52 ` Benjamin Blum
2009-07-24 21:57 ` Paul Menage
2009-08-03 10:52 ` Louis Rilling
2009-07-29 0:23 ` Benjamin Blum
2009-08-03 11:00 ` Louis Rilling
2009-07-24 15:50 ` Matt Helsley
2009-07-24 16:01 ` Paul Menage
2009-07-24 17:23 ` Matt Helsley
2009-07-24 17:47 ` Paul Menage
2009-07-24 20:53 ` Benjamin Blum
2009-07-24 21:06 ` Matt Helsley
2009-07-24 21:36 ` Paul Menage [this message]
2009-11-09 17:07 ` Daniel Lezcano
2009-11-10 1:29 ` Li Zefan
2009-11-10 10:26 ` Daniel Lezcano
2009-11-11 2:07 ` Li Zefan
2009-11-11 20:06 ` Daniel Lezcano
2009-07-24 3:22 ` [PATCH 6/6] Lets ss->can_attach and ss->attach do whole threadgroups at a time Ben Blum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6599ad830907241436n7c004e01j349a473554236f65@mail.gmail.com \
--to=menage@google.com \
--cc=akpm@linux-foundation.org \
--cc=bblum@google.com \
--cc=containers@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=matthltc@us.ibm.com \
--cc=serue@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®