mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ben Blum <bblum@google.com>
To: linux-kernel@vger.kernel.org,
	containers@lists.linux-foundation.org, akpm@linux-foundation.org,
	serue@us.ibm.com, lizf@cn.fujitsu.com, menage@google.com,
	bblum@google.com
Subject: [PATCH 4/6] Changes css_set freeing mechanism to be under RCU
Date: Thu, 23 Jul 2009 20:21:55 -0700	[thread overview]
Message-ID: <20090724032155.2463.80574.stgit@hastromil.mtv.corp.google.com> (raw)
In-Reply-To: <20090724032033.2463.79256.stgit@hastromil.mtv.corp.google.com>

Changes css_set freeing mechanism to be under RCU

This is a prepatch for making the procs file writable. In order to free the
old css_sets for each task to be moved as they're being moved, the freeing
mechanism must be RCU-protected, or else we would have to have a call to
synchronize_rcu() for each task before freeing its old css_set.

Signed-off-by: Ben Blum <bblum@google.com>

---

 include/linux/cgroup.h |    3 +++
 kernel/cgroup.c        |    8 +++++++-
 2 files changed, 10 insertions(+), 1 deletions(-)

diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h
index b934b72..24e3f1a 100644
--- a/include/linux/cgroup.h
+++ b/include/linux/cgroup.h
@@ -260,6 +260,9 @@ struct css_set {
 	 * during subsystem registration (at boot time).
 	 */
 	struct cgroup_subsys_state *subsys[CGROUP_SUBSYS_COUNT];
+
+	/* For RCU-protected deletion */
+	struct rcu_head rcu_head;
 };
 
 /*
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 7e6b183..637a54e 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -288,6 +288,12 @@ static void unlink_css_set(struct css_set *cg)
 	}
 }
 
+static void free_css_set_rcu(struct rcu_head *obj)
+{
+	struct css_set *cg = container_of(obj, struct css_set, rcu_head);
+	kfree(cg);
+}
+
 static void __put_css_set(struct css_set *cg, int taskexit)
 {
 	int i;
@@ -317,7 +323,7 @@ static void __put_css_set(struct css_set *cg, int taskexit)
 		}
 	}
 	rcu_read_unlock();
-	kfree(cg);
+	call_rcu(&cg->rcu_head, free_css_set_rcu);
 }
 
 /*


  parent reply	other threads:[~2009-07-24  3:22 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-24  3:21 [PATCH 0/6] CGroups: cgroup memberlist enhancement+fix Ben Blum
2009-07-24  3:21 ` [PATCH 1/6] Adds a read-only "procs" file similar to "tasks" that shows only unique tgids Ben Blum
2009-07-24  3:21 ` [PATCH 2/6] Ensures correct concurrent opening/reading of pidlists across pid namespaces Ben Blum
2009-07-24  3:21 ` [PATCH 3/6] Quick vmalloc vs kmalloc fix to the case where array size is too large Ben Blum
2009-07-27  5:14   ` Li Zefan
2009-07-27 15:49     ` Benjamin Blum
2009-07-24  3:21 ` Ben Blum [this message]
2009-07-24  3:22 ` [PATCH 5/6] Makes procs file writable to move all threads by tgid at once Ben Blum
2009-07-24 10:02   ` Louis Rilling
2009-07-24 10:08     ` Louis Rilling
2009-07-24 19:05       ` Benjamin Blum
2009-07-24 21:52     ` Benjamin Blum
2009-07-24 21:57       ` Paul Menage
2009-08-03 10:52         ` Louis Rilling
2009-07-29  0:23       ` Benjamin Blum
2009-08-03 11:00         ` Louis Rilling
2009-07-24 15:50   ` Matt Helsley
2009-07-24 16:01     ` Paul Menage
2009-07-24 17:23       ` Matt Helsley
2009-07-24 17:47         ` Paul Menage
2009-07-24 20:53           ` Benjamin Blum
2009-07-24 21:06             ` Matt Helsley
2009-07-24 21:36               ` Paul Menage
2009-11-09 17:07   ` Daniel Lezcano
2009-11-10  1:29     ` Li Zefan
2009-11-10 10:26       ` Daniel Lezcano
2009-11-11  2:07         ` Li Zefan
2009-11-11 20:06           ` Daniel Lezcano
2009-07-24  3:22 ` [PATCH 6/6] Lets ss->can_attach and ss->attach do whole threadgroups at a time Ben Blum
2009-07-31  1:51 [PATCH v2 0/6] CGroups: cgroup memberlist enhancement+fix Ben Blum
2009-07-31  1:51 ` [PATCH 4/6] Changes css_set freeing mechanism to be under RCU Ben Blum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090724032155.2463.80574.stgit@hastromil.mtv.corp.google.com \
    --to=bblum@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=containers@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=menage@google.com \
    --cc=serue@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®