mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Yinghai Lu <yhlu.kernel@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: add show_lapic=
Date: Mon, 28 Sep 2009 22:02:01 +0400	[thread overview]
Message-ID: <20090928180201.GH5264@lenovo> (raw)
In-Reply-To: <86802c440909281046o5fa0032do3497087d173cbf82@mail.gmail.com>

[Yinghai Lu - Mon, Sep 28, 2009 at 10:46:54AM -0700]
| On Mon, Sep 28, 2009 at 9:07 AM, Cyrill Gorcunov <gorcunov@gmail.com> wrote:
...
| >
| > -__apicdebuginit(int) print_all_ICs(void)
| > +static int __initdata show_lapic = 1;
| > +static __init int setup_show_lapic(char *arg)
| > +{
| > +       int num = -1;
| > +
| > +       if (strcmp(arg, "all") == 0) {
| > +               show_lapic = CONFIG_NR_CPUS;
| 
| NR_CPUS or nr_cpu_ids?

NR_CPUS as far as I can tell -- maximal to not exit for() loop until end.
nr_cpu_ids safe here as well, but constant is better :)

| 
| YH
| 
	-- Cyrill

  reply	other threads:[~2009-09-28 18:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-27  7:01 Yinghai Lu
2009-09-27  8:06 ` Cyrill Gorcunov
2009-09-27  8:29   ` Yinghai Lu
2009-09-27  8:54     ` Cyrill Gorcunov
2009-09-27 10:28       ` Cyrill Gorcunov
2009-09-27 14:40         ` Cyrill Gorcunov
2009-09-27 17:42           ` Cyrill Gorcunov
2009-09-28 16:07             ` Cyrill Gorcunov
2009-09-28 17:46               ` Yinghai Lu
2009-09-28 18:02                 ` Cyrill Gorcunov [this message]
2009-09-30 15:26                   ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090928180201.GH5264@lenovo \
    --to=gorcunov@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=yhlu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®