Re: [PATCH] x86: add show_lapic=

[Yinghai Lu <yinghai@kernel.org>]

Cyrill Gorcunov wrote:
> [Yinghai Lu - Sun, Sep 27, 2009 at 12:01:52AM -0700]
> | 
> | so could use that together with apci=debug to print less cpu apic.
> | 
> | otherwise for system have more cpus will take a while
> | 
> | also move apic_verbosity check to print_all_ICs
> | 
> | Signed-off-by: Yinghai Lu <yinghai@kernel.org>
> | 
> | ---
> |  arch/x86/kernel/apic/io_apic.c |   42 ++++++++++++++++++++++++++---------------
> |  1 file changed, 27 insertions(+), 15 deletions(-)
> ...
> 
> Hi Yinghai, good idea!
> 
> I've tuned your patch a bit together with changelog.
> 
> 1) show_lapic=1 by default does change current kernel behaviour
>    so it should be set to max cpu available.

think about system with lots of cpu. but i still want to use apic=debug

> 2) show_lapic contains the max number of lapics being printed
>    so we need to count them instead of plain comparation with
>    cpu number, as a result I've changed print_local_APICs. Or
>    you meant _exactly_ cpuid number? In meaning like
>    show_lapic=max_cpuid. Hmm?
> 
your change anything about that. there is not gap between cpu id.

YH