From: Alex Chiang <achiang@hp.com>
To: lenb@kernel.org
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/6] ACPI: dock: code hygiene
Date: Wed, 07 Oct 2009 16:07:27 -0600 [thread overview]
Message-ID: <20091007220509.15597.65501.stgit@bob.kio> (raw)
While poking around in the dock driver debugging the NULL ptr that
Rafael fixed, I found the driver a little hard to read.
Here is a modest attempt to clean it up a little, and is intended as
2.6.33 material.
Compile-tested only. I have access to an HP nc6220 and nc6230, but neither
of them seem to provide the _DCK method, which is needed for the dock
driver.
Thanks.
/ac
---
Alex Chiang (6):
ACPI: dock: clean up error handling paths in dock_add()
ACPI: dock: rename local variable 'dock_station' in dock_add()
ACPI: dock: clean up one more error path in dock_add()
ACPI: dock: add struct dock_station * directly to platform device data
ACPI: dock: combine add|alloc_dock_dependent_device
ACPI: dock: minor whitespace and style cleanups
drivers/acpi/dock.c | 259 ++++++++++++++++++++-------------------------------
1 files changed, 104 insertions(+), 155 deletions(-)
next reply other threads:[~2009-10-07 22:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-07 22:07 Alex Chiang [this message]
2009-10-07 22:07 ` [PATCH 1/6] ACPI: dock: clean up error handling paths in dock_add() Alex Chiang
2009-10-07 22:07 ` [PATCH 2/6] ACPI: dock: rename local variable 'dock_station' " Alex Chiang
2009-10-07 22:07 ` [PATCH 3/6] ACPI: dock: clean up one more error path " Alex Chiang
2009-10-07 22:07 ` [PATCH 4/6] ACPI: dock: add struct dock_station * directly to platform device data Alex Chiang
2009-10-10 7:52 ` Shaohua Li
2009-10-12 17:17 ` Alex Chiang
2009-10-07 22:07 ` [PATCH 5/6] ACPI: dock: combine add|alloc_dock_dependent_device Alex Chiang
2009-10-07 22:07 ` [PATCH 6/6] ACPI: dock: minor whitespace and style cleanups Alex Chiang
2009-10-09 20:55 ` [PATCH 0/6] ACPI: dock: code hygiene Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091007220509.15597.65501.stgit@bob.kio \
--to=achiang@hp.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®