mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alex Chiang <achiang@hp.com>
To: Shaohua Li <shaohua.li@intel.com>
Cc: "lenb@kernel.org" <lenb@kernel.org>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/6] ACPI: dock: add struct dock_station * directly to platform device data
Date: Mon, 12 Oct 2009 11:17:29 -0600	[thread overview]
Message-ID: <20091012171729.GB8636@ldl.fc.hp.com> (raw)
In-Reply-To: <20091010075230.GA7473@sli10-desk.sh.intel.com>

Hi Len,

* Shaohua Li <shaohua.li@intel.com>:
> 
> This patch isn't good. platform_device_add_data will malloc a new
> 'struct dock_station' and copy old to it, and later the two copy aren't
> consistent. So NACK this one.

If you can drop this patch without requiring a respin from me, go
ahead.

If you can't, go ahead and drop what you need, and I'll respin.

I'm going to chew on this a bit and see if I can still salvage
it.

> ACK other 5 patches.

Thanks, Shaohua.

/ac


  reply	other threads:[~2009-10-12 17:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-07 22:07 [PATCH 0/6] ACPI: dock: code hygiene Alex Chiang
2009-10-07 22:07 ` [PATCH 1/6] ACPI: dock: clean up error handling paths in dock_add() Alex Chiang
2009-10-07 22:07 ` [PATCH 2/6] ACPI: dock: rename local variable 'dock_station' " Alex Chiang
2009-10-07 22:07 ` [PATCH 3/6] ACPI: dock: clean up one more error path " Alex Chiang
2009-10-07 22:07 ` [PATCH 4/6] ACPI: dock: add struct dock_station * directly to platform device data Alex Chiang
2009-10-10  7:52   ` Shaohua Li
2009-10-12 17:17     ` Alex Chiang [this message]
2009-10-07 22:07 ` [PATCH 5/6] ACPI: dock: combine add|alloc_dock_dependent_device Alex Chiang
2009-10-07 22:07 ` [PATCH 6/6] ACPI: dock: minor whitespace and style cleanups Alex Chiang
2009-10-09 20:55 ` [PATCH 0/6] ACPI: dock: code hygiene Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091012171729.GB8636@ldl.fc.hp.com \
    --to=achiang@hp.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shaohua.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®