mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alex Chiang <achiang@hp.com>
To: lenb@kernel.org
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 3/6] ACPI: dock: clean up one more error path in dock_add()
Date: Wed, 07 Oct 2009 16:07:42 -0600	[thread overview]
Message-ID: <20091007220742.15597.91712.stgit@bob.kio> (raw)
In-Reply-To: <20091007220509.15597.65501.stgit@bob.kio>

Remove one final redundant error handling path and reduce repetitiveness.

Signed-off-by: Alex Chiang <achiang@hp.com>
---

 drivers/acpi/dock.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/acpi/dock.c b/drivers/acpi/dock.c
index 390adee..1d693a1 100644
--- a/drivers/acpi/dock.c
+++ b/drivers/acpi/dock.c
@@ -968,11 +968,10 @@ static int dock_add(acpi_handle handle)
 		platform_device_register_simple(dock_device_name,
 			dock_station_count, NULL, 0);
 	dock_device = ds->dock_device;
-	if (IS_ERR(dock_device)) {
-		kfree(ds);
-		ds = NULL;
-		return PTR_ERR(dock_device);
-	}
+	ret = IS_ERR(dock_device) ? PTR_ERR(dock_device) : 0;
+	if (ret)
+		goto err_free;
+
 	platform_device_add_data(dock_device, &ds,
 		sizeof(struct dock_station *));
 
@@ -1036,6 +1035,7 @@ err_unregister1:
 err_unregister:
 	printk(KERN_ERR "%s encountered error %d\n", __func__, ret);
 	platform_device_unregister(dock_device);
+err_free:
 	kfree(ds);
 	ds = NULL;
 	return ret;


  parent reply	other threads:[~2009-10-07 22:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-07 22:07 [PATCH 0/6] ACPI: dock: code hygiene Alex Chiang
2009-10-07 22:07 ` [PATCH 1/6] ACPI: dock: clean up error handling paths in dock_add() Alex Chiang
2009-10-07 22:07 ` [PATCH 2/6] ACPI: dock: rename local variable 'dock_station' " Alex Chiang
2009-10-07 22:07 ` Alex Chiang [this message]
2009-10-07 22:07 ` [PATCH 4/6] ACPI: dock: add struct dock_station * directly to platform device data Alex Chiang
2009-10-10  7:52   ` Shaohua Li
2009-10-12 17:17     ` Alex Chiang
2009-10-07 22:07 ` [PATCH 5/6] ACPI: dock: combine add|alloc_dock_dependent_device Alex Chiang
2009-10-07 22:07 ` [PATCH 6/6] ACPI: dock: minor whitespace and style cleanups Alex Chiang
2009-10-09 20:55 ` [PATCH 0/6] ACPI: dock: code hygiene Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091007220742.15597.91712.stgit@bob.kio \
    --to=achiang@hp.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®