mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: stefanr@s5r6.in-berlin.de
Cc: adi@hexapodia.org, julia@diku.dk, nm127@freemail.hu,
	david.vrabel@csr.com, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org, cocci@diku.dk
Subject: Re: Changelog quality
Date: Fri, 15 Jan 2010 00:54:45 -0800 (PST)	[thread overview]
Message-ID: <20100115.005445.263291449.davem@davemloft.net> (raw)
In-Reply-To: <4B502C6B.7000802@s5r6.in-berlin.de>

From: Stefan Richter <stefanr@s5r6.in-berlin.de>
Date: Fri, 15 Jan 2010 09:50:51 +0100

> David Miller wrote:
>> And likewise here, I want to see what the hell found the bug by
>> reading the changelog message.
> 
> Coccinelle found it.  In contrast to parsers like sparse, it had to be
> programmed to do so.  If you want to repeat that process, you have to
> get coccinelle and the script.  Both can be found quickly without having
> them both in the SCM.

I still don't see how this can argue for not putting the script into
the commit message.

And you overstate how "easily" the script can be found.

What button do I push in gitk when viewing a commit to find the
script?

If I have to go out of the tool, that's the beginning down the long
road of potential distractions.

  reply	other threads:[~2010-01-15  8:54 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-12  7:49 [PATCH] uwb: make USB device id constant Németh Márton
2010-01-12 16:10 ` David Vrabel
2010-01-12 16:57   ` Németh Márton
2010-01-13 14:59     ` Changelog quality (was Re: [PATCH] uwb: make USB device id constant) Stefan Richter
2010-01-13 15:38       ` Julia Lawall
2010-01-13 17:06         ` Changelog quality Stefan Richter
2010-01-13 17:29           ` Alan Stern
2010-01-13 17:44             ` Greg KH
2010-01-13 18:04               ` Alan Stern
2010-01-13 19:52                 ` Greg KH
2010-01-14  5:24                   ` Németh Márton
2010-01-14  6:05                     ` Julia Lawall
2010-01-14  8:07                       ` Stefan Richter
2010-01-14  8:26                     ` Dmitry Torokhov
2010-01-13 19:19               ` Geert Uytterhoeven
2010-01-13 17:49             ` Bartlomiej Zolnierkiewicz
2010-01-13 18:22               ` Stefan Richter
2010-01-15  1:03         ` Changelog quality (was Re: [PATCH] uwb: make USB device id constant) Andy Isaacson
2010-01-15  8:13           ` Stefan Richter
2010-01-15  8:24             ` Changelog quality David Miller
2010-01-15  8:50               ` Stefan Richter
2010-01-15  8:54                 ` David Miller [this message]
2010-01-15  9:17                   ` Stefan Richter
2010-01-15  9:22                     ` David Miller
2010-01-15  9:43                       ` Julia Lawall
2010-01-15  9:49                         ` Pekka Enberg
2010-01-15 10:05                           ` Julia Lawall
2010-01-15 11:08                             ` Mark Brown
2010-01-15 12:06                               ` Julia Lawall
2010-01-15 12:44                                 ` Pekka Enberg
2010-01-15 13:10                                   ` Julia Lawall
2010-01-15 12:45                                 ` Stefan Richter
2010-01-15 12:52                                   ` Pekka Enberg
2010-01-15 13:39                                 ` Mark Brown
2010-01-15 16:49                                   ` SmPL scripts into build environment? (was: Changelog quality) Németh Márton
2010-01-18 10:58                                     ` SmPL scripts into build environment? Michal Marek
2010-01-18 11:22                                       ` Julia Lawall
2010-01-15 13:28                       ` Changelog quality Stefan Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100115.005445.263291449.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=adi@hexapodia.org \
    --cc=cocci@diku.dk \
    --cc=david.vrabel@csr.com \
    --cc=julia@diku.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=nm127@freemail.hu \
    --cc=stefanr@s5r6.in-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome