From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Andy Isaacson <adi@hexapodia.org>
Cc: Julia Lawall <julia@diku.dk>, N??meth M??rton <nm127@freemail.hu>,
David Vrabel <david.vrabel@csr.com>,
linux-usb@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
cocci@diku.dk
Subject: Re: Changelog quality (was Re: [PATCH] uwb: make USB device id constant)
Date: Fri, 15 Jan 2010 09:13:26 +0100 [thread overview]
Message-ID: <4B5023A6.5070100@s5r6.in-berlin.de> (raw)
In-Reply-To: <20100115010315.GA29093@hexapodia.org>
Andy Isaacson wrote:
> For example, look at 5d66fe92. The semantic patch is blissfully,
> incredibly clear. It makes the sun shine down through the clouds, the
> birds sing, and the kzalloc align. It's 10 lines long and is quite
> intuitive and explanatory. In that case, I think it's clear that the
> spatch is worth the changelog space it takes up, even though the
> changelog is larger than the diff by quite a margin.
5d66fe92 is another example of what I was talking about. The changelog
could have read:
drivers/net : Correct the size argument to kzalloc
lp->rx_skb is for an array of pointers, not of structs.
Found using coccinelle.
Signed-off-by: ...
Tell me again in what way the script is of any importance or of any help
in the permanent SCM changelog after commit.
I agree with you that it is very good to have the script in the patch
posting, but I disagree about the changelog.
--
Stefan Richter
-=====-==-=- ---= -====
http://arcgraph.de/sr/
next prev parent reply other threads:[~2010-01-15 8:13 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-12 7:49 [PATCH] uwb: make USB device id constant Németh Márton
2010-01-12 16:10 ` David Vrabel
2010-01-12 16:57 ` Németh Márton
2010-01-13 14:59 ` Changelog quality (was Re: [PATCH] uwb: make USB device id constant) Stefan Richter
2010-01-13 15:38 ` Julia Lawall
2010-01-13 17:06 ` Changelog quality Stefan Richter
2010-01-13 17:29 ` Alan Stern
2010-01-13 17:44 ` Greg KH
2010-01-13 18:04 ` Alan Stern
2010-01-13 19:52 ` Greg KH
2010-01-14 5:24 ` Németh Márton
2010-01-14 6:05 ` Julia Lawall
2010-01-14 8:07 ` Stefan Richter
2010-01-14 8:26 ` Dmitry Torokhov
2010-01-13 19:19 ` Geert Uytterhoeven
2010-01-13 17:49 ` Bartlomiej Zolnierkiewicz
2010-01-13 18:22 ` Stefan Richter
2010-01-15 1:03 ` Changelog quality (was Re: [PATCH] uwb: make USB device id constant) Andy Isaacson
2010-01-15 8:13 ` Stefan Richter [this message]
2010-01-15 8:24 ` Changelog quality David Miller
2010-01-15 8:50 ` Stefan Richter
2010-01-15 8:54 ` David Miller
2010-01-15 9:17 ` Stefan Richter
2010-01-15 9:22 ` David Miller
2010-01-15 9:43 ` Julia Lawall
2010-01-15 9:49 ` Pekka Enberg
2010-01-15 10:05 ` Julia Lawall
2010-01-15 11:08 ` Mark Brown
2010-01-15 12:06 ` Julia Lawall
2010-01-15 12:44 ` Pekka Enberg
2010-01-15 13:10 ` Julia Lawall
2010-01-15 12:45 ` Stefan Richter
2010-01-15 12:52 ` Pekka Enberg
2010-01-15 13:39 ` Mark Brown
2010-01-15 16:49 ` SmPL scripts into build environment? (was: Changelog quality) Németh Márton
2010-01-18 10:58 ` SmPL scripts into build environment? Michal Marek
2010-01-18 11:22 ` Julia Lawall
2010-01-15 13:28 ` Changelog quality Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B5023A6.5070100@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=adi@hexapodia.org \
--cc=cocci@diku.dk \
--cc=david.vrabel@csr.com \
--cc=julia@diku.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nm127@freemail.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®