mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: David Miller <davem@davemloft.net>
Cc: adi@hexapodia.org, julia@diku.dk, nm127@freemail.hu,
	david.vrabel@csr.com, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org, cocci@diku.dk
Subject: Re: Changelog quality
Date: Fri, 15 Jan 2010 14:28:41 +0100	[thread overview]
Message-ID: <4B506D89.7000708@s5r6.in-berlin.de> (raw)
In-Reply-To: <20100115.012233.202457727.davem@davemloft.net>

David Miller wrote:
> From: Stefan Richter <stefanr@s5r6.in-berlin.de>
> Date: Fri, 15 Jan 2010 10:17:08 +0100 (CET)
> 
>> I on the other hold the opinion that the changelog has one purpose, to
>> describe the code change.
> 
> %99 of a bug fix is the process and means by which the bug was found,
> therefore the "how was it found" is at least as important as how it is
> fixed.

Well, granted.  The most important part of the changelog is perhaps the
"why", i.e. what problem is being fixed.  How this problem was found is
often worth to describe as well.  It may e.g. help to avoid future
occurrences or hint at further as yet unsolved issues.  But how detailed
to document it is of course subjective; we could argue all day what is
signal and what is noise.  (Which reminds me to stop being noisy and get
back to signal generation.)

> If the script in the commit bothers you, nobody forces you to read it
> or use it.
> 
> If you want more clear markers around the script so you can skim
> past it more efficiently when reading the commit message, then ask
> for that.

I won't ask for that.  The changelog format should not evolve into a
markup language.
-- 
Stefan Richter
-=====-==-=- ---= -====
http://arcgraph.de/sr/

      parent reply	other threads:[~2010-01-15 13:29 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-12  7:49 [PATCH] uwb: make USB device id constant Németh Márton
2010-01-12 16:10 ` David Vrabel
2010-01-12 16:57   ` Németh Márton
2010-01-13 14:59     ` Changelog quality (was Re: [PATCH] uwb: make USB device id constant) Stefan Richter
2010-01-13 15:38       ` Julia Lawall
2010-01-13 17:06         ` Changelog quality Stefan Richter
2010-01-13 17:29           ` Alan Stern
2010-01-13 17:44             ` Greg KH
2010-01-13 18:04               ` Alan Stern
2010-01-13 19:52                 ` Greg KH
2010-01-14  5:24                   ` Németh Márton
2010-01-14  6:05                     ` Julia Lawall
2010-01-14  8:07                       ` Stefan Richter
2010-01-14  8:26                     ` Dmitry Torokhov
2010-01-13 19:19               ` Geert Uytterhoeven
2010-01-13 17:49             ` Bartlomiej Zolnierkiewicz
2010-01-13 18:22               ` Stefan Richter
2010-01-15  1:03         ` Changelog quality (was Re: [PATCH] uwb: make USB device id constant) Andy Isaacson
2010-01-15  8:13           ` Stefan Richter
2010-01-15  8:24             ` Changelog quality David Miller
2010-01-15  8:50               ` Stefan Richter
2010-01-15  8:54                 ` David Miller
2010-01-15  9:17                   ` Stefan Richter
2010-01-15  9:22                     ` David Miller
2010-01-15  9:43                       ` Julia Lawall
2010-01-15  9:49                         ` Pekka Enberg
2010-01-15 10:05                           ` Julia Lawall
2010-01-15 11:08                             ` Mark Brown
2010-01-15 12:06                               ` Julia Lawall
2010-01-15 12:44                                 ` Pekka Enberg
2010-01-15 13:10                                   ` Julia Lawall
2010-01-15 12:45                                 ` Stefan Richter
2010-01-15 12:52                                   ` Pekka Enberg
2010-01-15 13:39                                 ` Mark Brown
2010-01-15 16:49                                   ` SmPL scripts into build environment? (was: Changelog quality) Németh Márton
2010-01-18 10:58                                     ` SmPL scripts into build environment? Michal Marek
2010-01-18 11:22                                       ` Julia Lawall
2010-01-15 13:28                       ` Stefan Richter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B506D89.7000708@s5r6.in-berlin.de \
    --to=stefanr@s5r6.in-berlin.de \
    --cc=adi@hexapodia.org \
    --cc=cocci@diku.dk \
    --cc=davem@davemloft.net \
    --cc=david.vrabel@csr.com \
    --cc=julia@diku.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=nm127@freemail.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®