From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Julia Lawall <julia@diku.dk>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
David Miller <davem@davemloft.net>,
stefanr@s5r6.in-berlin.de, adi@hexapodia.org, nm127@freemail.hu,
david.vrabel@csr.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, cocci@diku.dk,
Andrew Morton <akpm@linux-foundation.org>,
Nicolas Palix <npalix@diku.dk>
Subject: Re: Changelog quality
Date: Fri, 15 Jan 2010 14:44:06 +0200 [thread overview]
Message-ID: <84144f021001150444j4f7f9dexe8486d06b7e45205@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1001151303580.23543@ask.diku.dk>
Hi Julia,
On Fri, Jan 15, 2010 at 2:06 PM, Julia Lawall <julia@diku.dk> wrote:
> On the other hand, one has to take into account the fact that at least in
> my case, the patches that are submitted are the ones that I have carefully
> checked for correctness. Having a make target in the kernel might give
> some suggestion of quality that is perhaps not appropriate?
I don't see the problem. No tool is perfect so the only thing that
matters is whether or not the benefits outweigh the costs. The problem
I see with Coccinelle is that the scripts seem to be lost in a black
hole (even if they are part of the changelog) which also means that
your efforts don't scale.
There seems to be a universal law regarding kernel development: if
something is out-of-tree, it simply doesn't matter from "people
scalability" point of view. It doesn't really matter if you like it or
not but that's the way things are right now. I, for one, would love to
run Coccinelle on the tree I maintain but unfortunately the tool fails
my "can I set it up in two minutes" rule so I haven't gotten around to
give it a try. And I suspect I am not the only one.
So why not try it out? If the signal to noise ratio is too low and we
can't fix that, we can always just remove the damn thing from the
tree. Speculating whether or not something will work seems pretty
pointless to me when you don't have any hard data.
Pekka
next prev parent reply other threads:[~2010-01-15 12:44 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-12 7:49 [PATCH] uwb: make USB device id constant Németh Márton
2010-01-12 16:10 ` David Vrabel
2010-01-12 16:57 ` Németh Márton
2010-01-13 14:59 ` Changelog quality (was Re: [PATCH] uwb: make USB device id constant) Stefan Richter
2010-01-13 15:38 ` Julia Lawall
2010-01-13 17:06 ` Changelog quality Stefan Richter
2010-01-13 17:29 ` Alan Stern
2010-01-13 17:44 ` Greg KH
2010-01-13 18:04 ` Alan Stern
2010-01-13 19:52 ` Greg KH
2010-01-14 5:24 ` Németh Márton
2010-01-14 6:05 ` Julia Lawall
2010-01-14 8:07 ` Stefan Richter
2010-01-14 8:26 ` Dmitry Torokhov
2010-01-13 19:19 ` Geert Uytterhoeven
2010-01-13 17:49 ` Bartlomiej Zolnierkiewicz
2010-01-13 18:22 ` Stefan Richter
2010-01-15 1:03 ` Changelog quality (was Re: [PATCH] uwb: make USB device id constant) Andy Isaacson
2010-01-15 8:13 ` Stefan Richter
2010-01-15 8:24 ` Changelog quality David Miller
2010-01-15 8:50 ` Stefan Richter
2010-01-15 8:54 ` David Miller
2010-01-15 9:17 ` Stefan Richter
2010-01-15 9:22 ` David Miller
2010-01-15 9:43 ` Julia Lawall
2010-01-15 9:49 ` Pekka Enberg
2010-01-15 10:05 ` Julia Lawall
2010-01-15 11:08 ` Mark Brown
2010-01-15 12:06 ` Julia Lawall
2010-01-15 12:44 ` Pekka Enberg [this message]
2010-01-15 13:10 ` Julia Lawall
2010-01-15 12:45 ` Stefan Richter
2010-01-15 12:52 ` Pekka Enberg
2010-01-15 13:39 ` Mark Brown
2010-01-15 16:49 ` SmPL scripts into build environment? (was: Changelog quality) Németh Márton
2010-01-18 10:58 ` SmPL scripts into build environment? Michal Marek
2010-01-18 11:22 ` Julia Lawall
2010-01-15 13:28 ` Changelog quality Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f021001150444j4f7f9dexe8486d06b7e45205@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=adi@hexapodia.org \
--cc=akpm@linux-foundation.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=cocci@diku.dk \
--cc=davem@davemloft.net \
--cc=david.vrabel@csr.com \
--cc=julia@diku.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nm127@freemail.hu \
--cc=npalix@diku.dk \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®