mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vasiliy Kulikov <segoon@openwall.com>
To: Greg KH <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org, "Rafael J. Wysocki" <rjw@sisk.pl>,
	Len Brown <len.brown@intel.com>,
	security@kernel.org, linux-pm@lists.linux-foundation.org,
	Pavel Machek <pavel@ucw.cz>
Subject: Re: [Security] [PATCH] power: disable hibernation if module loading is disabled
Date: Sat, 5 Mar 2011 00:51:20 +0300	[thread overview]
Message-ID: <20110304215118.GA30253@albatros> (raw)
In-Reply-To: <20110304212709.GA28680@kroah.com>

On Fri, Mar 04, 2011 at 13:27 -0800, Greg KH wrote:
> On Fri, Mar 04, 2011 at 07:11:24PM +0300, Vasiliy Kulikov wrote:
> > If /proc/sys/kernel/modules_disabled is set to 1, then nobody (even full
> > root) may not read/write arbitrary kernel memory.  In spite of it,
> > hibernation allows anyone with an access to either /dev/snapshot or
> > /sys/power/ make the full snapshot of the system.  This snapshot may be
> > freely changed and uploaded back.
> 
> This sounds like a very unintentional change to the "don't load any
> modules" option, right?  If so, you should really document this
> somewhere, otherwise people are going to get very confused when their
> system suspends suddenly stop working for no obvious reason.

Agreed, thank you.  Is Documentation/sysctl/kernel.txt an appropriate
place?

-- 
Vasiliy Kulikov
http://www.openwall.com - bringing security into open computing environments

  reply	other threads:[~2011-03-04 21:51 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-04 16:11 Vasiliy Kulikov
2011-03-04 18:43 ` Kees Cook
2011-03-04 20:48   ` Rafael J. Wysocki
2011-03-04 20:32 ` Pavel Machek
2011-03-04 21:52   ` Vasiliy Kulikov
2011-03-04 20:42 ` Rafael J. Wysocki
2011-03-04 21:10   ` Vasiliy Kulikov
2011-03-04 21:21     ` Rafael J. Wysocki
2011-03-04 21:46       ` Vasiliy Kulikov
2011-03-04 22:30         ` Rafael J. Wysocki
2011-03-04 22:42           ` Pavel Machek
2011-03-05 10:34           ` Vasiliy Kulikov
2011-03-05 11:24             ` Rafael J. Wysocki
2011-03-08  6:58               ` Pavel Machek
2011-03-04 21:27 ` [Security] " Greg KH
2011-03-04 21:51   ` Vasiliy Kulikov [this message]
2011-03-06 19:36 ` david

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110304215118.GA30253@albatros \
    --to=segoon@openwall.com \
    --cc=greg@kroah.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=pavel@ucw.cz \
    --cc=rjw@sisk.pl \
    --cc=security@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®