mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Vasiliy Kulikov <segoon@openwall.com>,
	linux-kernel@vger.kernel.org, security@kernel.org,
	Len Brown <len.brown@intel.com>,
	linux-pm@lists.linux-foundation.org
Subject: Re: [PATCH] power: disable hibernation if module loading is disabled
Date: Tue, 8 Mar 2011 07:58:45 +0100	[thread overview]
Message-ID: <20110308065845.GB1357@ucw.cz> (raw)
In-Reply-To: <201103051224.18621.rjw@sisk.pl>

Hi!


> > > modules_disabled surely is not the right interface to disable hibernation
> > > and I don't really think there's a bug because it doesn't work as you'd like
> > > it to.  In fact, there would be a bug if it did work that way.
> > 
> > What do you mean here?  Do you agree that you may read kernel image,
> > slightly change it (including e.g. possible checksums, I didn't bother
> > to check how much one should change), and write it back?
> 
> Yes, you can, but that's not the point.  The point is that calling an interface
> that disables all possible functionality modifying kernel memory
> "modules_disabled" is completely dumb.  Sorry, but that's how it goes.

Fully agreed.

If you want a subset of cap_sys_admin than can't install
rootkit... just do it like that. Create cap_small_admin with such
subset and migrate people that don't need full admin to it.

								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  reply	other threads:[~2011-03-08  6:59 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-04 16:11 Vasiliy Kulikov
2011-03-04 18:43 ` Kees Cook
2011-03-04 20:48   ` Rafael J. Wysocki
2011-03-04 20:32 ` Pavel Machek
2011-03-04 21:52   ` Vasiliy Kulikov
2011-03-04 20:42 ` Rafael J. Wysocki
2011-03-04 21:10   ` Vasiliy Kulikov
2011-03-04 21:21     ` Rafael J. Wysocki
2011-03-04 21:46       ` Vasiliy Kulikov
2011-03-04 22:30         ` Rafael J. Wysocki
2011-03-04 22:42           ` Pavel Machek
2011-03-05 10:34           ` Vasiliy Kulikov
2011-03-05 11:24             ` Rafael J. Wysocki
2011-03-08  6:58               ` Pavel Machek [this message]
2011-03-04 21:27 ` [Security] " Greg KH
2011-03-04 21:51   ` Vasiliy Kulikov
2011-03-06 19:36 ` david

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110308065845.GB1357@ucw.cz \
    --to=pavel@ucw.cz \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=rjw@sisk.pl \
    --cc=security@kernel.org \
    --cc=segoon@openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®