mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Yuan-Hsin Chen <yuanlmm@gmail.com>
Cc: jgarzik@pobox.com, linux-ide@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Yuan-Hsin Chen <yhchen@faraday-tech.com>
Subject: Re: [PATCH] ahci: enable pmp but connected to HDD issue fixed
Date: Tue, 14 Jun 2011 08:52:13 +0200	[thread overview]
Message-ID: <20110614065213.GD8141@htj.dyndns.org> (raw)
In-Reply-To: <1308030504-3026-1-git-send-email-yuanlmm@gmail.com>

On Tue, Jun 14, 2011 at 01:48:24PM +0800, Yuan-Hsin Chen wrote:
> From: Yuan-Hsin Chen <yhchen@faraday-tech.com>
> 
> When enabling both port multiplier and platform ahci sata, ahci
> times out while connecting to HDD directly. This is because soft
> reset fails with IPMS set. Do soft reset again to port 0.
> 
> The soft reset sequence is copied from ahci.c.

This is the same one as ahci_sb600_softreset(), right?  Please don't
copy & paste like that.  Rename and ahci_sb600_softreset() to
libahci.c, create a separate ata_port_operations for it and use the
ops for the affected controllers.

Thanks.

-- 
tejun

  reply	other threads:[~2011-06-14  6:52 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-14  5:48 Yuan-Hsin Chen
2011-06-14  6:52 ` Tejun Heo [this message]
2011-06-15 10:04   ` [PATCH v2] ahci: fix pmp softreset with HDD Yuan-Hsin Chen
2011-06-15 10:14     ` Tejun Heo
2011-06-17 10:39       ` [PATCH v3] ahci: move ahci_sb600_softreset to libahci.c and rename it Yuan-Hsin Chen
2011-06-17 11:34         ` Sergei Shtylyov
2011-06-17 12:07         ` Tejun Heo
2011-06-20  8:06           ` [PATCH v4] " Yuan-Hsin Chen
2011-06-20  8:15             ` Sergei Shtylyov
2011-06-20  8:47               ` Yuan-Hsin Chen
2011-06-20  8:19             ` Tejun Heo
2011-06-20 10:06               ` Yuan-Hsin Chen
2011-06-20 12:47                 ` Tejun Heo
2011-06-21  3:24               ` Yuan-Hsin Chen
2011-06-21  7:17                 ` Tejun Heo
2011-06-21  9:17                   ` [PATCH v5] " Yuan-Hsin Chen
2011-06-21  9:53                     ` Tejun Heo
     [not found] ` <BANLkTimiJheFauWXjh-8GszGHoqMOa0Kkw@mail.gmail.com>
2011-06-15  2:50   ` Fwd: [PATCH] ahci: enable pmp but connected to HDD issue fixed BingJiun Luo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110614065213.GD8141@htj.dyndns.org \
    --to=tj@kernel.org \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yhchen@faraday-tech.com \
    --cc=yuanlmm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®