mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Jan Beulich <JBeulich@novell.com>
Subject: Re: [RFC GIT PULL] x86 entry / perf stacktrace changes
Date: Mon, 4 Jul 2011 11:13:45 +0200	[thread overview]
Message-ID: <20110704091345.GB22943@elte.hu> (raw)
In-Reply-To: <1309624184-9790-1-git-send-email-fweisbec@gmail.com>


* Frederic Weisbecker <fweisbec@gmail.com> wrote:

> Ingo,
> 
> Please pull the perf/stacktrace branch that can be found at:
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing.git
> 	perf/stacktrace
> 
> Or may be not yet. It's still in RFC because I would like
> to ensure I did not break cfi annotations. I hope Jan beulich
> or others can have a look.
> 
> Sorry to mess up irq entry and perf stacktrace changes in the same
> topic. But the changes happen to be very interconnected.
> 
> Several cleanups, fixes and optimizations for the x86-64
> stacktraces and irq entry.
> 
> Last patch seems to add a bit of overhead in the irq entry
> (one more "push") but given the changes made in previous
> patches, the end result is a more optimized and more clear irq
> entry.
> 
> Thanks,
> 	Frederic
> ---
> 
> Frederic Weisbecker (6):
>       x86: Save stack pointer in perf live regs savings
>       x86: Fetch stack from regs when possible in dump_trace()
>       x86,64: Simplify save_regs()
>       x86,64: Separate arg1 from rbp handling in SAVE_REGS_IRQ
>       x86: Remove useless unwinder backlink from irq regs saving
>       x86: Don't use frame pointer to save old stack on irq entry
> 
> 
>  arch/x86/include/asm/perf_event.h |    5 +++
>  arch/x86/kernel/dumpstack_64.c    |   37 +++-----------------
>  arch/x86/kernel/entry_64.S        |   69 ++++++++++++++++--------------------
>  3 files changed, 41 insertions(+), 70 deletions(-)

Pulled, thanks a lot Frederic! The irq backtrace fixes look pretty 
important - if there's any CFI annotation detail to be fixed we can 
do it in a delta.

Thanks,

	Ingo

      parent reply	other threads:[~2011-07-04  9:14 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-02 16:29 Frederic Weisbecker
2011-07-02 16:29 ` [PATCH 1/6] x86: Save stack pointer in perf live regs savings Frederic Weisbecker
2011-07-02 16:29 ` [PATCH 2/6] x86: Fetch stack from regs when possible in dump_trace() Frederic Weisbecker
2011-07-02 16:29 ` [PATCH 3/6] x86,64: Simplify save_regs() Frederic Weisbecker
2011-07-04  7:20   ` Jan Beulich
2011-07-04 12:57     ` Frederic Weisbecker
2011-07-06 17:34       ` Andi Kleen
2011-07-06 18:20         ` H. Peter Anvin
2011-07-06 20:42           ` Frederic Weisbecker
2011-07-04 12:59     ` Frederic Weisbecker
2011-07-02 16:29 ` [PATCH 4/6] x86,64: Separate arg1 from rbp handling in SAVE_REGS_IRQ Frederic Weisbecker
2011-07-04  7:34   ` Jan Beulich
2011-07-02 16:29 ` [PATCH 5/6] x86: Remove useless unwinder backlink from irq regs saving Frederic Weisbecker
2011-07-04  7:29   ` Jan Beulich
2011-07-04  9:17     ` Ingo Molnar
2011-07-04 13:10       ` Frederic Weisbecker
2011-07-04 13:22     ` Frederic Weisbecker
2011-07-05 22:21       ` Valdis.Kletnieks
2011-07-02 16:29 ` [PATCH 6/6] x86: Don't use frame pointer to save old stack on irq entry Frederic Weisbecker
2011-07-04  9:13 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110704091345.GB22943@elte.hu \
    --to=mingo@elte.hu \
    --cc=JBeulich@novell.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®