mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@novell.com>
To: "Frederic Weisbecker" <fweisbec@gmail.com>
Cc: "Peter Zijlstra" <a.p.zijlstra@chello.nl>,
	"Ingo Molnar" <mingo@elte.hu>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Arnaldo Carvalho de Melo" <acme@redhat.com>,
	"LKML" <linux-kernel@vger.kernel.org>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 4/6] x86,64: Separate arg1 from rbp handling in SAVE_REGS_IRQ
Date: Mon, 04 Jul 2011 08:34:05 +0100	[thread overview]
Message-ID: <4E11890D020000780004BF40@nat28.tlf.novell.com> (raw)
In-Reply-To: <1309624184-9790-5-git-send-email-fweisbec@gmail.com>

>>> On 02.07.11 at 18:29, Frederic Weisbecker <fweisbec@gmail.com> wrote:
> Just for clarity in the code. Have a first block that handles
> the frame pointer and a separate one that handles pt_regs
> pointer and its use.

While possible indeed making the code easier to read, it increases the
chance of a latency related stall (due to the write to %rdi immediately
preceding its use as a memory operand's address).

Jan

> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Ingo Molnar <mingo@elte.hu>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: H. Peter Anvin <hpa@zytor.com>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> Cc: Jan Beulich <JBeulich@novell.com>
> ---
>  arch/x86/kernel/entry_64.S |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/kernel/entry_64.S b/arch/x86/kernel/entry_64.S
> index b6b2e85..20dc8e6 100644
> --- a/arch/x86/kernel/entry_64.S
> +++ b/arch/x86/kernel/entry_64.S
> @@ -310,9 +310,10 @@ ENDPROC(native_usergs_sysret64)
>  	movq_cfi r10, R10-RBP
>  	movq_cfi r11, R11-RBP
>  
> -	leaq -RBP(%rsp),%rdi	/* arg1 for handler */
>  	movq_cfi rbp, 0		/* push %rbp */
>  	movq %rsp, %rbp
> +
> +	leaq -RBP(%rsp),%rdi	/* arg1 for handler */
>  	testl $3, CS(%rdi)
>  	je 1f
>  	SWAPGS





  reply	other threads:[~2011-07-04  7:34 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-02 16:29 [RFC GIT PULL] x86 entry / perf stacktrace changes Frederic Weisbecker
2011-07-02 16:29 ` [PATCH 1/6] x86: Save stack pointer in perf live regs savings Frederic Weisbecker
2011-07-02 16:29 ` [PATCH 2/6] x86: Fetch stack from regs when possible in dump_trace() Frederic Weisbecker
2011-07-02 16:29 ` [PATCH 3/6] x86,64: Simplify save_regs() Frederic Weisbecker
2011-07-04  7:20   ` Jan Beulich
2011-07-04 12:57     ` Frederic Weisbecker
2011-07-06 17:34       ` Andi Kleen
2011-07-06 18:20         ` H. Peter Anvin
2011-07-06 20:42           ` Frederic Weisbecker
2011-07-04 12:59     ` Frederic Weisbecker
2011-07-02 16:29 ` [PATCH 4/6] x86,64: Separate arg1 from rbp handling in SAVE_REGS_IRQ Frederic Weisbecker
2011-07-04  7:34   ` Jan Beulich [this message]
2011-07-02 16:29 ` [PATCH 5/6] x86: Remove useless unwinder backlink from irq regs saving Frederic Weisbecker
2011-07-04  7:29   ` Jan Beulich
2011-07-04  9:17     ` Ingo Molnar
2011-07-04 13:10       ` Frederic Weisbecker
2011-07-04 13:22     ` Frederic Weisbecker
2011-07-05 22:21       ` Valdis.Kletnieks
2011-07-02 16:29 ` [PATCH 6/6] x86: Don't use frame pointer to save old stack on irq entry Frederic Weisbecker
2011-07-04  9:13 ` [RFC GIT PULL] x86 entry / perf stacktrace changes Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E11890D020000780004BF40@nat28.tlf.novell.com \
    --to=jbeulich@novell.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®