From: Valdis.Kletnieks@vt.edu
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jan Beulich <JBeulich@novell.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 5/6] x86: Remove useless unwinder backlink from irq regs saving
Date: Tue, 05 Jul 2011 18:21:28 -0400 [thread overview]
Message-ID: <61768.1309904488@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Mon, 04 Jul 2011 15:22:23 +0200." <20110704132158.GA5551@somewhere>
[-- Attachment #1: Type: text/plain, Size: 946 bytes --]
On Mon, 04 Jul 2011 15:22:23 +0200, Frederic Weisbecker said:
> On Mon, Jul 04, 2011 at 08:29:08AM +0100, Jan Beulich wrote:
> > >>> On 02.07.11 at 18:29, Frederic Weisbecker <fweisbec@gmail.com> wrote:
> > > The unwinder backlink in interrupt entry is very useless.
> > > It's actually not part of the stack frame chain and thus is
> > > never used.
> >
> > I very much doubt this - see dump_trace()'s comment in its IRQ-stack
> > related code portion (and the corresponding use of irq_stack_end[-1]).
> >
> > Jan
>
> Good point. I misunderstood that.
>
> But then I believe I accidentally fixed it back in
> "x86: Don't use frame pointer to save old stack on irq entry" by
> pushing %rsi instead in the new stack. It contains the backlink to
> the old stack.
>
> If we keep the macro as-is, I'll add a comment to explain further
> what is involved there.
Ahh.. I was wondering why there wasn't suddenly a very lonely popq
out there... :)
[-- Attachment #2: Type: application/pgp-signature, Size: 227 bytes --]
next prev parent reply other threads:[~2011-07-05 22:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-02 16:29 [RFC GIT PULL] x86 entry / perf stacktrace changes Frederic Weisbecker
2011-07-02 16:29 ` [PATCH 1/6] x86: Save stack pointer in perf live regs savings Frederic Weisbecker
2011-07-02 16:29 ` [PATCH 2/6] x86: Fetch stack from regs when possible in dump_trace() Frederic Weisbecker
2011-07-02 16:29 ` [PATCH 3/6] x86,64: Simplify save_regs() Frederic Weisbecker
2011-07-04 7:20 ` Jan Beulich
2011-07-04 12:57 ` Frederic Weisbecker
2011-07-06 17:34 ` Andi Kleen
2011-07-06 18:20 ` H. Peter Anvin
2011-07-06 20:42 ` Frederic Weisbecker
2011-07-04 12:59 ` Frederic Weisbecker
2011-07-02 16:29 ` [PATCH 4/6] x86,64: Separate arg1 from rbp handling in SAVE_REGS_IRQ Frederic Weisbecker
2011-07-04 7:34 ` Jan Beulich
2011-07-02 16:29 ` [PATCH 5/6] x86: Remove useless unwinder backlink from irq regs saving Frederic Weisbecker
2011-07-04 7:29 ` Jan Beulich
2011-07-04 9:17 ` Ingo Molnar
2011-07-04 13:10 ` Frederic Weisbecker
2011-07-04 13:22 ` Frederic Weisbecker
2011-07-05 22:21 ` Valdis.Kletnieks [this message]
2011-07-02 16:29 ` [PATCH 6/6] x86: Don't use frame pointer to save old stack on irq entry Frederic Weisbecker
2011-07-04 9:13 ` [RFC GIT PULL] x86 entry / perf stacktrace changes Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61768.1309904488@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=JBeulich@novell.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®