ARCH_PXA_ADX

ARCH_PXA_ADX

[Paul Bolle]

0) Since v2.6.32 the mainline tree supports the "Avionic Design Xanthos
Backlight Driver" (BACKLIGHT_ADX) and the "Avionic Design Xanthos
watchdog" driver (ADX_WATCHDOG). These were added in commit 3b96ea9ef8
("[...] Add support for the Avionic Design Xanthos backlight device.")
and 38461c5c08 ("[...] Add support for the Avionic Design Xanthos
watchdog timer.").

1) Both drivers' Kconfig symbols depend on the Kconfig symbol
ARCH_PXA_ADX. At that time this symbol didn't exist. It still doesn't. I
haven't been able to find anything remotely related (ie, I even did
things like "git grep -i PXA | grep -i ADX").

2) So it seems these two drivers could never have been built from the
mainline tree. (I'm starting to think that the config tools should
somehow check stuff like this.)

3) Is the above correct? If it is, why shouldn't I submit the trivial
patch to remove both these drivers?


Paul Bolle

Re: ARCH_PXA_ADX

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 1135 bytes --]

* Paul Bolle wrote:
> 0) Since v2.6.32 the mainline tree supports the "Avionic Design Xanthos
> Backlight Driver" (BACKLIGHT_ADX) and the "Avionic Design Xanthos
> watchdog" driver (ADX_WATCHDOG). These were added in commit 3b96ea9ef8
> ("[...] Add support for the Avionic Design Xanthos backlight device.")
> and 38461c5c08 ("[...] Add support for the Avionic Design Xanthos
> watchdog timer.").
> 
> 1) Both drivers' Kconfig symbols depend on the Kconfig symbol
> ARCH_PXA_ADX. At that time this symbol didn't exist. It still doesn't. I
> haven't been able to find anything remotely related (ie, I even did
> things like "git grep -i PXA | grep -i ADX").
> 
> 2) So it seems these two drivers could never have been built from the
> mainline tree. (I'm starting to think that the config tools should
> somehow check stuff like this.)
> 
> 3) Is the above correct? If it is, why shouldn't I submit the trivial
> patch to remove both these drivers?

Yes, all of that is correct. Unfortunately, I never got around to mainlining
the rest of the code. Feel free to remove both drivers and add my Acked-by.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: ARCH_PXA_ADX

[Wim Van Sebroeck]

Hi All,

> > 2) So it seems these two drivers could never have been built from the
> > mainline tree. (I'm starting to think that the config tools should
> > somehow check stuff like this.)
> > 
> > 3) Is the above correct? If it is, why shouldn't I submit the trivial
> > patch to remove both these drivers?
> 
> Yes, all of that is correct. Unfortunately, I never got around to mainlining
> the rest of the code. Feel free to remove both drivers and add my Acked-by.

I will remove the watchdog driver out of my trees and sent it to Linus.

Kind regards,
Wim.

Re: ARCH_PXA_ADX

[Paul Bolle]

On Tue, 2011-11-15 at 11:28 +0100, Wim Van Sebroeck wrote:
> On Tue, 2011-11-15 at 11:18 +0100, Thierry Reding wrote:
> > [...] Feel free to remove both drivers and add my Acked-by.

I see. Thanks.

> I will remove the watchdog driver out of my trees and sent it to Linus.

Great.

I hope to submit the trivial patch to drop the backlight driver in the
near future. But if someone else does that before I do, that's fine with
me too.


Paul Bolle