[PATCH] dma: imx-sdma: Treat firmware messages as warnings instead of erros

[PATCH] dma: imx-sdma: Treat firmware messages as warnings instead of erros

[Fabio Estevam]

As the SDMA controller can operate without an external firmware being loaded,
treat the firmware related messages as warnings rather than errors.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 drivers/dma/imx-sdma.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
index c495882..3b7ebd4 100644
--- a/drivers/dma/imx-sdma.c
+++ b/drivers/dma/imx-sdma.c
@@ -1389,7 +1389,7 @@ static int __init sdma_probe(struct platform_device *pdev)
 	if (pdata) {
 		ret = sdma_get_firmware(sdma, pdata->fw_name);
 		if (ret)
-			dev_err(&pdev->dev, "failed to get firmware from platform data\n");
+			dev_warn(&pdev->dev, "failed to get firmware from platform data\n");
 	} else {
 		/*
 		 * Because that device tree does not encode ROM script address,
@@ -1399,11 +1399,11 @@ static int __init sdma_probe(struct platform_device *pdev)
 		ret = of_property_read_string(np, "fsl,sdma-ram-script-name",
 					      &fw_name);
 		if (ret)
-			dev_err(&pdev->dev, "failed to get firmware name\n");
+			dev_warn(&pdev->dev, "failed to get firmware name\n");
 		else {
 			ret = sdma_get_firmware(sdma, fw_name);
 			if (ret)
-				dev_err(&pdev->dev, "failed to get firmware from device tree\n");
+				dev_warn(&pdev->dev, "failed to get firmware from device tree\n");
 		}
 	}
 
-- 
1.7.1

Re: [PATCH] dma: imx-sdma: Treat firmware messages as warnings instead of erros

[Sascha Hauer]

On Thu, Mar 08, 2012 at 09:26:39AM -0300, Fabio Estevam wrote:
> As the SDMA controller can operate without an external firmware being loaded,
> treat the firmware related messages as warnings rather than errors.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Acked-by: Sascha Hauer <s.hauer@pengutronix.de>

Sascha

> ---
>  drivers/dma/imx-sdma.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index c495882..3b7ebd4 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -1389,7 +1389,7 @@ static int __init sdma_probe(struct platform_device *pdev)
>  	if (pdata) {
>  		ret = sdma_get_firmware(sdma, pdata->fw_name);
>  		if (ret)
> -			dev_err(&pdev->dev, "failed to get firmware from platform data\n");
> +			dev_warn(&pdev->dev, "failed to get firmware from platform data\n");
>  	} else {
>  		/*
>  		 * Because that device tree does not encode ROM script address,
> @@ -1399,11 +1399,11 @@ static int __init sdma_probe(struct platform_device *pdev)
>  		ret = of_property_read_string(np, "fsl,sdma-ram-script-name",
>  					      &fw_name);
>  		if (ret)
> -			dev_err(&pdev->dev, "failed to get firmware name\n");
> +			dev_warn(&pdev->dev, "failed to get firmware name\n");
>  		else {
>  			ret = sdma_get_firmware(sdma, fw_name);
>  			if (ret)
> -				dev_err(&pdev->dev, "failed to get firmware from device tree\n");
> +				dev_warn(&pdev->dev, "failed to get firmware from device tree\n");
>  		}
>  	}
>  
> -- 
> 1.7.1
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: [PATCH] dma: imx-sdma: Treat firmware messages as warnings instead of erros

[Vinod Koul]

On Thu, 2012-03-08 at 09:26 -0300, Fabio Estevam wrote:
> As the SDMA controller can operate without an external firmware being loaded,
> treat the firmware related messages as warnings rather than errors.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Applied Thanks
> ---
>  drivers/dma/imx-sdma.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index c495882..3b7ebd4 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -1389,7 +1389,7 @@ static int __init sdma_probe(struct platform_device *pdev)
>  	if (pdata) {
>  		ret = sdma_get_firmware(sdma, pdata->fw_name);
>  		if (ret)
> -			dev_err(&pdev->dev, "failed to get firmware from platform data\n");
> +			dev_warn(&pdev->dev, "failed to get firmware from platform data\n");
>  	} else {
>  		/*
>  		 * Because that device tree does not encode ROM script address,
> @@ -1399,11 +1399,11 @@ static int __init sdma_probe(struct platform_device *pdev)
>  		ret = of_property_read_string(np, "fsl,sdma-ram-script-name",
>  					      &fw_name);
>  		if (ret)
> -			dev_err(&pdev->dev, "failed to get firmware name\n");
> +			dev_warn(&pdev->dev, "failed to get firmware name\n");
>  		else {
>  			ret = sdma_get_firmware(sdma, fw_name);
>  			if (ret)
> -				dev_err(&pdev->dev, "failed to get firmware from device tree\n");
> +				dev_warn(&pdev->dev, "failed to get firmware from device tree\n");
>  		}
>  	}
>  


-- 
~Vinod