* [PATCH] dma: imx-sdma: Treat firmware messages as warnings instead of erros
@ 2012-03-08 12:26 Fabio Estevam
2012-03-13 13:13 ` Sascha Hauer
2012-03-21 10:09 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2012-03-08 12:26 UTC (permalink / raw)
To: linux-kernel; +Cc: vinod.koul, kernel, Fabio Estevam
As the SDMA controller can operate without an external firmware being loaded,
treat the firmware related messages as warnings rather than errors.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/dma/imx-sdma.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
index c495882..3b7ebd4 100644
--- a/drivers/dma/imx-sdma.c
+++ b/drivers/dma/imx-sdma.c
@@ -1389,7 +1389,7 @@ static int __init sdma_probe(struct platform_device *pdev)
if (pdata) {
ret = sdma_get_firmware(sdma, pdata->fw_name);
if (ret)
- dev_err(&pdev->dev, "failed to get firmware from platform data\n");
+ dev_warn(&pdev->dev, "failed to get firmware from platform data\n");
} else {
/*
* Because that device tree does not encode ROM script address,
@@ -1399,11 +1399,11 @@ static int __init sdma_probe(struct platform_device *pdev)
ret = of_property_read_string(np, "fsl,sdma-ram-script-name",
&fw_name);
if (ret)
- dev_err(&pdev->dev, "failed to get firmware name\n");
+ dev_warn(&pdev->dev, "failed to get firmware name\n");
else {
ret = sdma_get_firmware(sdma, fw_name);
if (ret)
- dev_err(&pdev->dev, "failed to get firmware from device tree\n");
+ dev_warn(&pdev->dev, "failed to get firmware from device tree\n");
}
}
--
1.7.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dma: imx-sdma: Treat firmware messages as warnings instead of erros
2012-03-08 12:26 [PATCH] dma: imx-sdma: Treat firmware messages as warnings instead of erros Fabio Estevam
@ 2012-03-13 13:13 ` Sascha Hauer
2012-03-21 10:09 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2012-03-13 13:13 UTC (permalink / raw)
To: Fabio Estevam; +Cc: linux-kernel, vinod.koul, kernel
On Thu, Mar 08, 2012 at 09:26:39AM -0300, Fabio Estevam wrote:
> As the SDMA controller can operate without an external firmware being loaded,
> treat the firmware related messages as warnings rather than errors.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Sascha
> ---
> drivers/dma/imx-sdma.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index c495882..3b7ebd4 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -1389,7 +1389,7 @@ static int __init sdma_probe(struct platform_device *pdev)
> if (pdata) {
> ret = sdma_get_firmware(sdma, pdata->fw_name);
> if (ret)
> - dev_err(&pdev->dev, "failed to get firmware from platform data\n");
> + dev_warn(&pdev->dev, "failed to get firmware from platform data\n");
> } else {
> /*
> * Because that device tree does not encode ROM script address,
> @@ -1399,11 +1399,11 @@ static int __init sdma_probe(struct platform_device *pdev)
> ret = of_property_read_string(np, "fsl,sdma-ram-script-name",
> &fw_name);
> if (ret)
> - dev_err(&pdev->dev, "failed to get firmware name\n");
> + dev_warn(&pdev->dev, "failed to get firmware name\n");
> else {
> ret = sdma_get_firmware(sdma, fw_name);
> if (ret)
> - dev_err(&pdev->dev, "failed to get firmware from device tree\n");
> + dev_warn(&pdev->dev, "failed to get firmware from device tree\n");
> }
> }
>
> --
> 1.7.1
>
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dma: imx-sdma: Treat firmware messages as warnings instead of erros
2012-03-08 12:26 [PATCH] dma: imx-sdma: Treat firmware messages as warnings instead of erros Fabio Estevam
2012-03-13 13:13 ` Sascha Hauer
@ 2012-03-21 10:09 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2012-03-21 10:09 UTC (permalink / raw)
To: Fabio Estevam; +Cc: linux-kernel, kernel
On Thu, 2012-03-08 at 09:26 -0300, Fabio Estevam wrote:
> As the SDMA controller can operate without an external firmware being loaded,
> treat the firmware related messages as warnings rather than errors.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Applied Thanks
> ---
> drivers/dma/imx-sdma.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index c495882..3b7ebd4 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -1389,7 +1389,7 @@ static int __init sdma_probe(struct platform_device *pdev)
> if (pdata) {
> ret = sdma_get_firmware(sdma, pdata->fw_name);
> if (ret)
> - dev_err(&pdev->dev, "failed to get firmware from platform data\n");
> + dev_warn(&pdev->dev, "failed to get firmware from platform data\n");
> } else {
> /*
> * Because that device tree does not encode ROM script address,
> @@ -1399,11 +1399,11 @@ static int __init sdma_probe(struct platform_device *pdev)
> ret = of_property_read_string(np, "fsl,sdma-ram-script-name",
> &fw_name);
> if (ret)
> - dev_err(&pdev->dev, "failed to get firmware name\n");
> + dev_warn(&pdev->dev, "failed to get firmware name\n");
> else {
> ret = sdma_get_firmware(sdma, fw_name);
> if (ret)
> - dev_err(&pdev->dev, "failed to get firmware from device tree\n");
> + dev_warn(&pdev->dev, "failed to get firmware from device tree\n");
> }
> }
>
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-03-21 10:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-08 12:26 [PATCH] dma: imx-sdma: Treat firmware messages as warnings instead of erros Fabio Estevam
2012-03-13 13:13 ` Sascha Hauer
2012-03-21 10:09 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®