* [PATCH] mmc: sdhci-esdhc-imx: Remove unused variables
@ 2013-01-30 20:11 Thierry Reding
2013-01-31 0:31 ` Shawn Guo
0 siblings, 1 reply; 3+ messages in thread
From: Thierry Reding @ 2013-01-30 20:11 UTC (permalink / raw)
To: Chris Ball; +Cc: Shawn Guo, linux-mmc, linux-kernel
Commit 3f175a6 (mmc: sdhci-esdhc-imx: remove ESDHC_CD_GPIO handling from
IO accessory) removed all the code that was using these variables, so it
is safe to drop them.
Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
---
drivers/mmc/host/sdhci-esdhc-imx.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
index ae68bc9..509be3a 100644
--- a/drivers/mmc/host/sdhci-esdhc-imx.c
+++ b/drivers/mmc/host/sdhci-esdhc-imx.c
@@ -144,10 +144,6 @@ static inline void esdhc_clrset_le(struct sdhci_host *host, u32 mask, u32 val, i
static u32 esdhc_readl_le(struct sdhci_host *host, int reg)
{
- struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
- struct pltfm_imx_data *imx_data = pltfm_host->priv;
- struct esdhc_platform_data *boarddata = &imx_data->boarddata;
-
u32 val = readl(host->ioaddr + reg);
if (unlikely(reg == SDHCI_CAPABILITIES)) {
@@ -178,7 +174,6 @@ static void esdhc_writel_le(struct sdhci_host *host, u32 val, int reg)
{
struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
struct pltfm_imx_data *imx_data = pltfm_host->priv;
- struct esdhc_platform_data *boarddata = &imx_data->boarddata;
u32 data;
if (unlikely(reg == SDHCI_INT_ENABLE || reg == SDHCI_SIGNAL_ENABLE)) {
--
1.8.1.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mmc: sdhci-esdhc-imx: Remove unused variables
2013-01-30 20:11 [PATCH] mmc: sdhci-esdhc-imx: Remove unused variables Thierry Reding
@ 2013-01-31 0:31 ` Shawn Guo
2013-01-31 7:00 ` Thierry Reding
0 siblings, 1 reply; 3+ messages in thread
From: Shawn Guo @ 2013-01-31 0:31 UTC (permalink / raw)
To: Thierry Reding; +Cc: Chris Ball, linux-mmc, linux-kernel
On Wed, Jan 30, 2013 at 09:11:21PM +0100, Thierry Reding wrote:
> Commit 3f175a6 (mmc: sdhci-esdhc-imx: remove ESDHC_CD_GPIO handling from
> IO accessory) removed all the code that was using these variables, so it
> is safe to drop them.
>
> Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
Thanks for the fixing, Thierry. But Chris has already queued a fix [1]
from Fabio.
Shawn
[1] http://thread.gmane.org/gmane.linux.kernel.mmc/18724
> ---
> drivers/mmc/host/sdhci-esdhc-imx.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
> index ae68bc9..509be3a 100644
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
> @@ -144,10 +144,6 @@ static inline void esdhc_clrset_le(struct sdhci_host *host, u32 mask, u32 val, i
>
> static u32 esdhc_readl_le(struct sdhci_host *host, int reg)
> {
> - struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
> - struct pltfm_imx_data *imx_data = pltfm_host->priv;
> - struct esdhc_platform_data *boarddata = &imx_data->boarddata;
> -
> u32 val = readl(host->ioaddr + reg);
>
> if (unlikely(reg == SDHCI_CAPABILITIES)) {
> @@ -178,7 +174,6 @@ static void esdhc_writel_le(struct sdhci_host *host, u32 val, int reg)
> {
> struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
> struct pltfm_imx_data *imx_data = pltfm_host->priv;
> - struct esdhc_platform_data *boarddata = &imx_data->boarddata;
> u32 data;
>
> if (unlikely(reg == SDHCI_INT_ENABLE || reg == SDHCI_SIGNAL_ENABLE)) {
> --
> 1.8.1.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mmc: sdhci-esdhc-imx: Remove unused variables
2013-01-31 0:31 ` Shawn Guo
@ 2013-01-31 7:00 ` Thierry Reding
0 siblings, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2013-01-31 7:00 UTC (permalink / raw)
To: Shawn Guo; +Cc: Chris Ball, linux-mmc, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 507 bytes --]
On Thu, Jan 31, 2013 at 08:31:20AM +0800, Shawn Guo wrote:
> On Wed, Jan 30, 2013 at 09:11:21PM +0100, Thierry Reding wrote:
> > Commit 3f175a6 (mmc: sdhci-esdhc-imx: remove ESDHC_CD_GPIO handling from
> > IO accessory) removed all the code that was using these variables, so it
> > is safe to drop them.
> >
> > Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
>
> Thanks for the fixing, Thierry. But Chris has already queued a fix [1]
> from Fabio.
Okay, great!
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-31 7:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-30 20:11 [PATCH] mmc: sdhci-esdhc-imx: Remove unused variables Thierry Reding
2013-01-31 0:31 ` Shawn Guo
2013-01-31 7:00 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome