From: Mark Brown <broonie@kernel.org>
To: Wei Ni <wni@nvidia.com>
Cc: khali@linux-fr.org, linux@roeck-us.net, swarren@wwwdotorg.org,
lm-sensors@lm-sensors.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] hwmon: (lm90) Add power control
Date: Mon, 9 Sep 2013 12:12:42 +0100 [thread overview]
Message-ID: <20130909111242.GW29403@sirena.org.uk> (raw)
In-Reply-To: <1378722552-10357-2-git-send-email-wni@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 778 bytes --]
On Mon, Sep 09, 2013 at 06:29:11PM +0800, Wei Ni wrote:
> + reg = devm_regulator_get_optional(dev, "vcc");
> + if (!IS_ERR(reg)) {
> + err = regulator_enable(reg);
> + if (err < 0) {
> + dev_err(&client->dev,
> + "Failed to enable regulator: %d\n", err);
> + return err;
> + }
> + msleep(25);
> + } else {
> + if (PTR_ERR(reg) == -EPROBE_DEFER)
> + return -EPROBE_DEFER;
> + }
This doesn't look good, it is going to ignore actual errors - I *really*
doubt that vcc is optional, it looks like it's the main power supply for
the device. You should use normal regulator_get(), _optional() is for
supplies which could physically not be provided in a system (eg, if the
device can generate them internally if required).
Also do you really need 25ms after power on?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-09-09 11:13 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-09 10:29 [PATCH v3 0/2] Add power control for lm90 Wei Ni
2013-09-09 10:29 ` [PATCH v3 1/2] hwmon: (lm90) Add power control Wei Ni
2013-09-09 11:12 ` Mark Brown [this message]
2013-09-09 11:34 ` Guenter Roeck
2013-09-09 13:50 ` Mark Brown
2013-09-09 15:50 ` Guenter Roeck
2013-09-09 16:02 ` Mark Brown
2013-09-09 16:17 ` Guenter Roeck
2013-09-09 20:39 ` Mark Brown
2013-09-10 4:05 ` Wei Ni
2013-09-10 4:50 ` Guenter Roeck
2013-09-10 5:39 ` Wei Ni
2013-09-10 5:54 ` Guenter Roeck
2013-09-10 6:30 ` Wei Ni
2013-09-10 10:13 ` Mark Brown
2013-09-10 11:29 ` Wei Ni
2013-09-10 12:11 ` Mark Brown
2013-09-11 9:40 ` Wei Ni
2013-09-10 3:22 ` Wei Ni
2013-09-10 3:36 ` Guenter Roeck
2013-09-10 3:40 ` Stephen Warren
2013-09-10 3:53 ` Guenter Roeck
2013-09-10 4:12 ` Wei Ni
2013-09-10 4:13 ` Stephen Warren
2013-09-10 4:44 ` Guenter Roeck
2013-09-10 10:09 ` Mark Brown
2013-09-10 15:07 ` Stephen Warren
2013-09-10 17:04 ` Mark Brown
2013-09-10 17:44 ` Stephen Warren
2013-09-10 18:07 ` Guenter Roeck
2013-09-10 18:18 ` Mark Brown
2013-09-10 18:37 ` Stephen Warren
2013-09-10 18:52 ` Mark Brown
2013-09-11 11:35 ` Wei Ni
2013-09-10 17:05 ` Mark Brown
2013-09-09 10:29 ` [PATCH v3 2/2] Documentation: dt: hwmon: add OF document for LM90 Wei Ni
2013-09-09 10:52 ` Guenter Roeck
2013-09-09 22:14 ` Stephen Warren
2013-09-10 4:25 ` Wei Ni
2013-09-09 10:57 ` Ramkumar Ramachandra
2013-09-10 4:35 ` Wei Ni
2013-09-10 4:36 ` Wei Ni
2013-09-09 22:15 ` Stephen Warren
2013-09-09 22:23 ` Guenter Roeck
2013-09-10 4:25 ` Wei Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130909111242.GW29403@sirena.org.uk \
--to=broonie@kernel.org \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
--cc=swarren@wwwdotorg.org \
--cc=wni@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®