From: Mark Brown <broonie@kernel.org>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Guenter Roeck <linux@roeck-us.net>, Wei Ni <wni@nvidia.com>,
"khali@linux-fr.org" <khali@linux-fr.org>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] hwmon: (lm90) Add power control
Date: Tue, 10 Sep 2013 11:09:39 +0100 [thread overview]
Message-ID: <20130910100939.GW29403@sirena.org.uk> (raw)
In-Reply-To: <522E9C84.9070405@wwwdotorg.org>
[-- Attachment #1: Type: text/plain, Size: 1151 bytes --]
On Mon, Sep 09, 2013 at 10:13:56PM -0600, Stephen Warren wrote:
> On 09/09/2013 09:53 PM, Guenter Roeck wrote:
> > Earlier comments suggest that this is not the intended use case for
> > regulator_get_optional().
That's right.
> Isn't the issue only whether the optional aspect of the regulator is
> implemented by:
> a) regulator_get_optional() returning failure, then the driver having to
> check for that and either using or not-using the regulator.
> b) regulator_get_optional() returning a dummy regulator automatically
> when none is specified in DT or the regulator lookup table, and hence
> the driver can always call regulator_enable/disable on the returned value.
No. There are a couple of issues here. One is that we don't want to
litter all drivers with conditional code to check if they actually got
the regulator and so on, that's just pointless make work on the part of
consumers. The other is that just ignoring errors is generally terrible
practice which we don't want to encourage - ignoring the specific case
where nothing is provided and the system has control of that is one
thing but just ignoring any error is another.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-09-10 10:10 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-09 10:29 [PATCH v3 0/2] Add power control for lm90 Wei Ni
2013-09-09 10:29 ` [PATCH v3 1/2] hwmon: (lm90) Add power control Wei Ni
2013-09-09 11:12 ` Mark Brown
2013-09-09 11:34 ` Guenter Roeck
2013-09-09 13:50 ` Mark Brown
2013-09-09 15:50 ` Guenter Roeck
2013-09-09 16:02 ` Mark Brown
2013-09-09 16:17 ` Guenter Roeck
2013-09-09 20:39 ` Mark Brown
2013-09-10 4:05 ` Wei Ni
2013-09-10 4:50 ` Guenter Roeck
2013-09-10 5:39 ` Wei Ni
2013-09-10 5:54 ` Guenter Roeck
2013-09-10 6:30 ` Wei Ni
2013-09-10 10:13 ` Mark Brown
2013-09-10 11:29 ` Wei Ni
2013-09-10 12:11 ` Mark Brown
2013-09-11 9:40 ` Wei Ni
2013-09-10 3:22 ` Wei Ni
2013-09-10 3:36 ` Guenter Roeck
2013-09-10 3:40 ` Stephen Warren
2013-09-10 3:53 ` Guenter Roeck
2013-09-10 4:12 ` Wei Ni
2013-09-10 4:13 ` Stephen Warren
2013-09-10 4:44 ` Guenter Roeck
2013-09-10 10:09 ` Mark Brown [this message]
2013-09-10 15:07 ` Stephen Warren
2013-09-10 17:04 ` Mark Brown
2013-09-10 17:44 ` Stephen Warren
2013-09-10 18:07 ` Guenter Roeck
2013-09-10 18:18 ` Mark Brown
2013-09-10 18:37 ` Stephen Warren
2013-09-10 18:52 ` Mark Brown
2013-09-11 11:35 ` Wei Ni
2013-09-10 17:05 ` Mark Brown
2013-09-09 10:29 ` [PATCH v3 2/2] Documentation: dt: hwmon: add OF document for LM90 Wei Ni
2013-09-09 10:52 ` Guenter Roeck
2013-09-09 22:14 ` Stephen Warren
2013-09-10 4:25 ` Wei Ni
2013-09-09 10:57 ` Ramkumar Ramachandra
2013-09-10 4:35 ` Wei Ni
2013-09-10 4:36 ` Wei Ni
2013-09-09 22:15 ` Stephen Warren
2013-09-09 22:23 ` Guenter Roeck
2013-09-10 4:25 ` Wei Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130910100939.GW29403@sirena.org.uk \
--to=broonie@kernel.org \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
--cc=swarren@wwwdotorg.org \
--cc=wni@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®