From: Tejun Heo <tj@kernel.org>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
David Rientjes <rientjes@google.com>,
Michal Hocko <mhocko@suse.cz>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [Patch v4 1/2] freezer: check OOM kill while being frozen
Date: Sat, 6 Sep 2014 07:45:54 +0900 [thread overview]
Message-ID: <20140905224554.GD15723@mtj.dyndns.org> (raw)
In-Reply-To: <CAM_iQpUbGTxrbJZ_ztf+QUvFowsivQ-jvPCSi7kmth7nstPvaA@mail.gmail.com>
Hello,
On Fri, Sep 05, 2014 at 11:12:24AM -0700, Cong Wang wrote:
> > Rafael, can you please help?
>
> Rafael is known not responsive at least for this topic. :)
:(
> > Shouldn't the primary goal of the comment be explaining why we need
> > TIF_MEMDIE check there at all anyway? The deadlock possiblity is not
> > very obvious.
>
> The changelog is not long enough?? ;-) I hate to copy+paste changelog
> into comments, changelog is essentially necessary for people to understand
> kernel code (at least networking) , so I don't think we have to move it
> into comments in this case.
It doesn't have to be the same text but the current comment is
basically content-less. e.g. it can just say "OOM killer may get
stuck trying to kill a cgroup frozen task" and actualy provide
information on what condition the conditional tries to address.
Thanks.
--
tejun
next prev parent reply other threads:[~2014-09-05 22:46 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 22:30 Cong Wang
2014-09-04 22:30 ` [Patch v4 2/2] freezer: remove obsolete comments in __thaw_task() Cong Wang
2014-09-05 9:45 ` Michal Hocko
2014-09-05 14:09 ` Tejun Heo
2014-09-05 14:08 ` [Patch v4 1/2] freezer: check OOM kill while being frozen Tejun Heo
2014-09-05 16:31 ` Cong Wang
2014-09-05 18:00 ` Tejun Heo
2014-09-05 18:12 ` Cong Wang
2014-09-05 22:45 ` Tejun Heo [this message]
2014-09-05 23:32 ` Rafael J. Wysocki
2014-09-08 17:40 ` Cong Wang
2014-09-08 20:54 ` Rafael J. Wysocki
2014-09-08 20:58 ` Cong Wang
2014-09-08 21:53 ` Rafael J. Wysocki
2014-09-08 22:22 ` Tejun Heo
2014-09-08 22:48 ` Rafael J. Wysocki
2014-09-08 22:50 ` Tejun Heo
2014-09-08 23:15 ` Rafael J. Wysocki
2014-09-08 23:00 ` Cong Wang
2014-09-08 23:23 ` Rafael J. Wysocki
2014-09-08 23:16 ` Cong Wang
2014-09-08 23:42 ` Rafael J. Wysocki
2014-09-08 23:29 ` Cong Wang
2014-09-08 23:59 ` Rafael J. Wysocki
2014-09-10 20:30 ` Cong Wang
2014-09-10 23:38 ` Rafael J. Wysocki
2014-09-10 23:20 ` Cong Wang
2014-09-11 16:30 ` Michal Hocko
2014-09-12 23:59 ` Tejun Heo
2014-09-14 16:43 ` Rafael J. Wysocki
2014-09-15 0:56 ` Tejun Heo
2014-09-15 3:34 ` Rafael J. Wysocki
2014-09-15 9:36 ` Michal Hocko
2014-09-16 22:55 ` Cong Wang
2014-09-22 8:21 ` Michal Hocko
2014-09-09 15:16 ` Michal Hocko
2014-09-09 15:23 ` Tejun Heo
2014-09-09 16:06 ` Michal Hocko
2014-09-09 16:46 ` Tejun Heo
2014-09-09 17:12 ` Michal Hocko
2014-09-09 20:53 ` Rafael J. Wysocki
2014-09-10 13:24 ` Michal Hocko
2014-09-11 13:08 ` Michal Hocko
2014-09-11 14:17 ` Rafael J. Wysocki
2014-09-11 14:04 ` Michal Hocko
2014-09-11 14:26 ` Rafael J. Wysocki
2014-09-11 14:10 ` Michal Hocko
2014-09-11 14:32 ` Rafael J. Wysocki
2014-09-11 14:28 ` Michal Hocko
2014-09-11 14:52 ` Rafael J. Wysocki
2014-09-11 14:45 ` Michal Hocko
2014-09-14 16:39 ` Rafael J. Wysocki
2014-09-12 23:48 ` Tejun Heo
2014-09-15 14:28 ` Michal Hocko
2014-09-16 5:56 ` Tejun Heo
2014-09-09 20:48 ` Rafael J. Wysocki
2014-09-10 5:21 ` Cong Wang
2014-09-05 16:43 ` Cong Wang
2014-09-05 16:54 ` Michal Hocko
2014-09-15 11:22 ` Michal Hocko
2014-09-16 22:58 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140905224554.GD15723@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.cz \
--cc=rientjes@google.com \
--cc=rjw@rjwysocki.net \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome