From: Jiri Olsa <jolsa@redhat.com>
To: Stephane Eranian <eranian@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
"mingo@elte.hu" <mingo@elte.hu>,
"ak@linux.intel.com" <ak@linux.intel.com>,
"Liang, Kan" <kan.liang@intel.com>,
Borislav Petkov <bp@alien8.de>,
Maria Dimakopoulou <maria.n.dimakopoulou@gmail.com>
Subject: Re: [PATCH v2 05/12] perf/x86: add cross-HT counter exclusion infrastructure
Date: Thu, 23 Oct 2014 09:14:49 +0200 [thread overview]
Message-ID: <20141023071448.GB3356@krava.brq.redhat.com> (raw)
In-Reply-To: <CABPqkBTim1nHhF2zEm0FGLBVStuD1TvdH_gifP+f3GCxdMp4Ag@mail.gmail.com>
On Wed, Oct 22, 2014 at 07:25:40PM +0200, Stephane Eranian wrote:
> On Wed, Oct 22, 2014 at 5:07 PM, Jiri Olsa <jolsa@redhat.com> wrote:
> > On Thu, Oct 09, 2014 at 06:34:39PM +0200, Stephane Eranian wrote:
> >> From: Maria Dimakopoulou <maria.n.dimakopoulou@gmail.com>
> >>
> >
> > SNIP
> >
> >> +struct intel_excl_cntrs *allocate_excl_cntrs(int cpu)
> >> +{
> >> + struct intel_excl_cntrs *c;
> >> + int i;
> >> +
> >> + c = kzalloc_node(sizeof(struct intel_excl_cntrs),
> >> + GFP_KERNEL, cpu_to_node(cpu));
> >> + if (c) {
> >> + spin_lock_init(&c->lock);
> >> + for (i = 0; i < X86_PMC_IDX_MAX; i++) {
> >> + c->states[0].state[i] = INTEL_EXCL_UNUSED;
> >> + c->states[0].init_state[i] = INTEL_EXCL_UNUSED;
> >> +
> >> + c->states[1].state[i] = INTEL_EXCL_UNUSED;
> >> + c->states[1].init_state[i] = INTEL_EXCL_UNUSED;
> >
> > 'c' is allocated with kzalloc_node, seems there's no need
> > to re-initialize states it to zero again with INTEL_EXCL_UNUSED
> >
> You are assuming that INTEL_EXCL_UNUSED=0 always.
> That means it needs to be clear there is a dependency here.
it's 0 explicitly:
enum intel_excl_state_type {
INTEL_EXCL_UNUSED = 0, /* counter is unused */
but it's not big issue for me.. just curious ;-)
jirka
next prev parent reply other threads:[~2014-10-23 7:15 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 16:34 [PATCH v2 0/12] perf/x86: implement HT leak workaround for SNB/IVB/HSW Stephane Eranian
2014-10-09 16:34 ` [PATCH v2 01/12] perf,x86: rename er_flags to flags Stephane Eranian
2014-10-09 16:34 ` [PATCH v2 02/12] perf/x86: vectorize cpuc->kfree_on_online Stephane Eranian
2014-10-09 16:34 ` [PATCH v2 03/12] perf/x86: add 3 new scheduling callbacks Stephane Eranian
2014-10-09 16:34 ` [PATCH v2 04/12] perf/x86: add index param to get_event_constraint() callback Stephane Eranian
2014-10-09 16:34 ` [PATCH v2 05/12] perf/x86: add cross-HT counter exclusion infrastructure Stephane Eranian
2014-10-21 11:17 ` Peter Zijlstra
2014-10-21 11:18 ` Peter Zijlstra
2014-10-22 15:07 ` Jiri Olsa
2014-10-22 17:25 ` Stephane Eranian
2014-10-23 7:14 ` Jiri Olsa [this message]
2014-10-09 16:34 ` [PATCH v2 06/12] perf/x86: implement cross-HT corruption bug workaround Stephane Eranian
2014-10-22 12:31 ` Jiri Olsa
2014-10-23 7:19 ` Jiri Olsa
2014-10-23 8:01 ` Stephane Eranian
2014-10-23 8:13 ` Jiri Olsa
2014-10-09 16:34 ` [PATCH v2 07/12] perf/x86: enforce HT bug workaround for SNB/IVB/HSW Stephane Eranian
2014-10-09 16:34 ` [PATCH v2 08/12] perf/x86: enforce HT bug workaround with PEBS " Stephane Eranian
2014-10-09 16:34 ` [PATCH v2 09/12] perf/x86: fix intel_get_event_constraints() for dynamic constraints Stephane Eranian
2014-10-09 16:34 ` [PATCH v2 10/12] watchdog: add watchdog enable/disable all functions Stephane Eranian
2014-10-09 16:34 ` [PATCH v2 11/12] perf/x86: make HT bug workaround conditioned on HT enabled Stephane Eranian
2014-10-22 13:27 ` Jiri Olsa
2014-10-22 14:36 ` Stephane Eranian
2014-10-22 14:58 ` Jiri Olsa
2014-10-22 16:42 ` Stephane Eranian
2014-10-09 16:34 ` [PATCH v2 12/12] perf/x86: add syfs entry to disable HT bug workaround Stephane Eranian
2014-10-21 11:25 ` [PATCH v2 0/12] perf/x86: implement HT leak workaround for SNB/IVB/HSW Peter Zijlstra
2014-10-21 12:28 ` Stephane Eranian
2014-10-21 13:03 ` Peter Zijlstra
2014-10-21 13:08 ` Stephane Eranian
2014-10-22 9:12 ` Peter Zijlstra
2014-10-22 21:04 ` Stephane Eranian
2014-10-23 8:53 ` Peter Zijlstra
2014-10-23 8:57 ` Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141023071448.GB3356@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=ak@linux.intel.com \
--cc=bp@alien8.de \
--cc=eranian@google.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maria.n.dimakopoulou@gmail.com \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®