[PATCH] staging: ft1000: warning removal: extern functions to static ones

[PATCH] staging: ft1000: warning removal: extern functions to static ones

[Xavier Roche]

Local functions not used in other modules should be static, not extern.
(patch checked against linux-next and staging)

Signed-off-by: Xavier Roche <roche@httrack.com>
---
 drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c | 24 +++++++++++-----------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c
index 83683e9..3237ee73 100644
--- a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c
+++ b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c
@@ -82,12 +82,12 @@
 #define  STATE_DONE_PROV         0x06
 #define  STATE_DONE_FILE         0x07
 
-u16 get_handshake(struct net_device *dev, u16 expected_value);
-void put_handshake(struct net_device *dev, u16 handshake_value);
-u16 get_request_type(struct net_device *dev);
-long get_request_value(struct net_device *dev);
-void put_request_value(struct net_device *dev, long lvalue);
-u16 hdr_checksum(struct pseudo_hdr *pHdr);
+static u16 get_handshake(struct net_device *dev, u16 expected_value);
+static void put_handshake(struct net_device *dev, u16 handshake_value);
+static u16 get_request_type(struct net_device *dev);
+static long get_request_value(struct net_device *dev);
+static void put_request_value(struct net_device *dev, long lvalue);
+static u16 hdr_checksum(struct pseudo_hdr *pHdr);
 
 struct dsp_file_hdr {
 	u32  version_id;	/* Version ID of this image format. */
@@ -146,7 +146,7 @@ void card_bootload(struct net_device *dev)
 	spin_unlock_irqrestore(&info->dpram_lock, flags);
 }
 
-u16 get_handshake(struct net_device *dev, u16 expected_value)
+static u16 get_handshake(struct net_device *dev, u16 expected_value)
 {
 	struct ft1000_info *info = netdev_priv(dev);
 	u16 handshake;
@@ -180,7 +180,7 @@ u16 get_handshake(struct net_device *dev, u16 expected_value)
 
 }
 
-void put_handshake(struct net_device *dev, u16 handshake_value)
+static void put_handshake(struct net_device *dev, u16 handshake_value)
 {
 	struct ft1000_info *info = netdev_priv(dev);
 	u32 tempx;
@@ -196,7 +196,7 @@ void put_handshake(struct net_device *dev, u16 handshake_value)
 	}
 }
 
-u16 get_request_type(struct net_device *dev)
+static u16 get_request_type(struct net_device *dev)
 {
 	struct ft1000_info *info = netdev_priv(dev);
 	u16 request_type;
@@ -215,7 +215,7 @@ u16 get_request_type(struct net_device *dev)
 
 }
 
-long get_request_value(struct net_device *dev)
+static long get_request_value(struct net_device *dev)
 {
 	struct ft1000_info *info = netdev_priv(dev);
 	long value;
@@ -244,7 +244,7 @@ long get_request_value(struct net_device *dev)
 
 }
 
-void put_request_value(struct net_device *dev, long lvalue)
+static void put_request_value(struct net_device *dev, long lvalue)
 {
 	struct ft1000_info *info = netdev_priv(dev);
 	u16 size;
@@ -271,7 +271,7 @@ void put_request_value(struct net_device *dev, long lvalue)
 
 }
 
-u16 hdr_checksum(struct pseudo_hdr *pHdr)
+static u16 hdr_checksum(struct pseudo_hdr *pHdr)
 {
 	u16 *usPtr = (u16 *)pHdr;
 	u16 chksum;
-- 
1.9.1

Re: [PATCH] staging: ft1000: warning removal: extern functions to static ones

[Greg KH]

On Thu, May 28, 2015 at 05:24:56PM +0200, Xavier Roche wrote:
> Local functions not used in other modules should be static, not extern.
> (patch checked against linux-next and staging)

This line shouldn't be here, it should just be "implied" :)

> Signed-off-by: Xavier Roche <roche@httrack.com>
> ---
>  drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c | 24 +++++++++++-----------
>  1 file changed, 12 insertions(+), 12 deletions(-)

In the future, always use scripts/get_maintainer.pl to determine who to
send patches to please.

thanks,

greg k-h

Re: [PATCH] staging: ft1000: warning removal: extern functions to static ones

[Xavier Roche]

Hi Greg & mailing-list members,

On Thu, 28 May 2015, Greg KH wrote:
> In the future, always use scripts/get_maintainer.pl to determine who to
> send patches to please.

Sorry, I did use the get_maintainer.pl script, but I did not want to 
bother too many people, and I only picked Marek in CC: (I also did not 
include commit_signer/authored emails)

I also did not include trivial@kernel.org  this time - wasn't sure is this 
was "trivial enough".

Thanks for the feedback! (and sorry for the direct reply - did not 
intended to be rude)

Xavier

Re: [PATCH] staging: ft1000: warning removal: extern functions to static ones

[Greg KH]

On Thu, May 28, 2015 at 11:16:27PM +0200, Xavier Roche wrote:
> Hi Greg & mailing-list members,
> 
> On Thu, 28 May 2015, Greg KH wrote:
> >In the future, always use scripts/get_maintainer.pl to determine who to
> >send patches to please.
> 
> Sorry, I did use the get_maintainer.pl script, but I did not want to bother
> too many people, and I only picked Marek in CC: (I also did not include
> commit_signer/authored emails)
> 
> I also did not include trivial@kernel.org  this time - wasn't sure is this
> was "trivial enough".

No need to bother the trivial maintainer for staging patches, I have no
problem taking them myself.

thanks,

greg k-h