* [PATCH 1/4] usb: host: ehci-spear: Fix module autoload for OF platform driver
@ 2015-09-18 18:21 Luis de Bethencourt
2015-09-18 18:57 ` Alan Stern
0 siblings, 1 reply; 3+ messages in thread
From: Luis de Bethencourt @ 2015-09-18 18:21 UTC (permalink / raw)
To: linux-kernel; +Cc: Alan Stern, Greg Kroah-Hartman, linux-usb
This platform driver has a OF device ID table but the OF module
alias information is not created so module autoloading won't work.
Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
---
drivers/usb/host/ehci-spear.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/host/ehci-spear.c b/drivers/usb/host/ehci-spear.c
index 34e1474..be7bcf2 100644
--- a/drivers/usb/host/ehci-spear.c
+++ b/drivers/usb/host/ehci-spear.c
@@ -149,6 +149,7 @@ static const struct of_device_id spear_ehci_id_table[] = {
{ .compatible = "st,spear600-ehci", },
{ },
};
+MODULE_DEVICE_TABLE(spear_ehci_id_table);
static struct platform_driver spear_ehci_hcd_driver = {
.probe = spear_ehci_hcd_drv_probe,
--
2.4.6
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/4] usb: host: ehci-spear: Fix module autoload for OF platform driver
2015-09-18 18:21 [PATCH 1/4] usb: host: ehci-spear: Fix module autoload for OF platform driver Luis de Bethencourt
@ 2015-09-18 18:57 ` Alan Stern
2015-09-18 19:09 ` Luis de Bethencourt
0 siblings, 1 reply; 3+ messages in thread
From: Alan Stern @ 2015-09-18 18:57 UTC (permalink / raw)
To: Luis de Bethencourt; +Cc: linux-kernel, Greg Kroah-Hartman, linux-usb
On Fri, 18 Sep 2015, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
>
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
> drivers/usb/host/ehci-spear.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/host/ehci-spear.c b/drivers/usb/host/ehci-spear.c
> index 34e1474..be7bcf2 100644
> --- a/drivers/usb/host/ehci-spear.c
> +++ b/drivers/usb/host/ehci-spear.c
> @@ -149,6 +149,7 @@ static const struct of_device_id spear_ehci_id_table[] = {
> { .compatible = "st,spear600-ehci", },
> { },
> };
> +MODULE_DEVICE_TABLE(spear_ehci_id_table);
Shouldn't this be MODULE_DEVICE_TABLE(of, spear_ehci_id_table)?
Alan Stern
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/4] usb: host: ehci-spear: Fix module autoload for OF platform driver
2015-09-18 18:57 ` Alan Stern
@ 2015-09-18 19:09 ` Luis de Bethencourt
0 siblings, 0 replies; 3+ messages in thread
From: Luis de Bethencourt @ 2015-09-18 19:09 UTC (permalink / raw)
To: Alan Stern; +Cc: linux-kernel, Greg Kroah-Hartman, linux-usb
On Fri, Sep 18, 2015 at 02:57:10PM -0400, Alan Stern wrote:
> On Fri, 18 Sep 2015, Luis de Bethencourt wrote:
>
> > This platform driver has a OF device ID table but the OF module
> > alias information is not created so module autoloading won't work.
> >
> > Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> > ---
> > drivers/usb/host/ehci-spear.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/usb/host/ehci-spear.c b/drivers/usb/host/ehci-spear.c
> > index 34e1474..be7bcf2 100644
> > --- a/drivers/usb/host/ehci-spear.c
> > +++ b/drivers/usb/host/ehci-spear.c
> > @@ -149,6 +149,7 @@ static const struct of_device_id spear_ehci_id_table[] = {
> > { .compatible = "st,spear600-ehci", },
> > { },
> > };
> > +MODULE_DEVICE_TABLE(spear_ehci_id_table);
>
> Shouldn't this be MODULE_DEVICE_TABLE(of, spear_ehci_id_table)?
>
> Alan Stern
>
Hi Alan,
Sorry about this. It looks like I accidentally sent a temporary version of
patch 1/4 and 3/4.
Sending the final and correct version now.
Thanks for the review,
Luis
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-18 19:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-18 18:21 [PATCH 1/4] usb: host: ehci-spear: Fix module autoload for OF platform driver Luis de Bethencourt
2015-09-18 18:57 ` Alan Stern
2015-09-18 19:09 ` Luis de Bethencourt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®