* [PATCH 2/2] drm/vmwgfx: Fix uninitialized return in vmw_kms_helper_dirty()
@ 2015-09-18 22:32 Christian Engelmayer
2015-09-18 22:42 ` Sinclair Yeh
0 siblings, 1 reply; 2+ messages in thread
From: Christian Engelmayer @ 2015-09-18 22:32 UTC (permalink / raw)
To: airlied
Cc: thellstrom, syeh, daniel.vetter, jakob, dri-devel, linux-kernel,
Christian Engelmayer
Function vmw_kms_helper_dirty() uses the uninitialized variable ret as
return value. Make the result deterministic and directly return as the
variable is unused anyway. Detected by Coverity CID 1324255.
Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
---
Compile tested only. Applies against linux-next.
---
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
index 61fb7f3de311..15a6c01cd016 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
@@ -1685,7 +1685,6 @@ int vmw_kms_helper_dirty(struct vmw_private *dev_priv,
struct drm_crtc *crtc;
u32 num_units = 0;
u32 i, k;
- int ret;
dirty->dev_priv = dev_priv;
@@ -1711,7 +1710,7 @@ int vmw_kms_helper_dirty(struct vmw_private *dev_priv,
if (!dirty->cmd) {
DRM_ERROR("Couldn't reserve fifo space "
"for dirty blits.\n");
- return ret;
+ return -ENOMEM;
}
memset(dirty->cmd, 0, dirty->fifo_reserve_size);
}
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] drm/vmwgfx: Fix uninitialized return in vmw_kms_helper_dirty()
2015-09-18 22:32 [PATCH 2/2] drm/vmwgfx: Fix uninitialized return in vmw_kms_helper_dirty() Christian Engelmayer
@ 2015-09-18 22:42 ` Sinclair Yeh
0 siblings, 0 replies; 2+ messages in thread
From: Sinclair Yeh @ 2015-09-18 22:42 UTC (permalink / raw)
To: Christian Engelmayer
Cc: airlied, thellstrom, daniel.vetter, dri-devel, linux-kernel
Reviewed-by: Sinclair Yeh <syeh@vmware.com>
On Sat, Sep 19, 2015 at 12:32:24AM +0200, Christian Engelmayer wrote:
> Function vmw_kms_helper_dirty() uses the uninitialized variable ret as
> return value. Make the result deterministic and directly return as the
> variable is unused anyway. Detected by Coverity CID 1324255.
>
> Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
> ---
> Compile tested only. Applies against linux-next.
> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
> index 61fb7f3de311..15a6c01cd016 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
> @@ -1685,7 +1685,6 @@ int vmw_kms_helper_dirty(struct vmw_private *dev_priv,
> struct drm_crtc *crtc;
> u32 num_units = 0;
> u32 i, k;
> - int ret;
>
> dirty->dev_priv = dev_priv;
>
> @@ -1711,7 +1710,7 @@ int vmw_kms_helper_dirty(struct vmw_private *dev_priv,
> if (!dirty->cmd) {
> DRM_ERROR("Couldn't reserve fifo space "
> "for dirty blits.\n");
> - return ret;
> + return -ENOMEM;
> }
> memset(dirty->cmd, 0, dirty->fifo_reserve_size);
> }
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-18 22:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-18 22:32 [PATCH 2/2] drm/vmwgfx: Fix uninitialized return in vmw_kms_helper_dirty() Christian Engelmayer
2015-09-18 22:42 ` Sinclair Yeh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®