* [PATCH] sb_edac: Setting fixed DIMM width for Xeon Knights Landing platform.
@ 2015-12-11 13:21 Hubert Chrzaniuk
2015-12-11 15:59 ` Borislav Petkov
0 siblings, 1 reply; 3+ messages in thread
From: Hubert Chrzaniuk @ 2015-12-11 13:21 UTC (permalink / raw)
To: hubert.chrzaniuk, lukasz.anaczkowski, mchehab, dougthompson
Cc: bp, linux-edac, linux-kernel
Knights Landing does not come with register that could be used
to fetch DIMM width. However the value is fixed for this architecture
so it can be hardcoded.
Fixes: d0cdf900314 (sb_edac: Add Knights Landing (Xeon Phi gen 2) support)
Signed-off-by: Hubert Chrzaniuk <hubert.chrzaniuk@intel.com>
---
drivers/edac/sb_edac.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c
index 9c0424d..6ea9b1f 100644
--- a/drivers/edac/sb_edac.c
+++ b/drivers/edac/sb_edac.c
@@ -924,6 +924,12 @@ out:
return mtype;
}
+static enum dev_type knl_get_width(struct sbridge_pvt *pvt, u32 mtr)
+{
+ /* for KNL value is fixed */
+ return DEV_X16;
+}
+
static enum dev_type sbridge_get_width(struct sbridge_pvt *pvt, u32 mtr)
{
/* there's no way to figure out */
@@ -3370,7 +3376,7 @@ static int sbridge_register_mci(struct sbridge_dev *sbridge_dev, enum type type)
pvt->info.interleave_list = knl_interleave_list;
pvt->info.max_interleave = ARRAY_SIZE(knl_interleave_list);
pvt->info.interleave_pkg = ibridge_interleave_pkg;
- pvt->info.get_width = ibridge_get_width;
+ pvt->info.get_width = knl_get_width;
mci->ctl_name = kasprintf(GFP_KERNEL,
"Knights Landing Socket#%d", mci->mc_idx);
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sb_edac: Setting fixed DIMM width for Xeon Knights Landing platform.
2015-12-11 13:21 [PATCH] sb_edac: Setting fixed DIMM width for Xeon Knights Landing platform Hubert Chrzaniuk
@ 2015-12-11 15:59 ` Borislav Petkov
0 siblings, 0 replies; 3+ messages in thread
From: Borislav Petkov @ 2015-12-11 15:59 UTC (permalink / raw)
To: Hubert Chrzaniuk
Cc: lukasz.anaczkowski, mchehab, dougthompson, linux-edac, linux-kernel
On Fri, Dec 11, 2015 at 02:21:22PM +0100, Hubert Chrzaniuk wrote:
> Knights Landing does not come with register that could be used
> to fetch DIMM width. However the value is fixed for this architecture
> so it can be hardcoded.
>
> Fixes: d0cdf900314 (sb_edac: Add Knights Landing (Xeon Phi gen 2) support)
> Signed-off-by: Hubert Chrzaniuk <hubert.chrzaniuk@intel.com>
> ---
> drivers/edac/sb_edac.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
Applied, thanks.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] sb_edac: Setting fixed DIMM width for Xeon Knights Landing platform.
@ 2015-12-11 13:16 Hubert Chrzaniuk
0 siblings, 0 replies; 3+ messages in thread
From: Hubert Chrzaniuk @ 2015-12-11 13:16 UTC (permalink / raw)
To: hubert.chrzaniuk, lukasz.anaczkowski, mchehab, dougthompson
Cc: linux-edac, linux-kernel
Knights Landing does not come with register that could be used
to fetch DIMM width. However the value is fixed for this architecture
so it can be hardcoded.
Fixes: d0cdf900314 (sb_edac: Add Knights Landing (Xeon Phi gen 2) support)
Signed-off-by: Hubert Chrzaniuk <hubert.chrzaniuk@intel.com>
---
drivers/edac/sb_edac.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c
index 9c0424d..6ea9b1f 100644
--- a/drivers/edac/sb_edac.c
+++ b/drivers/edac/sb_edac.c
@@ -924,6 +924,12 @@ out:
return mtype;
}
+static enum dev_type knl_get_width(struct sbridge_pvt *pvt, u32 mtr)
+{
+ /* for KNL value is fixed */
+ return DEV_X16;
+}
+
static enum dev_type sbridge_get_width(struct sbridge_pvt *pvt, u32 mtr)
{
/* there's no way to figure out */
@@ -3370,7 +3376,7 @@ static int sbridge_register_mci(struct sbridge_dev *sbridge_dev, enum type type)
pvt->info.interleave_list = knl_interleave_list;
pvt->info.max_interleave = ARRAY_SIZE(knl_interleave_list);
pvt->info.interleave_pkg = ibridge_interleave_pkg;
- pvt->info.get_width = ibridge_get_width;
+ pvt->info.get_width = knl_get_width;
mci->ctl_name = kasprintf(GFP_KERNEL,
"Knights Landing Socket#%d", mci->mc_idx);
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-11 15:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-11 13:21 [PATCH] sb_edac: Setting fixed DIMM width for Xeon Knights Landing platform Hubert Chrzaniuk
2015-12-11 15:59 ` Borislav Petkov
-- strict thread matches above, loose matches on Subject: below --
2015-12-11 13:16 Hubert Chrzaniuk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®