mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
	x86@kernel.org, Borislav Petkov <bp@alien8.de>,
	Stephane Eranian <eranian@google.com>,
	Harish Chegondi <harish.chegondi@intel.com>,
	Kan Liang <kan.liang@intel.com>,
	Andi Kleen <andi.kleen@intel.com>,
	Jacob Pan <jacob.jun.pan@linux.intel.com>
Subject: [patch V2 13/28] x86/perf/intel_uncore: Clear all hardware state on exit
Date: Mon, 22 Feb 2016 11:06:52 -0000	[thread overview]
Message-ID: <20160222110441.279798424@linutronix.de> (raw)
In-Reply-To: <20160222110337.198341739@linutronix.de>

[-- Attachment #1: x86-perf-intel_uncore--Clear-all-hardware-state-on-exit.patch --]
[-- Type: text/plain, Size: 1597 bytes --]

The only missing bit is to completely clear the hardware state on failure
exit. This is now a pretty simple exercise.

Undo the box->init_box() setup on all packages which have been initialized so
far.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 arch/x86/kernel/cpu/perf_event_intel_uncore.c |   26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

Index: b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
===================================================================
--- a/arch/x86/kernel/cpu/perf_event_intel_uncore.c
+++ b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
@@ -754,6 +754,30 @@ static void uncore_pmu_unregister(struct
 	pmu->registered = false;
 }
 
+static void __init __uncore_exit_boxes(struct intel_uncore_type *type, int cpu)
+{
+	struct intel_uncore_pmu *pmu = type->pmus;
+	struct intel_uncore_box *box;
+	int i, pkg;
+
+	if (pmu) {
+		pkg = topology_physical_package_id(cpu);
+		for (i = 0; i < type->num_boxes; i++, pmu++) {
+			box = pmu->boxes[pkg];
+			if (box)
+				uncore_box_exit(box);
+		}
+	}
+}
+
+static void __init uncore_exit_boxes(void *dummy)
+{
+	struct intel_uncore_type **types = uncore_msr_uncores;
+
+	while (*types)
+		__uncore_exit_boxes(*types++, smp_processor_id());
+}
+
 static void uncore_free_boxes(struct intel_uncore_pmu *pmu)
 {
 	int pkg;
@@ -1371,6 +1395,8 @@ static int __init intel_uncore_init(void
 	return 0;
 
 err:
+	/* Undo box->init_box() */
+	on_each_cpu_mask(&uncore_cpu_mask, uncore_exit_boxes, NULL, 1);
 	uncore_types_exit(uncore_msr_uncores);
 	uncore_pci_exit();
 	cpu_notifier_register_done();

  parent reply	other threads:[~2016-02-22 11:14 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-22 11:06 [patch V2 00/28] x86/perf/intel/uncore|rapl: Fix error handling and sanitize pmu management Thomas Gleixner
2016-02-22 11:06 ` [patch V2 01/28] x86/perf/intel/uncore: Remove pointless mask check Thomas Gleixner
2016-02-22 11:06 ` [patch V2 02/28] x86/perf/intel/uncore: Simplify error rollback Thomas Gleixner
2016-02-22 11:06 ` [patch V2 03/28] x86/perf/intel/uncore: Fix error handling Thomas Gleixner
2016-02-22 11:06 ` [patch V2 04/28] x86/perf/intel/uncore: Add sanity checks for pci dev package id Thomas Gleixner
2016-02-22 11:06 ` [patch V2 05/28] x86/perf/intel_uncore: Cleanup hardware on exit Thomas Gleixner
2016-02-22 11:06 ` [patch V2 07/28] x86/perf/intel_uncore: Make code readable Thomas Gleixner
2016-02-22 11:06 ` [patch V2 06/28] x86/perf/intel/uncore: Drop pointless hotplug priority Thomas Gleixner
2016-02-22 11:06 ` [patch V2 08/28] x86/perf/uncore: Make uncore_pcibus_to_physid static Thomas Gleixner
2016-02-22 11:06 ` [patch V2 09/28] perf: Allow storage of pmu private data in event Thomas Gleixner
2016-02-22 11:06 ` [patch V2 11/28] x86/topology: Create logical package id Thomas Gleixner
2016-02-22 18:54   ` Andi Kleen
2016-02-22 19:05     ` Thomas Gleixner
2016-02-22 11:06 ` [patch V2 10/28] x86/perf/intel_uncore: Store box in event->pmu_private Thomas Gleixner
2016-02-22 11:45   ` Peter Zijlstra
2016-02-22 11:58     ` Thomas Gleixner
2016-02-22 11:52   ` Peter Zijlstra
2016-02-22 12:00     ` Thomas Gleixner
2016-02-22 11:06 ` [patch V2 12/28] x86/perf/uncore: Track packages not per cpu data Thomas Gleixner
2016-02-22 11:06 ` Thomas Gleixner [this message]
2016-02-22 11:58   ` [patch V2 13/28] x86/perf/intel_uncore: Clear all hardware state on exit Peter Zijlstra
2016-02-22 11:59     ` Thomas Gleixner
2016-02-22 11:06 ` [patch V2 15/28] cpumask: Export cpumask_any_but Thomas Gleixner
2016-02-22 11:06 ` [patch V2 14/28] x86/perf/intel_uncore: Make PCI and MSR uncore independent Thomas Gleixner
2016-02-22 11:06 ` [patch V2 16/28] x86/perf/intel_uncore: Make it modular Thomas Gleixner
2016-02-22 11:06 ` [patch V2 17/28] x86/perf/cqm: Get rid of the silly for_each_cpu lookups Thomas Gleixner
2016-02-22 11:06 ` [patch V2 18/28] x86/perf/intel_rapl: Make Knights Landings support functional Thomas Gleixner
2016-02-22 20:38   ` Borislav Petkov
2016-02-22 11:06 ` [patch V2 19/28] x86/perf/intel/rapl: Add proper error handling Thomas Gleixner
2016-02-22 11:06 ` [patch V2 20/28] x86/perf/intel/rapl: Sanitize the quirk handling Thomas Gleixner
2016-02-22 11:06 ` [patch V2 21/28] x86/perf/intel/rapl: Calculate timing once Thomas Gleixner
2016-02-22 11:06 ` [patch V2 22/28] x86/perf/intel/rapl: Cleanup the printk output Thomas Gleixner
2016-02-22 18:44   ` Andi Kleen
2016-02-22 18:58     ` Thomas Gleixner
2016-02-22 11:06 ` [patch V2 23/28] x86/perf/intel/rapl: Refactor code some more Thomas Gleixner
2016-02-22 11:07 ` [patch V2 24/28] x86/perf/intel/rapl: Make pmu lock raw Thomas Gleixner
2016-02-22 11:07 ` [patch V2 25/28] x86/perf/intel/rapl: Utilize event->pmu_private Thomas Gleixner
2016-02-22 11:07 ` [patch V2 26/28] x86/perf/intel/rapl: Convert it to a per package facility Thomas Gleixner
2016-02-22 12:08   ` Peter Zijlstra
2016-02-22 15:52     ` Thomas Gleixner
2016-02-22 16:04       ` Peter Zijlstra
2016-02-22 11:07 ` [patch V2 28/28] x86/perf/intel/rapl: Make it modular Thomas Gleixner
2016-02-22 18:40   ` Andi Kleen
2016-02-22 19:11     ` Thomas Gleixner
2016-02-22 11:07 ` [patch V2 27/28] perf: Export perf_event_sysfs_show Thomas Gleixner
2016-02-22 12:09   ` Peter Zijlstra
2016-02-22 18:55 ` [patch V2 00/28] x86/perf/intel/uncore|rapl: Fix error handling and sanitize pmu management Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160222110441.279798424@linutronix.de \
    --to=tglx@linutronix.de \
    --cc=andi.kleen@intel.com \
    --cc=bp@alien8.de \
    --cc=eranian@google.com \
    --cc=harish.chegondi@intel.com \
    --cc=jacob.jun.pan@linux.intel.com \
    --cc=kan.liang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®