mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
	x86@kernel.org, Borislav Petkov <bp@alien8.de>,
	Stephane Eranian <eranian@google.com>,
	Harish Chegondi <harish.chegondi@intel.com>,
	Kan Liang <kan.liang@intel.com>,
	Andi Kleen <andi.kleen@intel.com>,
	Jacob Pan <jacob.jun.pan@linux.intel.com>
Subject: [patch V2 24/28] x86/perf/intel/rapl: Make pmu lock raw
Date: Mon, 22 Feb 2016 11:07:00 -0000	[thread overview]
Message-ID: <20160222110442.255905468@linutronix.de> (raw)
In-Reply-To: <20160222110337.198341739@linutronix.de>

[-- Attachment #1: x86-perf-intel-rapl--Make-pmu-lock-raw.patch --]
[-- Type: text/plain, Size: 2862 bytes --]

This lock is taken in hard interrupt context even on Preempt-RT. Make it raw
so RT does not have to patch it.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 arch/x86/kernel/cpu/perf_event_intel_rapl.c |   20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

Index: b/arch/x86/kernel/cpu/perf_event_intel_rapl.c
===================================================================
--- a/arch/x86/kernel/cpu/perf_event_intel_rapl.c
+++ b/arch/x86/kernel/cpu/perf_event_intel_rapl.c
@@ -120,7 +120,7 @@ static struct perf_pmu_events_attr event
 };
 
 struct rapl_pmu {
-	spinlock_t		lock;
+	raw_spinlock_t		lock;
 	int			n_active;
 	struct list_head	active_list;
 	struct pmu		*pmu;
@@ -210,12 +210,12 @@ static enum hrtimer_restart rapl_hrtimer
 	if (!pmu->n_active)
 		return HRTIMER_NORESTART;
 
-	spin_lock_irqsave(&pmu->lock, flags);
+	raw_spin_lock_irqsave(&pmu->lock, flags);
 
 	list_for_each_entry(event, &pmu->active_list, active_entry)
 		rapl_event_update(event);
 
-	spin_unlock_irqrestore(&pmu->lock, flags);
+	raw_spin_unlock_irqrestore(&pmu->lock, flags);
 
 	hrtimer_forward_now(hrtimer, pmu->timer_interval);
 
@@ -252,9 +252,9 @@ static void rapl_pmu_event_start(struct
 	struct rapl_pmu *pmu = __this_cpu_read(rapl_pmu);
 	unsigned long flags;
 
-	spin_lock_irqsave(&pmu->lock, flags);
+	raw_spin_lock_irqsave(&pmu->lock, flags);
 	__rapl_pmu_event_start(pmu, event);
-	spin_unlock_irqrestore(&pmu->lock, flags);
+	raw_spin_unlock_irqrestore(&pmu->lock, flags);
 }
 
 static void rapl_pmu_event_stop(struct perf_event *event, int mode)
@@ -263,7 +263,7 @@ static void rapl_pmu_event_stop(struct p
 	struct hw_perf_event *hwc = &event->hw;
 	unsigned long flags;
 
-	spin_lock_irqsave(&pmu->lock, flags);
+	raw_spin_lock_irqsave(&pmu->lock, flags);
 
 	/* mark event as deactivated and stopped */
 	if (!(hwc->state & PERF_HES_STOPPED)) {
@@ -288,7 +288,7 @@ static void rapl_pmu_event_stop(struct p
 		hwc->state |= PERF_HES_UPTODATE;
 	}
 
-	spin_unlock_irqrestore(&pmu->lock, flags);
+	raw_spin_unlock_irqrestore(&pmu->lock, flags);
 }
 
 static int rapl_pmu_event_add(struct perf_event *event, int mode)
@@ -297,14 +297,14 @@ static int rapl_pmu_event_add(struct per
 	struct hw_perf_event *hwc = &event->hw;
 	unsigned long flags;
 
-	spin_lock_irqsave(&pmu->lock, flags);
+	raw_spin_lock_irqsave(&pmu->lock, flags);
 
 	hwc->state = PERF_HES_UPTODATE | PERF_HES_STOPPED;
 
 	if (mode & PERF_EF_START)
 		__rapl_pmu_event_start(pmu, event);
 
-	spin_unlock_irqrestore(&pmu->lock, flags);
+	raw_spin_unlock_irqrestore(&pmu->lock, flags);
 
 	return 0;
 }
@@ -567,7 +567,7 @@ static int rapl_cpu_prepare(int cpu)
 	pmu = kzalloc_node(sizeof(*pmu), GFP_KERNEL, cpu_to_node(cpu));
 	if (!pmu)
 		return -1;
-	spin_lock_init(&pmu->lock);
+	raw_spin_lock_init(&pmu->lock);
 
 	INIT_LIST_HEAD(&pmu->active_list);
 

  parent reply	other threads:[~2016-02-22 11:10 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-22 11:06 [patch V2 00/28] x86/perf/intel/uncore|rapl: Fix error handling and sanitize pmu management Thomas Gleixner
2016-02-22 11:06 ` [patch V2 01/28] x86/perf/intel/uncore: Remove pointless mask check Thomas Gleixner
2016-02-22 11:06 ` [patch V2 03/28] x86/perf/intel/uncore: Fix error handling Thomas Gleixner
2016-02-22 11:06 ` [patch V2 02/28] x86/perf/intel/uncore: Simplify error rollback Thomas Gleixner
2016-02-22 11:06 ` [patch V2 04/28] x86/perf/intel/uncore: Add sanity checks for pci dev package id Thomas Gleixner
2016-02-22 11:06 ` [patch V2 05/28] x86/perf/intel_uncore: Cleanup hardware on exit Thomas Gleixner
2016-02-22 11:06 ` [patch V2 07/28] x86/perf/intel_uncore: Make code readable Thomas Gleixner
2016-02-22 11:06 ` [patch V2 06/28] x86/perf/intel/uncore: Drop pointless hotplug priority Thomas Gleixner
2016-02-22 11:06 ` [patch V2 08/28] x86/perf/uncore: Make uncore_pcibus_to_physid static Thomas Gleixner
2016-02-22 11:06 ` [patch V2 09/28] perf: Allow storage of pmu private data in event Thomas Gleixner
2016-02-22 11:06 ` [patch V2 11/28] x86/topology: Create logical package id Thomas Gleixner
2016-02-22 18:54   ` Andi Kleen
2016-02-22 19:05     ` Thomas Gleixner
2016-02-22 11:06 ` [patch V2 10/28] x86/perf/intel_uncore: Store box in event->pmu_private Thomas Gleixner
2016-02-22 11:45   ` Peter Zijlstra
2016-02-22 11:58     ` Thomas Gleixner
2016-02-22 11:52   ` Peter Zijlstra
2016-02-22 12:00     ` Thomas Gleixner
2016-02-22 11:06 ` [patch V2 12/28] x86/perf/uncore: Track packages not per cpu data Thomas Gleixner
2016-02-22 11:06 ` [patch V2 13/28] x86/perf/intel_uncore: Clear all hardware state on exit Thomas Gleixner
2016-02-22 11:58   ` Peter Zijlstra
2016-02-22 11:59     ` Thomas Gleixner
2016-02-22 11:06 ` [patch V2 14/28] x86/perf/intel_uncore: Make PCI and MSR uncore independent Thomas Gleixner
2016-02-22 11:06 ` [patch V2 15/28] cpumask: Export cpumask_any_but Thomas Gleixner
2016-02-22 11:06 ` [patch V2 16/28] x86/perf/intel_uncore: Make it modular Thomas Gleixner
2016-02-22 11:06 ` [patch V2 17/28] x86/perf/cqm: Get rid of the silly for_each_cpu lookups Thomas Gleixner
2016-02-22 11:06 ` [patch V2 19/28] x86/perf/intel/rapl: Add proper error handling Thomas Gleixner
2016-02-22 11:06 ` [patch V2 18/28] x86/perf/intel_rapl: Make Knights Landings support functional Thomas Gleixner
2016-02-22 20:38   ` Borislav Petkov
2016-02-22 11:06 ` [patch V2 20/28] x86/perf/intel/rapl: Sanitize the quirk handling Thomas Gleixner
2016-02-22 11:06 ` [patch V2 21/28] x86/perf/intel/rapl: Calculate timing once Thomas Gleixner
2016-02-22 11:06 ` [patch V2 22/28] x86/perf/intel/rapl: Cleanup the printk output Thomas Gleixner
2016-02-22 18:44   ` Andi Kleen
2016-02-22 18:58     ` Thomas Gleixner
2016-02-22 11:06 ` [patch V2 23/28] x86/perf/intel/rapl: Refactor code some more Thomas Gleixner
2016-02-22 11:07 ` Thomas Gleixner [this message]
2016-02-22 11:07 ` [patch V2 25/28] x86/perf/intel/rapl: Utilize event->pmu_private Thomas Gleixner
2016-02-22 11:07 ` [patch V2 26/28] x86/perf/intel/rapl: Convert it to a per package facility Thomas Gleixner
2016-02-22 12:08   ` Peter Zijlstra
2016-02-22 15:52     ` Thomas Gleixner
2016-02-22 16:04       ` Peter Zijlstra
2016-02-22 11:07 ` [patch V2 27/28] perf: Export perf_event_sysfs_show Thomas Gleixner
2016-02-22 12:09   ` Peter Zijlstra
2016-02-22 11:07 ` [patch V2 28/28] x86/perf/intel/rapl: Make it modular Thomas Gleixner
2016-02-22 18:40   ` Andi Kleen
2016-02-22 19:11     ` Thomas Gleixner
2016-02-22 18:55 ` [patch V2 00/28] x86/perf/intel/uncore|rapl: Fix error handling and sanitize pmu management Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160222110442.255905468@linutronix.de \
    --to=tglx@linutronix.de \
    --cc=andi.kleen@intel.com \
    --cc=bp@alien8.de \
    --cc=eranian@google.com \
    --cc=harish.chegondi@intel.com \
    --cc=jacob.jun.pan@linux.intel.com \
    --cc=kan.liang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®