From: Borislav Petkov <bp@alien8.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
x86@kernel.org, Stephane Eranian <eranian@google.com>,
Harish Chegondi <harish.chegondi@intel.com>,
Kan Liang <kan.liang@intel.com>,
Andi Kleen <andi.kleen@intel.com>,
Jacob Pan <jacob.jun.pan@linux.intel.com>,
Dasaratharaman Chandramouli
<dasaratharaman.chandramouli@intel.com>
Subject: Re: [patch V2 18/28] x86/perf/intel_rapl: Make Knights Landings support functional
Date: Mon, 22 Feb 2016 21:38:50 +0100 [thread overview]
Message-ID: <20160222203850.GG17895@pd.tnic> (raw)
In-Reply-To: <20160222110441.725652272@linutronix.de>
On Mon, Feb 22, 2016 at 11:06:56AM -0000, Thomas Gleixner wrote:
> The Knights Landings support added the events and the detection case, but then
> returns 0 without actually initializing the driver.
>
> Fixes: 3a2a7797326a4 "perf/x86/intel/rapl: Add support for Knights Landing (KNL)"
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com>
> ---
> arch/x86/kernel/cpu/perf_event_intel_rapl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: b/arch/x86/kernel/cpu/perf_event_intel_rapl.c
> ===================================================================
> --- a/arch/x86/kernel/cpu/perf_event_intel_rapl.c
> +++ b/arch/x86/kernel/cpu/perf_event_intel_rapl.c
> @@ -731,7 +731,7 @@ static int __init rapl_pmu_init(void)
> rapl_add_quirk(rapl_hsw_server_quirk);
> rapl_cntr_mask = RAPL_IDX_KNL;
> rapl_pmu_events_group.attrs = rapl_events_knl_attr;
> -
> + break;
> default:
> /* unsupported */
> return 0;
Cc: <stable@vger.kernel.org> # 4.3
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
next prev parent reply other threads:[~2016-02-22 20:39 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 11:06 [patch V2 00/28] x86/perf/intel/uncore|rapl: Fix error handling and sanitize pmu management Thomas Gleixner
2016-02-22 11:06 ` [patch V2 01/28] x86/perf/intel/uncore: Remove pointless mask check Thomas Gleixner
2016-02-22 11:06 ` [patch V2 03/28] x86/perf/intel/uncore: Fix error handling Thomas Gleixner
2016-02-22 11:06 ` [patch V2 02/28] x86/perf/intel/uncore: Simplify error rollback Thomas Gleixner
2016-02-22 11:06 ` [patch V2 04/28] x86/perf/intel/uncore: Add sanity checks for pci dev package id Thomas Gleixner
2016-02-22 11:06 ` [patch V2 05/28] x86/perf/intel_uncore: Cleanup hardware on exit Thomas Gleixner
2016-02-22 11:06 ` [patch V2 07/28] x86/perf/intel_uncore: Make code readable Thomas Gleixner
2016-02-22 11:06 ` [patch V2 06/28] x86/perf/intel/uncore: Drop pointless hotplug priority Thomas Gleixner
2016-02-22 11:06 ` [patch V2 08/28] x86/perf/uncore: Make uncore_pcibus_to_physid static Thomas Gleixner
2016-02-22 11:06 ` [patch V2 09/28] perf: Allow storage of pmu private data in event Thomas Gleixner
2016-02-22 11:06 ` [patch V2 11/28] x86/topology: Create logical package id Thomas Gleixner
2016-02-22 18:54 ` Andi Kleen
2016-02-22 19:05 ` Thomas Gleixner
2016-02-22 11:06 ` [patch V2 10/28] x86/perf/intel_uncore: Store box in event->pmu_private Thomas Gleixner
2016-02-22 11:45 ` Peter Zijlstra
2016-02-22 11:58 ` Thomas Gleixner
2016-02-22 11:52 ` Peter Zijlstra
2016-02-22 12:00 ` Thomas Gleixner
2016-02-22 11:06 ` [patch V2 12/28] x86/perf/uncore: Track packages not per cpu data Thomas Gleixner
2016-02-22 11:06 ` [patch V2 13/28] x86/perf/intel_uncore: Clear all hardware state on exit Thomas Gleixner
2016-02-22 11:58 ` Peter Zijlstra
2016-02-22 11:59 ` Thomas Gleixner
2016-02-22 11:06 ` [patch V2 14/28] x86/perf/intel_uncore: Make PCI and MSR uncore independent Thomas Gleixner
2016-02-22 11:06 ` [patch V2 15/28] cpumask: Export cpumask_any_but Thomas Gleixner
2016-02-22 11:06 ` [patch V2 16/28] x86/perf/intel_uncore: Make it modular Thomas Gleixner
2016-02-22 11:06 ` [patch V2 17/28] x86/perf/cqm: Get rid of the silly for_each_cpu lookups Thomas Gleixner
2016-02-22 11:06 ` [patch V2 19/28] x86/perf/intel/rapl: Add proper error handling Thomas Gleixner
2016-02-22 11:06 ` [patch V2 18/28] x86/perf/intel_rapl: Make Knights Landings support functional Thomas Gleixner
2016-02-22 20:38 ` Borislav Petkov [this message]
2016-02-22 11:06 ` [patch V2 20/28] x86/perf/intel/rapl: Sanitize the quirk handling Thomas Gleixner
2016-02-22 11:06 ` [patch V2 21/28] x86/perf/intel/rapl: Calculate timing once Thomas Gleixner
2016-02-22 11:06 ` [patch V2 22/28] x86/perf/intel/rapl: Cleanup the printk output Thomas Gleixner
2016-02-22 18:44 ` Andi Kleen
2016-02-22 18:58 ` Thomas Gleixner
2016-02-22 11:06 ` [patch V2 23/28] x86/perf/intel/rapl: Refactor code some more Thomas Gleixner
2016-02-22 11:07 ` [patch V2 24/28] x86/perf/intel/rapl: Make pmu lock raw Thomas Gleixner
2016-02-22 11:07 ` [patch V2 25/28] x86/perf/intel/rapl: Utilize event->pmu_private Thomas Gleixner
2016-02-22 11:07 ` [patch V2 26/28] x86/perf/intel/rapl: Convert it to a per package facility Thomas Gleixner
2016-02-22 12:08 ` Peter Zijlstra
2016-02-22 15:52 ` Thomas Gleixner
2016-02-22 16:04 ` Peter Zijlstra
2016-02-22 11:07 ` [patch V2 27/28] perf: Export perf_event_sysfs_show Thomas Gleixner
2016-02-22 12:09 ` Peter Zijlstra
2016-02-22 11:07 ` [patch V2 28/28] x86/perf/intel/rapl: Make it modular Thomas Gleixner
2016-02-22 18:40 ` Andi Kleen
2016-02-22 19:11 ` Thomas Gleixner
2016-02-22 18:55 ` [patch V2 00/28] x86/perf/intel/uncore|rapl: Fix error handling and sanitize pmu management Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160222203850.GG17895@pd.tnic \
--to=bp@alien8.de \
--cc=andi.kleen@intel.com \
--cc=dasaratharaman.chandramouli@intel.com \
--cc=eranian@google.com \
--cc=harish.chegondi@intel.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®