* [PATCH] Staging: comedi: quatech_daqp_cs.c: Fix a unsigned warning issue
@ 2016-05-17 16:53 Amit Ghadge
2016-05-18 8:57 ` Ian Abbott
2016-06-18 3:56 ` Greg KH
0 siblings, 2 replies; 3+ messages in thread
From: Amit Ghadge @ 2016-05-17 16:53 UTC (permalink / raw)
To: abbotti; +Cc: gregkh, devel, linux-kernel, Amit Ghadge
This is a patch to the quatech_daqp_cs.c file that fixes by using
unsigned int instead of unsigned, following warning found by checkpatch.
* WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
Signed-off-by: Amit Ghadge <amitg.b14@gmail.com>
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
index e9e4313..802f51e 100644
--- a/drivers/staging/comedi/drivers/quatech_daqp_cs.c
+++ b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
@@ -643,7 +643,7 @@ static int daqp_ao_insn_write(struct comedi_device *dev,
outb(0, dev->iobase + DAQP_AUX_REG);
for (i = 0; i > insn->n; i++) {
- unsigned val = data[i];
+ unsigned int val = data[i];
int ret;
/* D/A transfer rate is about 8ms */
--
2.5.5
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: comedi: quatech_daqp_cs.c: Fix a unsigned warning issue
2016-05-17 16:53 [PATCH] Staging: comedi: quatech_daqp_cs.c: Fix a unsigned warning issue Amit Ghadge
@ 2016-05-18 8:57 ` Ian Abbott
2016-06-18 3:56 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Ian Abbott @ 2016-05-18 8:57 UTC (permalink / raw)
To: Amit Ghadge; +Cc: gregkh, devel, linux-kernel
On 17/05/16 17:53, Amit Ghadge wrote:
> This is a patch to the quatech_daqp_cs.c file that fixes by using
> unsigned int instead of unsigned, following warning found by checkpatch.
> * WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
>
> Signed-off-by: Amit Ghadge <amitg.b14@gmail.com>
> ---
> drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> index e9e4313..802f51e 100644
> --- a/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> +++ b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> @@ -643,7 +643,7 @@ static int daqp_ao_insn_write(struct comedi_device *dev,
> outb(0, dev->iobase + DAQP_AUX_REG);
>
> for (i = 0; i > insn->n; i++) {
> - unsigned val = data[i];
> + unsigned int val = data[i];
> int ret;
>
> /* D/A transfer rate is about 8ms */
>
Thanks!
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: comedi: quatech_daqp_cs.c: Fix a unsigned warning issue
2016-05-17 16:53 [PATCH] Staging: comedi: quatech_daqp_cs.c: Fix a unsigned warning issue Amit Ghadge
2016-05-18 8:57 ` Ian Abbott
@ 2016-06-18 3:56 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2016-06-18 3:56 UTC (permalink / raw)
To: Amit Ghadge; +Cc: abbotti, devel, linux-kernel
On Tue, May 17, 2016 at 10:23:44PM +0530, Amit Ghadge wrote:
> This is a patch to the quatech_daqp_cs.c file that fixes by using
> unsigned int instead of unsigned, following warning found by checkpatch.
> * WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
>
> Signed-off-by: Amit Ghadge <amitg.b14@gmail.com>
> Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
> ---
> drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Someone sent in this change before you did, sorry :(
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-18 3:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-17 16:53 [PATCH] Staging: comedi: quatech_daqp_cs.c: Fix a unsigned warning issue Amit Ghadge
2016-05-18 8:57 ` Ian Abbott
2016-06-18 3:56 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®