mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: Baole Ni <baolex.ni@intel.com>,
	linux-kernel@vger.kernel.org, chuansheng.liu@intel.com
Subject: Re: [PATCH 0269/1285] Replace numeric parameter like 0444 with macro
Date: Tue, 2 Aug 2016 15:30:06 -0400	[thread overview]
Message-ID: <20160802193006.GB6066@home.goodmis.org> (raw)
In-Reply-To: <fd5c7644-7dcc-0cca-d38b-2379bca04dff@sandisk.com>

[ removed most the Cc list ]

On Tue, Aug 02, 2016 at 08:14:10AM -0700, Bart Van Assche wrote:
> 
> Hello Baole,
> 
> Please change 0444 into S_IRUGO and 0644 into S_IRUGO | S_IWUSR. The latter
> form is more compact and hence makes the code easier to read.
> 

FYI, Linus already NACKed the entire thread.

-- Steve

  reply	other threads:[~2016-08-02 19:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-02 10:55 Baole Ni
2016-08-02 15:14 ` Bart Van Assche
2016-08-02 19:30   ` Steven Rostedt [this message]
2016-08-02 20:04     ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160802193006.GB6066@home.goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=baolex.ni@intel.com \
    --cc=bart.vanassche@sandisk.com \
    --cc=chuansheng.liu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®