* [PATCH] staging: android ion/hisi: fix dependencies
@ 2016-09-15 15:57 Arnd Bergmann
2016-09-16 2:10 ` Laura Abbott
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2016-09-15 15:57 UTC (permalink / raw)
To: Laura Abbott, Sumit Semwal
Cc: Arnd Bergmann, Greg Kroah-Hartman, Arve Hjønnevåg,
Riley Andrews, Chen Feng, devel, linux-kernel
The newly added Hi6220 Ion code fails to build when the ION_OF helpers
are not present:
drivers/staging/android/ion/hisilicon/hi6220_ion.o: In function `hi6220_ion_remove':
hi6220_ion.c:(.text.hi6220_ion_remove+0x4c): undefined reference to `ion_destroy_platform_data'
drivers/staging/android/ion/hisilicon/hi6220_ion.o: In function `hi6220_ion_probe':
hi6220_ion.c:(.text.hi6220_ion_probe+0x5c): undefined reference to `ion_parse_dt'
hi6220_ion.c:(.text.hi6220_ion_probe+0xf8): undefined reference to `ion_destroy_platform_data'
This selects the symbol when needed.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 2b40182a19bc ("staging: android: ion: Add ion driver for Hi6220 SoC platform")
---
drivers/staging/android/ion/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/android/ion/Kconfig b/drivers/staging/android/ion/Kconfig
index 94105544feef..c8fb4134c55d 100644
--- a/drivers/staging/android/ion/Kconfig
+++ b/drivers/staging/android/ion/Kconfig
@@ -36,6 +36,7 @@ config ION_TEGRA
config ION_HISI
tristate "Ion for Hisilicon"
depends on ARCH_HISI && ION
+ select ION_OF
help
Choose this option if you wish to use ion on Hisilicon Platform.
--
2.9.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] staging: android ion/hisi: fix dependencies
2016-09-15 15:57 [PATCH] staging: android ion/hisi: fix dependencies Arnd Bergmann
@ 2016-09-16 2:10 ` Laura Abbott
2016-09-16 2:25 ` Sumit Semwal
0 siblings, 1 reply; 3+ messages in thread
From: Laura Abbott @ 2016-09-16 2:10 UTC (permalink / raw)
To: Arnd Bergmann, Sumit Semwal
Cc: Greg Kroah-Hartman, Arve Hjønnevåg, Riley Andrews,
Chen Feng, devel, linux-kernel
On 09/15/2016 08:57 AM, Arnd Bergmann wrote:
> The newly added Hi6220 Ion code fails to build when the ION_OF helpers
> are not present:
>
> drivers/staging/android/ion/hisilicon/hi6220_ion.o: In function `hi6220_ion_remove':
> hi6220_ion.c:(.text.hi6220_ion_remove+0x4c): undefined reference to `ion_destroy_platform_data'
> drivers/staging/android/ion/hisilicon/hi6220_ion.o: In function `hi6220_ion_probe':
> hi6220_ion.c:(.text.hi6220_ion_probe+0x5c): undefined reference to `ion_parse_dt'
> hi6220_ion.c:(.text.hi6220_ion_probe+0xf8): undefined reference to `ion_destroy_platform_data'
>
> This selects the symbol when needed.
>
Acked-by: Laura Abbott <labbott@redhat.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 2b40182a19bc ("staging: android: ion: Add ion driver for Hi6220 SoC platform")
> ---
> drivers/staging/android/ion/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/android/ion/Kconfig b/drivers/staging/android/ion/Kconfig
> index 94105544feef..c8fb4134c55d 100644
> --- a/drivers/staging/android/ion/Kconfig
> +++ b/drivers/staging/android/ion/Kconfig
> @@ -36,6 +36,7 @@ config ION_TEGRA
> config ION_HISI
> tristate "Ion for Hisilicon"
> depends on ARCH_HISI && ION
> + select ION_OF
> help
> Choose this option if you wish to use ion on Hisilicon Platform.
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] staging: android ion/hisi: fix dependencies
2016-09-16 2:10 ` Laura Abbott
@ 2016-09-16 2:25 ` Sumit Semwal
0 siblings, 0 replies; 3+ messages in thread
From: Sumit Semwal @ 2016-09-16 2:25 UTC (permalink / raw)
To: Laura Abbott
Cc: Arnd Bergmann, Greg Kroah-Hartman, Arve Hjønnevåg,
Riley Andrews, Chen Feng, devel, LKML
On 16 September 2016 at 07:40, Laura Abbott <labbott@redhat.com> wrote:
> On 09/15/2016 08:57 AM, Arnd Bergmann wrote:
>>
>> The newly added Hi6220 Ion code fails to build when the ION_OF helpers
>> are not present:
>>
>> drivers/staging/android/ion/hisilicon/hi6220_ion.o: In function
>> `hi6220_ion_remove':
>> hi6220_ion.c:(.text.hi6220_ion_remove+0x4c): undefined reference to
>> `ion_destroy_platform_data'
>> drivers/staging/android/ion/hisilicon/hi6220_ion.o: In function
>> `hi6220_ion_probe':
>> hi6220_ion.c:(.text.hi6220_ion_probe+0x5c): undefined reference to
>> `ion_parse_dt'
>> hi6220_ion.c:(.text.hi6220_ion_probe+0xf8): undefined reference to
>> `ion_destroy_platform_data'
>>
>> This selects the symbol when needed.
>>
>
> Acked-by: Laura Abbott <labbott@redhat.com>
>
Reviewed-by: Sumit Semwal <sumit.semwal@linaro.org>
>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Fixes: 2b40182a19bc ("staging: android: ion: Add ion driver for Hi6220 SoC
>> platform")
>> ---
>> drivers/staging/android/ion/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/staging/android/ion/Kconfig
>> b/drivers/staging/android/ion/Kconfig
>> index 94105544feef..c8fb4134c55d 100644
>> --- a/drivers/staging/android/ion/Kconfig
>> +++ b/drivers/staging/android/ion/Kconfig
>> @@ -36,6 +36,7 @@ config ION_TEGRA
>> config ION_HISI
>> tristate "Ion for Hisilicon"
>> depends on ARCH_HISI && ION
>> + select ION_OF
>> help
>> Choose this option if you wish to use ion on Hisilicon Platform.
>>
>>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-16 2:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-15 15:57 [PATCH] staging: android ion/hisi: fix dependencies Arnd Bergmann
2016-09-16 2:10 ` Laura Abbott
2016-09-16 2:25 ` Sumit Semwal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®