* [PATCH -next] drm: mxsfb: fix error return code in mxsfb_load()
@ 2017-02-05 16:00 Wei Yongjun
2017-02-06 11:48 ` Gustavo Padovan
2017-02-06 18:53 ` Marek Vasut
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2017-02-05 16:00 UTC (permalink / raw)
To: Marek Vasut, David Airlie; +Cc: Wei Yongjun, dri-devel, linux-kernel
From: Wei Yongjun <weiyongjun1@huawei.com>
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/gpu/drm/mxsfb/mxsfb_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
index cdfbe02..28a75cb 100644
--- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
+++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
@@ -221,6 +221,7 @@ static int mxsfb_load(struct drm_device *drm, unsigned long flags)
mxsfb->fbdev = drm_fbdev_cma_init(drm, 32,
drm->mode_config.num_connector);
if (IS_ERR(mxsfb->fbdev)) {
+ ret = PTR_ERR(mxsfb->fbdev);
mxsfb->fbdev = NULL;
dev_err(drm->dev, "Failed to init FB CMA area\n");
goto err_cma;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] drm: mxsfb: fix error return code in mxsfb_load()
2017-02-05 16:00 [PATCH -next] drm: mxsfb: fix error return code in mxsfb_load() Wei Yongjun
@ 2017-02-06 11:48 ` Gustavo Padovan
2017-02-06 18:53 ` Marek Vasut
1 sibling, 0 replies; 3+ messages in thread
From: Gustavo Padovan @ 2017-02-06 11:48 UTC (permalink / raw)
To: Wei Yongjun
Cc: Marek Vasut, David Airlie, Wei Yongjun, linux-kernel, dri-devel
Hi Wei,
2017-02-05 Wei Yongjun <weiyj.lk@gmail.com>:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/gpu/drm/mxsfb/mxsfb_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> index cdfbe02..28a75cb 100644
> --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> @@ -221,6 +221,7 @@ static int mxsfb_load(struct drm_device *drm, unsigned long flags)
> mxsfb->fbdev = drm_fbdev_cma_init(drm, 32,
> drm->mode_config.num_connector);
> if (IS_ERR(mxsfb->fbdev)) {
> + ret = PTR_ERR(mxsfb->fbdev);
> mxsfb->fbdev = NULL;
> dev_err(drm->dev, "Failed to init FB CMA area\n");
> goto err_cma;
Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.com>
Gustavo
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] drm: mxsfb: fix error return code in mxsfb_load()
2017-02-05 16:00 [PATCH -next] drm: mxsfb: fix error return code in mxsfb_load() Wei Yongjun
2017-02-06 11:48 ` Gustavo Padovan
@ 2017-02-06 18:53 ` Marek Vasut
1 sibling, 0 replies; 3+ messages in thread
From: Marek Vasut @ 2017-02-06 18:53 UTC (permalink / raw)
To: Wei Yongjun, David Airlie; +Cc: Wei Yongjun, dri-devel, linux-kernel
On 02/05/2017 05:00 PM, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Marek Vasut <marex@denx.de>
> ---
> drivers/gpu/drm/mxsfb/mxsfb_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> index cdfbe02..28a75cb 100644
> --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> @@ -221,6 +221,7 @@ static int mxsfb_load(struct drm_device *drm, unsigned long flags)
> mxsfb->fbdev = drm_fbdev_cma_init(drm, 32,
> drm->mode_config.num_connector);
> if (IS_ERR(mxsfb->fbdev)) {
> + ret = PTR_ERR(mxsfb->fbdev);
> mxsfb->fbdev = NULL;
> dev_err(drm->dev, "Failed to init FB CMA area\n");
> goto err_cma;
>
>
>
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-06 20:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-05 16:00 [PATCH -next] drm: mxsfb: fix error return code in mxsfb_load() Wei Yongjun
2017-02-06 11:48 ` Gustavo Padovan
2017-02-06 18:53 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®