* [PATCH] usb: typec: include linux/device.h in ucsi.h
@ 2017-06-30 15:46 Arnd Bergmann
2017-06-30 15:53 ` Guenter Roeck
2017-07-03 6:59 ` Heikki Krogerus
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2017-06-30 15:46 UTC (permalink / raw)
To: Heikki Krogerus, Greg Kroah-Hartman, Guenter Roeck
Cc: Arnd Bergmann, linux-usb, linux-kernel
The new driver causes a build failure in some configurations:
In file included from /git/arm-soc/drivers/usb/typec/ucsi/trace.h:9:0,
from /git/arm-soc/drivers/usb/typec/ucsi/trace.c:2:
drivers/usb/typec/ucsi/ucsi.h:331:39: error: 'struct device' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
This includes the required header file.
Fixes: c1b0bc2dabfa ("usb: typec: Add support for UCSI interface")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/usb/typec/ucsi/ucsi.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/typec/ucsi/ucsi.h b/drivers/usb/typec/ucsi/ucsi.h
index 6b0d2f0918c6..8a88f45822e3 100644
--- a/drivers/usb/typec/ucsi/ucsi.h
+++ b/drivers/usb/typec/ucsi/ucsi.h
@@ -3,6 +3,7 @@
#define __DRIVER_USB_TYPEC_UCSI_H
#include <linux/bitops.h>
+#include <linux/device.h>
#include <linux/types.h>
/* -------------------------------------------------------------------------- */
--
2.9.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: typec: include linux/device.h in ucsi.h
2017-06-30 15:46 [PATCH] usb: typec: include linux/device.h in ucsi.h Arnd Bergmann
@ 2017-06-30 15:53 ` Guenter Roeck
2017-07-03 6:59 ` Heikki Krogerus
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2017-06-30 15:53 UTC (permalink / raw)
To: Arnd Bergmann, Heikki Krogerus, Greg Kroah-Hartman
Cc: linux-usb, linux-kernel
On 06/30/2017 08:46 AM, Arnd Bergmann wrote:
> The new driver causes a build failure in some configurations:
>
> In file included from /git/arm-soc/drivers/usb/typec/ucsi/trace.h:9:0,
> from /git/arm-soc/drivers/usb/typec/ucsi/trace.c:2:
> drivers/usb/typec/ucsi/ucsi.h:331:39: error: 'struct device' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
>
> This includes the required header file.
>
> Fixes: c1b0bc2dabfa ("usb: typec: Add support for UCSI interface")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/usb/typec/ucsi/ucsi.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/typec/ucsi/ucsi.h b/drivers/usb/typec/ucsi/ucsi.h
> index 6b0d2f0918c6..8a88f45822e3 100644
> --- a/drivers/usb/typec/ucsi/ucsi.h
> +++ b/drivers/usb/typec/ucsi/ucsi.h
> @@ -3,6 +3,7 @@
> #define __DRIVER_USB_TYPEC_UCSI_H
>
> #include <linux/bitops.h>
> +#include <linux/device.h>
> #include <linux/types.h>
>
> /* -------------------------------------------------------------------------- */
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: typec: include linux/device.h in ucsi.h
2017-06-30 15:46 [PATCH] usb: typec: include linux/device.h in ucsi.h Arnd Bergmann
2017-06-30 15:53 ` Guenter Roeck
@ 2017-07-03 6:59 ` Heikki Krogerus
1 sibling, 0 replies; 3+ messages in thread
From: Heikki Krogerus @ 2017-07-03 6:59 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Greg Kroah-Hartman, Guenter Roeck, linux-usb, linux-kernel
On Fri, Jun 30, 2017 at 05:46:16PM +0200, Arnd Bergmann wrote:
> The new driver causes a build failure in some configurations:
>
> In file included from /git/arm-soc/drivers/usb/typec/ucsi/trace.h:9:0,
> from /git/arm-soc/drivers/usb/typec/ucsi/trace.c:2:
> drivers/usb/typec/ucsi/ucsi.h:331:39: error: 'struct device' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
>
> This includes the required header file.
>
> Fixes: c1b0bc2dabfa ("usb: typec: Add support for UCSI interface")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/ucsi/ucsi.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/typec/ucsi/ucsi.h b/drivers/usb/typec/ucsi/ucsi.h
> index 6b0d2f0918c6..8a88f45822e3 100644
> --- a/drivers/usb/typec/ucsi/ucsi.h
> +++ b/drivers/usb/typec/ucsi/ucsi.h
> @@ -3,6 +3,7 @@
> #define __DRIVER_USB_TYPEC_UCSI_H
>
> #include <linux/bitops.h>
> +#include <linux/device.h>
> #include <linux/types.h>
>
> /* -------------------------------------------------------------------------- */
> --
> 2.9.0
--
heikki
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-03 6:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-30 15:46 [PATCH] usb: typec: include linux/device.h in ucsi.h Arnd Bergmann
2017-06-30 15:53 ` Guenter Roeck
2017-07-03 6:59 ` Heikki Krogerus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®