* [PATCH v2] mfd: Add missing Kconfig dependency for TPS65086
@ 2017-07-17 9:28 Michal Simek
2017-07-18 9:08 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Michal Simek @ 2017-07-17 9:28 UTC (permalink / raw)
To: linux-kernel, monstr; +Cc: Lee Jones
MTF_CORE should be enabled when driver is enabled.
Without this patch you can configure:
CONFIG_MFD_CORE is not set
CONFIG_MFD_TPS65086=y
which ends up with compilation error:
drivers/mfd/tps65086.o: In function `tps65086_probe':
drivers/mfd/tps65086.c:110: undefined reference to
`mfd_add_devices'
drivers/mfd/tps65086.c:110:(.text+0x128): relocation
truncated to fit: R_AARCH64_CALL26 against undefined symbol
`mfd_add_devices'
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
Changes in v2:
- Update commit message based on discussion with Lee Jones
drivers/mfd/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 94ad2c1c3d90..f98b5a6d4da8 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -1294,6 +1294,7 @@ config TPS6507X
config MFD_TPS65086
tristate "TI TPS65086 Power Management Integrated Chips (PMICs)"
+ select MFD_CORE
select REGMAP
select REGMAP_IRQ
select REGMAP_I2C
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] mfd: Add missing Kconfig dependency for TPS65086
2017-07-17 9:28 [PATCH v2] mfd: Add missing Kconfig dependency for TPS65086 Michal Simek
@ 2017-07-18 9:08 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2017-07-18 9:08 UTC (permalink / raw)
To: Michal Simek; +Cc: linux-kernel, monstr
On Mon, 17 Jul 2017, Michal Simek wrote:
> MTF_CORE should be enabled when driver is enabled.
>
> Without this patch you can configure:
> CONFIG_MFD_CORE is not set
> CONFIG_MFD_TPS65086=y
>
> which ends up with compilation error:
> drivers/mfd/tps65086.o: In function `tps65086_probe':
> drivers/mfd/tps65086.c:110: undefined reference to
> `mfd_add_devices'
> drivers/mfd/tps65086.c:110:(.text+0x128): relocation
> truncated to fit: R_AARCH64_CALL26 against undefined symbol
> `mfd_add_devices'
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> Changes in v2:
> - Update commit message based on discussion with Lee Jones
>
> drivers/mfd/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 94ad2c1c3d90..f98b5a6d4da8 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1294,6 +1294,7 @@ config TPS6507X
>
> config MFD_TPS65086
> tristate "TI TPS65086 Power Management Integrated Chips (PMICs)"
> + select MFD_CORE
> select REGMAP
> select REGMAP_IRQ
> select REGMAP_I2C
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-18 9:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-17 9:28 [PATCH v2] mfd: Add missing Kconfig dependency for TPS65086 Michal Simek
2017-07-18 9:08 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®