* Re: [PATCH][next] x86/hyper-v: add missing void return type to hyperv_cleanup declaration [not found] <20170719090859.9248-1-colin.king@canonical.com> @ 2017-07-20 8:52 ` Ingo Molnar 2017-07-20 9:15 ` Greg Kroah-Hartman 0 siblings, 1 reply; 3+ messages in thread From: Ingo Molnar @ 2017-07-20 8:52 UTC (permalink / raw) To: Colin King, Greg Kroah-Hartman Cc: Vitaly Kuznetsov, K . Y . Srinivasan, Haiyang Zhang, Stephen Hemminger, Thomas Gleixner, Ingo Molnar, H . Peter Anvin, x86, kernel-janitors, linux-kernel * Colin King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > Add in missing void return type, fixes sparse warning: > "warning: 'hyperv_cleanup()' has implicit return type" > > Fixes: 2e252fbf777d ("x86/hyper-v: include hyperv/ only when CONFIG_HYPERV is set") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > arch/x86/include/asm/mshyperv.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyperv.h > index 01b9c0fb3aab..41fae263f8fa 100644 > --- a/arch/x86/include/asm/mshyperv.h > +++ b/arch/x86/include/asm/mshyperv.h > @@ -178,7 +178,7 @@ void hyperv_cleanup(void); > #else /* CONFIG_HYPERV */ > static inline void hyperv_init(void) {} > static inline bool hv_is_hypercall_page_setup(void) { return false; } > -static inline hyperv_cleanup(void) {} > +static inline void hyperv_cleanup(void) {} > #endif /* CONFIG_HYPERV */ Guys, Greg, could we please move this commit from the drivers tree: 2e252fbf777d: x86/hyper-v: include hyperv/ only when CONFIG_HYPERV is set arch/x86/Kbuild | 2 +- arch/x86/include/asm/mshyperv.h | 7 ++++++- ... to the x86 tree where it belongs? Thanks, Ingo ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][next] x86/hyper-v: add missing void return type to hyperv_cleanup declaration 2017-07-20 8:52 ` [PATCH][next] x86/hyper-v: add missing void return type to hyperv_cleanup declaration Ingo Molnar @ 2017-07-20 9:15 ` Greg Kroah-Hartman 2017-07-20 9:42 ` Ingo Molnar 0 siblings, 1 reply; 3+ messages in thread From: Greg Kroah-Hartman @ 2017-07-20 9:15 UTC (permalink / raw) To: Ingo Molnar Cc: Colin King, Vitaly Kuznetsov, K . Y . Srinivasan, Haiyang Zhang, Stephen Hemminger, Thomas Gleixner, Ingo Molnar, H . Peter Anvin, x86, kernel-janitors, linux-kernel On Thu, Jul 20, 2017 at 10:52:36AM +0200, Ingo Molnar wrote: > > * Colin King <colin.king@canonical.com> wrote: > > > From: Colin Ian King <colin.king@canonical.com> > > > > Add in missing void return type, fixes sparse warning: > > "warning: 'hyperv_cleanup()' has implicit return type" > > > > Fixes: 2e252fbf777d ("x86/hyper-v: include hyperv/ only when CONFIG_HYPERV is set") > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > > --- > > arch/x86/include/asm/mshyperv.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyperv.h > > index 01b9c0fb3aab..41fae263f8fa 100644 > > --- a/arch/x86/include/asm/mshyperv.h > > +++ b/arch/x86/include/asm/mshyperv.h > > @@ -178,7 +178,7 @@ void hyperv_cleanup(void); > > #else /* CONFIG_HYPERV */ > > static inline void hyperv_init(void) {} > > static inline bool hv_is_hypercall_page_setup(void) { return false; } > > -static inline hyperv_cleanup(void) {} > > +static inline void hyperv_cleanup(void) {} > > #endif /* CONFIG_HYPERV */ > > Guys, Greg, could we please move this commit from the drivers tree: > > 2e252fbf777d: x86/hyper-v: include hyperv/ only when CONFIG_HYPERV is set > > arch/x86/Kbuild | 2 +- > arch/x86/include/asm/mshyperv.h | 7 ++++++- > > ... to the x86 tree where it belongs? I've now reverted it from my tree entirely, sorry about that. greg k-h ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][next] x86/hyper-v: add missing void return type to hyperv_cleanup declaration 2017-07-20 9:15 ` Greg Kroah-Hartman @ 2017-07-20 9:42 ` Ingo Molnar 0 siblings, 0 replies; 3+ messages in thread From: Ingo Molnar @ 2017-07-20 9:42 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: Colin King, Vitaly Kuznetsov, K . Y . Srinivasan, Haiyang Zhang, Stephen Hemminger, Thomas Gleixner, Ingo Molnar, H . Peter Anvin, x86, kernel-janitors, linux-kernel * Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > On Thu, Jul 20, 2017 at 10:52:36AM +0200, Ingo Molnar wrote: > > > > * Colin King <colin.king@canonical.com> wrote: > > > > > From: Colin Ian King <colin.king@canonical.com> > > > > > > Add in missing void return type, fixes sparse warning: > > > "warning: 'hyperv_cleanup()' has implicit return type" > > > > > > Fixes: 2e252fbf777d ("x86/hyper-v: include hyperv/ only when CONFIG_HYPERV is set") > > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > > > --- > > > arch/x86/include/asm/mshyperv.h | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyperv.h > > > index 01b9c0fb3aab..41fae263f8fa 100644 > > > --- a/arch/x86/include/asm/mshyperv.h > > > +++ b/arch/x86/include/asm/mshyperv.h > > > @@ -178,7 +178,7 @@ void hyperv_cleanup(void); > > > #else /* CONFIG_HYPERV */ > > > static inline void hyperv_init(void) {} > > > static inline bool hv_is_hypercall_page_setup(void) { return false; } > > > -static inline hyperv_cleanup(void) {} > > > +static inline void hyperv_cleanup(void) {} > > > #endif /* CONFIG_HYPERV */ > > > > Guys, Greg, could we please move this commit from the drivers tree: > > > > 2e252fbf777d: x86/hyper-v: include hyperv/ only when CONFIG_HYPERV is set > > > > arch/x86/Kbuild | 2 +- > > arch/x86/include/asm/mshyperv.h | 7 ++++++- > > > > ... to the x86 tree where it belongs? > > I've now reverted it from my tree entirely, sorry about that. No problem - I'll pick up the fixed v2 version when it's posted. Thanks, Ingo ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-20 9:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20170719090859.9248-1-colin.king@canonical.com>
2017-07-20 8:52 ` [PATCH][next] x86/hyper-v: add missing void return type to hyperv_cleanup declaration Ingo Molnar
2017-07-20 9:15 ` Greg Kroah-Hartman
2017-07-20 9:42 ` Ingo Molnar
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®