* [PATCH 0/2] tracing, thermal: Hide trace events when not in use
@ 2017-10-13 14:19 Steven Rostedt
2017-10-13 14:21 ` [PATCH 1/2] tracing, thermal: Hide devfreq " Steven Rostedt
2017-10-13 14:23 ` [PATCH 2/2] tracing, thermal: Hide cpu cooling " Steven Rostedt
0 siblings, 2 replies; 5+ messages in thread
From: Steven Rostedt @ 2017-10-13 14:19 UTC (permalink / raw)
To: LKML; +Cc: Javi Merino, Eduardo Valentin
As trace events when defined create data structures and functions to
process them, defining trace events when not using them is a waste of
memory.
The trace events thermal_power_devfreq_get_power and
thermal_power_devfreq_limit are only used when CONFIG_DEVFREQ_THERMAL
is set. Make those events only defined when that is set as well.
The trace events thermal_power_cpu_get_power and
thermal_power_cpu_limit are only used when CONFIG_CPU_THERMAL is set.
Make those events only defined when that is set as well.
-- Steve
include/trace/events/thermal.h | 4 ++++
1 file changed, 4 insertions(+)
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] tracing, thermal: Hide devfreq trace events when not in use
2017-10-13 14:19 [PATCH 0/2] tracing, thermal: Hide trace events when not in use Steven Rostedt
@ 2017-10-13 14:21 ` Steven Rostedt
2017-10-17 7:15 ` Javi Merino
2017-10-13 14:23 ` [PATCH 2/2] tracing, thermal: Hide cpu cooling " Steven Rostedt
1 sibling, 1 reply; 5+ messages in thread
From: Steven Rostedt @ 2017-10-13 14:21 UTC (permalink / raw)
To: LKML; +Cc: Javi Merino, Eduardo Valentin
From: Steven Rostedt (VMware) <rostedt@goodmis.org>
As trace events when defined create data structures and functions to
process them, defining trace events when not using them is a waste of
memory.
The trace events thermal_power_devfreq_get_power and
thermal_power_devfreq_limit are only used when CONFIG_DEVFREQ_THERMAL
is set. Make those events only defined when that is set as well.
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
Index: linux-trace.git/include/trace/events/thermal.h
===================================================================
--- linux-trace.git.orig/include/trace/events/thermal.h
+++ linux-trace.git/include/trace/events/thermal.h
@@ -148,6 +148,7 @@ TRACE_EVENT(thermal_power_cpu_limit,
__entry->power)
);
+#ifdef CONFIG_DEVFREQ_THERMAL
TRACE_EVENT(thermal_power_devfreq_get_power,
TP_PROTO(struct thermal_cooling_device *cdev,
struct devfreq_dev_status *status, unsigned long freq,
@@ -203,6 +204,7 @@ TRACE_EVENT(thermal_power_devfreq_limit,
__get_str(type), __entry->freq, __entry->cdev_state,
__entry->power)
);
+#endif /* CONFIG_DEVFREQ_THERMAL */
#endif /* _TRACE_THERMAL_H */
/* This part must be outside protection */
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] tracing, thermal: Hide devfreq trace events when not in use
2017-10-13 14:21 ` [PATCH 1/2] tracing, thermal: Hide devfreq " Steven Rostedt
@ 2017-10-17 7:15 ` Javi Merino
0 siblings, 0 replies; 5+ messages in thread
From: Javi Merino @ 2017-10-17 7:15 UTC (permalink / raw)
To: Steven Rostedt; +Cc: LKML, Eduardo Valentin
On Fri, Oct 13, 2017 at 10:21:50AM -0400, Steven Rostedt wrote:
> From: Steven Rostedt (VMware) <rostedt@goodmis.org>
>
> As trace events when defined create data structures and functions to
> process them, defining trace events when not using them is a waste of
> memory.
>
> The trace events thermal_power_devfreq_get_power and
> thermal_power_devfreq_limit are only used when CONFIG_DEVFREQ_THERMAL
> is set. Make those events only defined when that is set as well.
>
> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Acked-by: Javi Merino <javi.merino@kernel.org>
> ---
> Index: linux-trace.git/include/trace/events/thermal.h
> ===================================================================
> --- linux-trace.git.orig/include/trace/events/thermal.h
> +++ linux-trace.git/include/trace/events/thermal.h
> @@ -148,6 +148,7 @@ TRACE_EVENT(thermal_power_cpu_limit,
> __entry->power)
> );
>
> +#ifdef CONFIG_DEVFREQ_THERMAL
> TRACE_EVENT(thermal_power_devfreq_get_power,
> TP_PROTO(struct thermal_cooling_device *cdev,
> struct devfreq_dev_status *status, unsigned long freq,
> @@ -203,6 +204,7 @@ TRACE_EVENT(thermal_power_devfreq_limit,
> __get_str(type), __entry->freq, __entry->cdev_state,
> __entry->power)
> );
> +#endif /* CONFIG_DEVFREQ_THERMAL */
> #endif /* _TRACE_THERMAL_H */
>
> /* This part must be outside protection */
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 2/2] tracing, thermal: Hide cpu cooling trace events when not in use
2017-10-13 14:19 [PATCH 0/2] tracing, thermal: Hide trace events when not in use Steven Rostedt
2017-10-13 14:21 ` [PATCH 1/2] tracing, thermal: Hide devfreq " Steven Rostedt
@ 2017-10-13 14:23 ` Steven Rostedt
2017-10-17 7:16 ` Javi Merino
1 sibling, 1 reply; 5+ messages in thread
From: Steven Rostedt @ 2017-10-13 14:23 UTC (permalink / raw)
To: LKML; +Cc: Javi Merino, Eduardo Valentin
From: Steven Rostedt (VMware) <rostedt@goodmis.org>
As trace events when defined create data structures and functions to
process them, defining trace events when not using them is a waste of
memory.
The trace events thermal_power_cpu_get_power and
thermal_power_cpu_limit are only used when CONFIG_CPU_THERMAL is set.
Make those events only defined when that is set as well.
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
Index: linux-trace.git/include/trace/events/thermal.h
===================================================================
--- linux-trace.git.orig/include/trace/events/thermal.h
+++ linux-trace.git/include/trace/events/thermal.h
@@ -90,6 +90,7 @@ TRACE_EVENT(thermal_zone_trip,
show_tzt_type(__entry->trip_type))
);
+#ifdef CONFIG_CPU_THERMAL
TRACE_EVENT(thermal_power_cpu_get_power,
TP_PROTO(const struct cpumask *cpus, unsigned long freq, u32 *load,
size_t load_len, u32 dynamic_power, u32 static_power),
@@ -147,6 +148,7 @@ TRACE_EVENT(thermal_power_cpu_limit,
__get_bitmask(cpumask), __entry->freq, __entry->cdev_state,
__entry->power)
);
+#endif /* CONFIG_CPU_THERMAL */
#ifdef CONFIG_DEVFREQ_THERMAL
TRACE_EVENT(thermal_power_devfreq_get_power,
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] tracing, thermal: Hide cpu cooling trace events when not in use
2017-10-13 14:23 ` [PATCH 2/2] tracing, thermal: Hide cpu cooling " Steven Rostedt
@ 2017-10-17 7:16 ` Javi Merino
0 siblings, 0 replies; 5+ messages in thread
From: Javi Merino @ 2017-10-17 7:16 UTC (permalink / raw)
To: Steven Rostedt; +Cc: LKML, Eduardo Valentin
On Fri, Oct 13, 2017 at 10:23:09AM -0400, Steven Rostedt wrote:
> From: Steven Rostedt (VMware) <rostedt@goodmis.org>
>
> As trace events when defined create data structures and functions to
> process them, defining trace events when not using them is a waste of
> memory.
>
> The trace events thermal_power_cpu_get_power and
> thermal_power_cpu_limit are only used when CONFIG_CPU_THERMAL is set.
> Make those events only defined when that is set as well.
>
> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Acked-by: Javi Merino <javi.merino@kernel.org>
> ---
> Index: linux-trace.git/include/trace/events/thermal.h
> ===================================================================
> --- linux-trace.git.orig/include/trace/events/thermal.h
> +++ linux-trace.git/include/trace/events/thermal.h
> @@ -90,6 +90,7 @@ TRACE_EVENT(thermal_zone_trip,
> show_tzt_type(__entry->trip_type))
> );
>
> +#ifdef CONFIG_CPU_THERMAL
> TRACE_EVENT(thermal_power_cpu_get_power,
> TP_PROTO(const struct cpumask *cpus, unsigned long freq, u32 *load,
> size_t load_len, u32 dynamic_power, u32 static_power),
> @@ -147,6 +148,7 @@ TRACE_EVENT(thermal_power_cpu_limit,
> __get_bitmask(cpumask), __entry->freq, __entry->cdev_state,
> __entry->power)
> );
> +#endif /* CONFIG_CPU_THERMAL */
>
> #ifdef CONFIG_DEVFREQ_THERMAL
> TRACE_EVENT(thermal_power_devfreq_get_power,
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-10-17 7:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-13 14:19 [PATCH 0/2] tracing, thermal: Hide trace events when not in use Steven Rostedt
2017-10-13 14:21 ` [PATCH 1/2] tracing, thermal: Hide devfreq " Steven Rostedt
2017-10-17 7:15 ` Javi Merino
2017-10-13 14:23 ` [PATCH 2/2] tracing, thermal: Hide cpu cooling " Steven Rostedt
2017-10-17 7:16 ` Javi Merino
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®