* [PATCH net-next] net: dsa: Fix dsa_legacy_register() return value
@ 2017-12-29 19:05 Florian Fainelli
2018-01-03 2:53 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Florian Fainelli @ 2017-12-29 19:05 UTC (permalink / raw)
To: netdev
Cc: davem, Egil Hjelmeland, Florian Fainelli, Andrew Lunn,
Vivien Didelot, open list
We need to make the dsa_legacy_register() stub return 0 in order for
dsa_init_module() to successfully register and continue registering the
ETH_P_XDSA packet handler.
Fixes: 2a93c1a3651f ("net: dsa: Allow compiling out legacy support")
Reported-by: Egil Hjelmeland <privat@egil-hjelmeland.no>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
net/dsa/dsa_priv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/dsa/dsa_priv.h b/net/dsa/dsa_priv.h
index b03665e8fb4e..cefb0c3c6d51 100644
--- a/net/dsa/dsa_priv.h
+++ b/net/dsa/dsa_priv.h
@@ -103,7 +103,7 @@ void dsa_legacy_unregister(void);
#else
static inline int dsa_legacy_register(void)
{
- return -ENODEV;
+ return 0;
}
static inline void dsa_legacy_unregister(void) { }
--
2.14.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH net-next] net: dsa: Fix dsa_legacy_register() return value
2017-12-29 19:05 [PATCH net-next] net: dsa: Fix dsa_legacy_register() return value Florian Fainelli
@ 2018-01-03 2:53 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-01-03 2:53 UTC (permalink / raw)
To: f.fainelli; +Cc: netdev, privat, andrew, vivien.didelot, linux-kernel
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Fri, 29 Dec 2017 11:05:45 -0800
> We need to make the dsa_legacy_register() stub return 0 in order for
> dsa_init_module() to successfully register and continue registering the
> ETH_P_XDSA packet handler.
>
> Fixes: 2a93c1a3651f ("net: dsa: Allow compiling out legacy support")
> Reported-by: Egil Hjelmeland <privat@egil-hjelmeland.no>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Applied, thanks Florian.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-03 2:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-29 19:05 [PATCH net-next] net: dsa: Fix dsa_legacy_register() return value Florian Fainelli
2018-01-03 2:53 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®