* [PATCH] slimbus: Unlock on error path in slim_msg_response()
@ 2018-01-09 9:34 Dan Carpenter
2018-01-09 9:48 ` Srinivas Kandagatla
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2018-01-09 9:34 UTC (permalink / raw)
To: Srinivas Kandagatla, Sagar Dharia
Cc: alsa-devel, linux-kernel, kernel-janitors, Greg Kroah-Hartman
We need to unlock and restore IRQs before returning on this error path.
Fixes afbdcc7c384b0 ("slimbus: Add messaging APIs to slimbus framework")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/slimbus/messaging.c b/drivers/slimbus/messaging.c
index 755462a4c75e..94818a8427e2 100644
--- a/drivers/slimbus/messaging.c
+++ b/drivers/slimbus/messaging.c
@@ -36,6 +36,7 @@ void slim_msg_response(struct slim_controller *ctrl, u8 *reply, u8 tid, u8 len)
msg = txn->msg;
if (msg == NULL || msg->rbuf == NULL) {
+ spin_unlock_irqrestore(&ctrl->txn_lock, flags);
dev_err(ctrl->dev, "Got response to invalid TID:%d, len:%d\n",
tid, len);
return;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] slimbus: Unlock on error path in slim_msg_response()
2018-01-09 9:34 [PATCH] slimbus: Unlock on error path in slim_msg_response() Dan Carpenter
@ 2018-01-09 9:48 ` Srinivas Kandagatla
0 siblings, 0 replies; 2+ messages in thread
From: Srinivas Kandagatla @ 2018-01-09 9:48 UTC (permalink / raw)
To: Dan Carpenter, Sagar Dharia
Cc: alsa-devel, linux-kernel, kernel-janitors, Greg Kroah-Hartman
On 09/01/18 09:34, Dan Carpenter wrote:
> We need to unlock and restore IRQs before returning on this error path.
>
> Fixes afbdcc7c384b0 ("slimbus: Add messaging APIs to slimbus framework")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/slimbus/messaging.c b/drivers/slimbus/messaging.c
> index 755462a4c75e..94818a8427e2 100644
> --- a/drivers/slimbus/messaging.c
> +++ b/drivers/slimbus/messaging.c
> @@ -36,6 +36,7 @@ void slim_msg_response(struct slim_controller *ctrl, u8 *reply, u8 tid, u8 len)
>
> msg = txn->msg;
> if (msg == NULL || msg->rbuf == NULL) {
> + spin_unlock_irqrestore(&ctrl->txn_lock, flags);
> dev_err(ctrl->dev, "Got response to invalid TID:%d, len:%d\n",
> tid, len);
> return;
>
Pl note that there are already some patches in flight which are yet to
be merged fixes most of the static checker errors :
This is already fixed at:
https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1575798.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-09 9:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-09 9:34 [PATCH] slimbus: Unlock on error path in slim_msg_response() Dan Carpenter
2018-01-09 9:48 ` Srinivas Kandagatla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®