From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Borislav Petkov <bp@alien8.de>
Cc: X86 ML <x86@kernel.org>, Andy Lutomirski <luto@amacapital.net>,
Linus Torvalds <torvalds@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 8/9] x86/dumpstack: Save first regs set for the executive summary
Date: Fri, 16 Mar 2018 07:01:12 -0500 [thread overview]
Message-ID: <20180316120112.mqjvkdgl27scds6p@treble> (raw)
In-Reply-To: <20180316114849.GD5852@pd.tnic>
On Fri, Mar 16, 2018 at 12:48:49PM +0100, Borislav Petkov wrote:
> [ 29.046500] sysrq: SysRq : Trigger a crash
> [ 29.048605] BUG: unable to handle kernel NULL pointer dereference at 0000000000000000
> [ 29.051639] PGD 79afd067 P4D 79afd067 PUD 7a1a2067 PMD 0
> [ 29.052557] Oops: 0002 [#1] PREEMPT SMP
> [ 29.052557] CPU: 7 PID: 3693 Comm: bash Not tainted 4.16.0-rc5+ #8
> [ 29.052557] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.2-1 04/01/2014
> [ 29.052557] RIP: 0010:sysrq_handle_crash+0x17/0x20
> [ 29.052557] Code: d1 e8 6d 08 b7 ff 0f 1f 00 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 e8 76 1f bd ff c7 05 a4 12 19 01 01 00 00 00 0f ae f8 <c6> 04 25 00 00 00 00 01 c3 0f 1f 44 00 00 e8 c6 1b c2 ff fb e9 80
> [ 29.052557] RSP: 0018:ffffc900007cbdf0 EFLAGS: 00010246
> [ 29.052557] RAX: 0000000000000000 RBX: 0000000000000063 RCX: 0000000000000000
> [ 29.052557] RDX: 0000000000000000 RSI: ffffffff81101e0a RDI: 0000000000000063
> [ 29.052557] RBP: ffffffff822714c0 R08: 0000000000000185 R09: 000000000000b5a4
> [ 29.052557] R10: 0000000000000000 R11: 0000000000000000 R12: 000000000000000a
> [ 29.052557] R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
> [ 29.052557] FS: 00007ffff7fdb700(0000) GS:ffff88007edc0000(0000) knlGS:0000000000000000
> [ 29.052557] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [ 29.052557] CR2: 0000000000000000 CR3: 00000000799e1000 CR4: 00000000000406e0
> [ 29.052557] Call Trace:
> [ 29.052557] __handle_sysrq+0x9e/0x160
> [ 29.052557] write_sysrq_trigger+0x2b/0x30
> [ 29.052557] proc_reg_write+0x38/0x70
> [ 29.052557] __vfs_write+0x36/0x160
> [ 29.052557] ? __fd_install+0x69/0x110
> [ 29.052557] ? preempt_count_add+0x74/0xb0
> [ 29.052557] ? _raw_spin_lock+0x13/0x30
> [ 29.052557] ? set_close_on_exec+0x41/0x80
> [ 29.052557] ? preempt_count_sub+0xa8/0x100
> [ 29.052557] vfs_write+0xc0/0x190
> [ 29.052557] SyS_write+0x64/0xe0
> [ 29.052557] ? trace_hardirqs_off_thunk+0x1a/0x1c
> [ 29.052557] do_syscall_64+0x70/0x130
> [ 29.052557] entry_SYSCALL_64_after_hwframe+0x42/0xb7
> [ 29.052557] RIP: 0033:0x7ffff74b9620
> [ 29.052557] Code: Bad RIP value.
> [ 29.052557] RSP: 002b:00007fffffffe6f8 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
> [ 29.052557] RAX: ffffffffffffffda RBX: 0000000000000002 RCX: 00007ffff74b9620
> [ 29.052557] RDX: 0000000000000002 RSI: 0000000000705408 RDI: 0000000000000001
> [ 29.052557] RBP: 0000000000705408 R08: 000000000000000a R09: 00007ffff7fdb700
> [ 29.052557] R10: 00007ffff77826a0 R11: 0000000000000246 R12: 00007ffff77842a0
> [ 29.052557] R13: 0000000000000002 R14: 0000000000000001 R15: 0000000000000000
Hm, the "Code: Bad RIP value" will always be shown for syscall regs,
which will probably cause some unnecessary confusion/worry. Should we
just skip printing it for the "regs->ip < PAGE_OFFSET" case?
--
Josh
next prev parent reply other threads:[~2018-03-16 12:01 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-15 15:44 [PATCH 0/9] x86/dumpstack: Cleanups and user opcode bytes Code: section, v2 Borislav Petkov
2018-03-15 15:44 ` [PATCH 1/9] x86/dumstack: Remove code_bytes Borislav Petkov
2018-03-15 18:12 ` Josh Poimboeuf
2018-03-15 15:44 ` [PATCH 2/9] x86/dumpstack: Unexport oops_begin() Borislav Petkov
2018-03-15 15:44 ` [PATCH 3/9] x86/dumpstack: Carve out Code: dumping into a function Borislav Petkov
2018-03-15 15:44 ` [PATCH 4/9] x86/dumpstack: Improve opcodes dumping in the Code: section Borislav Petkov
2018-03-15 18:10 ` Josh Poimboeuf
2018-03-15 18:16 ` Borislav Petkov
2018-03-15 19:06 ` Josh Poimboeuf
2018-03-16 11:57 ` David Laight
2018-03-15 18:19 ` Josh Poimboeuf
2018-03-15 18:23 ` Josh Poimboeuf
2018-03-15 15:44 ` [PATCH 5/9] x86/dumpstack: Add loglevel argument to show_opcodes() Borislav Petkov
2018-03-15 15:44 ` [PATCH 6/9] x86/fault: Dump user opcode bytes on fatal faults Borislav Petkov
2018-03-15 15:44 ` [PATCH 7/9] x86/dumpstack: Add a show_ip() function Borislav Petkov
2018-03-15 18:34 ` Josh Poimboeuf
2018-03-15 18:55 ` Borislav Petkov
2018-03-15 15:44 ` [PATCH 8/9] x86/dumpstack: Save first regs set for the executive summary Borislav Petkov
2018-03-15 19:01 ` Josh Poimboeuf
2018-03-16 11:48 ` Borislav Petkov
2018-03-16 12:01 ` Josh Poimboeuf [this message]
2018-03-16 12:11 ` Borislav Petkov
2018-03-16 13:16 ` Josh Poimboeuf
2018-03-16 13:44 ` Borislav Petkov
2018-03-16 17:22 ` Linus Torvalds
2018-03-16 17:40 ` Josh Poimboeuf
2018-03-16 17:45 ` Borislav Petkov
2018-03-16 18:38 ` Josh Poimboeuf
2018-03-15 15:44 ` [PATCH 9/9] x86/dumpstack: Explain the reasoning for the prologue and buffer size Borislav Petkov
2018-03-15 18:07 ` Josh Poimboeuf
2018-03-15 18:17 ` Borislav Petkov
2018-03-15 17:51 ` [PATCH 0/9] x86/dumpstack: Cleanups and user opcode bytes Code: section, v2 Linus Torvalds
2018-04-17 14:40 ` Borislav Petkov
2018-04-17 20:16 ` Josh Poimboeuf
2018-04-17 21:06 ` Borislav Petkov
2018-04-18 13:26 ` Josh Poimboeuf
2018-04-17 16:11 [PATCH 0/9] x86/dumpstack: Cleanups and user opcode bytes Code: section, v3 Borislav Petkov
2018-04-17 16:11 ` [PATCH 8/9] x86/dumpstack: Save first regs set for the executive summary Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180316120112.mqjvkdgl27scds6p@treble \
--to=jpoimboe@redhat.com \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®