[PATCH] arm64: dts: allwinner: a64: Disable SPDIF by default

[PATCH] arm64: dts: allwinner: a64: Disable SPDIF by default

[Samuel Holland]

As of v5.7-rc2, Linux now prints the following message at boot:

  [   33.848525] platform sound_spdif: deferred probe pending

This is because &sound_spdif is waiting on its DAI link component
&spdif to probe, but &spdif is disabled in the DTS. Disable the
audio card as well to match.

Signed-off-by: Samuel Holland <samuel@sholland.org>
---
 arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
index 6f8c30d89b9b..6c233ff031c6 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
@@ -169,6 +169,7 @@ link0_codec: codec {
 	sound_spdif {
 		compatible = "simple-audio-card";
 		simple-audio-card,name = "On-board SPDIF";
+		status = "disabled";
 
 		simple-audio-card,cpu {
 			sound-dai = <&spdif>;
-- 
2.24.1

Re: [linux-sunxi] [PATCH] arm64: dts: allwinner: a64: Disable SPDIF by default

[Clément Péron]

Hi Samuel,

On Wed, 22 Apr 2020 at 06:11, Samuel Holland <samuel@sholland.org> wrote:
>
> As of v5.7-rc2, Linux now prints the following message at boot:
>
>   [   33.848525] platform sound_spdif: deferred probe pending
>
> This is because &sound_spdif is waiting on its DAI link component
> &spdif to probe, but &spdif is disabled in the DTS. Disable the
> audio card as well to match.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
>  arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> index 6f8c30d89b9b..6c233ff031c6 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> @@ -169,6 +169,7 @@ link0_codec: codec {
>         sound_spdif {
>                 compatible = "simple-audio-card";
>                 simple-audio-card,name = "On-board SPDIF";
> +               status = "disabled";
>
>                 simple-audio-card,cpu {
>                         sound-dai = <&spdif>;

This "On-board SPDIF" node is board specific and should be moved to
each board instead of be disabled here.

Maybe drop the node, and people who need it whould reintroduce it properly?

Regards,
Clement


> --
> 2.24.1
>
> --
> You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com.
> To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/20200422041502.7497-1-samuel%40sholland.org.

Re: [PATCH] arm64: dts: allwinner: a64: Disable SPDIF by default

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 561 bytes --]

Hi,

On Tue, Apr 21, 2020 at 11:15:02PM -0500, Samuel Holland wrote:
> As of v5.7-rc2, Linux now prints the following message at boot:
> 
>   [   33.848525] platform sound_spdif: deferred probe pending
> 
> This is because &sound_spdif is waiting on its DAI link component
> &spdif to probe, but &spdif is disabled in the DTS. Disable the
> audio card as well to match.
> 
> Signed-off-by: Samuel Holland <samuel@sholland.org>

The patch looks good, but don't we have some boards with SPDIF enabled that
should be modified accordingly?

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH] arm64: dts: allwinner: a64: Disable SPDIF by default

[Samuel Holland]

Maxime,

On 4/22/20 10:16 AM, Maxime Ripard wrote:
> On Tue, Apr 21, 2020 at 11:15:02PM -0500, Samuel Holland wrote:
>> As of v5.7-rc2, Linux now prints the following message at boot:
>>
>>   [   33.848525] platform sound_spdif: deferred probe pending
>>
>> This is because &sound_spdif is waiting on its DAI link component
>> &spdif to probe, but &spdif is disabled in the DTS. Disable the
>> audio card as well to match.
>>
>> Signed-off-by: Samuel Holland <samuel@sholland.org>
> 
> The patch looks good, but don't we have some boards with SPDIF enabled that
> should be modified accordingly?

I don't see any in-tree. The only A64 DTS that references &spdif at all is
sun50i-a64-pine64.dts, which explicitly disables it:

	/* On Euler connector */
	&spdif {
  		status = "disabled";
	};

I'm leaning toward agreeing with Clement that the sound_spdif node (and also
spdif_out) should be removed altogether from the A64 DTSI.

Regards,
Samuel

Re: [linux-sunxi] Re: [PATCH] arm64: dts: allwinner: a64: Disable SPDIF by default

[Clément Péron]

Hi Samuel, Maxime,

On Thu, 23 Apr 2020 at 01:50, Samuel Holland <samuel@sholland.org> wrote:
>
> Maxime,
>
> On 4/22/20 10:16 AM, Maxime Ripard wrote:
> > On Tue, Apr 21, 2020 at 11:15:02PM -0500, Samuel Holland wrote:
> >> As of v5.7-rc2, Linux now prints the following message at boot:
> >>
> >>   [   33.848525] platform sound_spdif: deferred probe pending
> >>
> >> This is because &sound_spdif is waiting on its DAI link component
> >> &spdif to probe, but &spdif is disabled in the DTS. Disable the
> >> audio card as well to match.
> >>
> >> Signed-off-by: Samuel Holland <samuel@sholland.org>
> >
> > The patch looks good, but don't we have some boards with SPDIF enabled that
> > should be modified accordingly?
>
> I don't see any in-tree. The only A64 DTS that references &spdif at all is
> sun50i-a64-pine64.dts, which explicitly disables it:

This has been introduced by Marcus Cooper for the Pine64 audio extension.
https://store.pine64.org/?product=pine64-stereo-audio-dac-pot-board

So this should be moved to an overlay no?

Regards,
Clement

>
>         /* On Euler connector */
>         &spdif {
>                 status = "disabled";
>         };
>
> I'm leaning toward agreeing with Clement that the sound_spdif node (and also
> spdif_out) should be removed altogether from the A64 DTSI.
>
> Regards,
> Samuel
>
> --
> You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com.
> To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/b554ea70-16da-1637-d349-db51dddcf95b%40sholland.org.

Re: [PATCH] arm64: dts: allwinner: a64: Disable SPDIF by default

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 1265 bytes --]

On Wed, Apr 22, 2020 at 06:50:54PM -0500, Samuel Holland wrote:
> Maxime,
> 
> On 4/22/20 10:16 AM, Maxime Ripard wrote:
> > On Tue, Apr 21, 2020 at 11:15:02PM -0500, Samuel Holland wrote:
> >> As of v5.7-rc2, Linux now prints the following message at boot:
> >>
> >>   [   33.848525] platform sound_spdif: deferred probe pending
> >>
> >> This is because &sound_spdif is waiting on its DAI link component
> >> &spdif to probe, but &spdif is disabled in the DTS. Disable the
> >> audio card as well to match.
> >>
> >> Signed-off-by: Samuel Holland <samuel@sholland.org>
> > 
> > The patch looks good, but don't we have some boards with SPDIF enabled that
> > should be modified accordingly?
> 
> I don't see any in-tree. The only A64 DTS that references &spdif at all is
> sun50i-a64-pine64.dts, which explicitly disables it:
> 
> 	/* On Euler connector */
> 	&spdif {
>   		status = "disabled";
> 	};
> 
> I'm leaning toward agreeing with Clement that the sound_spdif node (and also
> spdif_out) should be removed altogether from the A64 DTSI.

Yeah, I agree, it's pretty much what we've been doing in other SoCs. Especially
if we don't have any DT in-tree using it, we don't really have any incentive to
make it common.

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]