From: Simao Gomes Viana <devel@superboring.dev>
To: linux-kernel@vger.kernel.org
Cc: Simao Gomes Viana <devel@superboring.dev>, Joe Perches <joe@perches.com>
Subject: [PATCH 5/9] drivers: cdrom: swap sides of comparison
Date: Fri, 19 Jun 2020 21:33:37 +0200 [thread overview]
Message-ID: <20200619193341.51209-5-devel@superboring.dev> (raw)
In-Reply-To: <20200619193341.51209-1-devel@superboring.dev>
These were reported by scripts/checkpatch.pl
Signed-off-by: Simao Gomes Viana <devel@superboring.dev>
---
drivers/cdrom/cdrom.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
index 49073b1c7919..53e592423adb 100644
--- a/drivers/cdrom/cdrom.c
+++ b/drivers/cdrom/cdrom.c
@@ -749,7 +749,7 @@ static int cdrom_is_random_writable(struct cdrom_device_info *cdi, int *write)
if (ret)
return ret;
- if (CDF_RWRT == be16_to_cpu(rfd.feature_code))
+ if (be16_to_cpu(rfd.feature_code) == CDF_RWRT)
*write = 1;
return 0;
@@ -863,7 +863,7 @@ static int cdrom_ram_open_write(struct cdrom_device_info *cdi)
ret = cdrom_get_random_writable(cdi, &rfd);
if (ret)
return ret;
- else if (CDF_RWRT == be16_to_cpu(rfd.feature_code))
+ else if (be16_to_cpu(rfd.feature_code) == CDF_RWRT)
ret = !rfd.curr;
cd_dbg(CD_OPEN, "can open for random write\n");
--
2.27.0
next prev parent reply other threads:[~2020-06-19 19:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 18:08 [PATCH 1/2] drivers: cdrom: fix all errors reported by checkpatch Simao Gomes Viana
2020-06-19 18:08 ` [PATCH 2/2] drivers: cdrom: add missing SPDX license identifier Simao Gomes Viana
2020-06-19 18:29 ` [PATCH 1/2] drivers: cdrom: fix all errors reported by checkpatch Joe Perches
2020-06-19 18:41 ` Simao Gomes Viana
2020-06-19 19:33 ` [PATCH 1/9] drivers: cdrom: fix horizontal whitespace Simao Gomes Viana
2020-06-19 19:33 ` [PATCH 2/9] drivers: cdrom: fix comment style Simao Gomes Viana
2020-06-19 19:33 ` [PATCH 3/9] drivers: cdrom: replace func name by __func__ Simao Gomes Viana
2020-06-19 19:33 ` [PATCH 4/9] drivers: cdrom: rewrite embedded assignments in multiple lines Simao Gomes Viana
2020-06-19 19:33 ` Simao Gomes Viana [this message]
2020-06-19 19:33 ` [PATCH 6/9] drivers: cdrom: add missing newlines (vertical space) Simao Gomes Viana
2020-06-19 19:33 ` [PATCH 7/9] drivers: cdrom: miscellaneous code style fixes Simao Gomes Viana
2020-06-19 19:33 ` [PATCH 8/9] drivers: cdrom: change unsigned to unsigned int Simao Gomes Viana
2020-06-19 19:33 ` [PATCH 9/9] drivers: cdrom: fix spacing and wrapping Simao Gomes Viana
2020-06-19 21:26 ` [PATCH 1/2] drivers: cdrom: fix all errors reported by checkpatch Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200619193341.51209-5-devel@superboring.dev \
--to=devel@superboring.dev \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome